{"thread":{"id":"7120","subject":"[PATCH] More build output cleaning up","startedAt":"2007-03-06T23:13:08Z","lastAt":"2007-03-12T09:04:00Z","messageCount":4,"participants":["Alex Riesen","Sergey Vlasov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"36492","messageId":"81b0412b0703061513g7aafc9daq46feea69d969089a@mail.gmail.com","threadId":"7120","inReplyTo":null,"subject":"[PATCH] More build output cleaning up","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-06T23:13:08Z","receivedAt":"2007-03-06T23:13:08Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"- print output file name for .c files\n- suppress output of the names of subdirectories when make changes into them\n- use GEN prefix for makefile generation in perl/\n\nSigned-off-by: Alex Riesen \n---\n Makefile | 8 +++++---\n perl/Makefile | 2 +-\n 2 files changed, 6 insertions(+), 4 deletions(-)\n\n\nFrom 76d21c5a5a0dacfc09ed18f72b45c3f1fc174b0c Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen \nDate: Tue, 6 Mar 2007 23:37:18 +0100\nSubject: [PATCH] More build output cleaning up\n\n- print output file name for .c files\n- suppress output of the names of subdirectories when make changes into them\n- use GEN prefix for makefile generation in perl/\n\nSigned-off-by: Alex Riesen \n---\n Makefile | 8 +++++---\n perl/Makefile | 2 +-\n 2 files changed, 6 insertions(+), 4 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 72d4291..eb6c421 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -605,14 +605,16 @@ ifdef NO_PERL_MAKEMAKER\n \texport NO_PERL_MAKEMAKER\n endif\n ifndef V\n-\tQUIET_CC = @echo ' ' CC $<;\n+\tQUIET_CC = @echo ' ' CC $@;\n \tQUIET_AR = @echo ' ' AR $@;\n \tQUIET_LINK = @echo ' ' LINK $@;\n \tQUIET_BUILT_IN = @echo ' ' BUILTIN $@;\n \tQUIET_GEN = @echo ' ' GEN $@;\n \tQUIET_SUBDIR0 = @subdir=\n-\tQUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; $(MAKE) -C$$subdir\n+\tQUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; \\\n+\t\t\t $(MAKE) --no-print-directory -C $$subdir\n \texport V\n+\texport QUIET_GEN\n else\n \tQUIET_SUBDIR0 = $(MAKE) -C\n \tQUIET_SUBDIR1 =\n@@ -685,7 +687,7 @@ $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh\n $(patsubst %.perl,%,$(SCRIPT_PERL)): perl/perl.mak\n \n perl/perl.mak: GIT-CFLAGS\n-\t$(MAKE) -C perl PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' $(@F)\n+\t$(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' $(@F)\n \n $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl\n \t$(QUIET_GEN)rm -f $@ $@+ && \\\ndiff --git a/perl/Makefile b/perl/Makefile\nindex 17d004e..5ec0389 100644\n--- a/perl/Makefile\n+++ b/perl/Makefile\n@@ -33,7 +33,7 @@ $(makfile): ../GIT-CFLAGS Makefile\n \techo '\techo $(instdir_SQ)' >> $@\n else\n $(makfile): Makefile.PL ../GIT-CFLAGS\n-\t'$(PERL_PATH_SQ)' $< PREFIX='$(prefix_SQ)'\n+\t$(QUIET_GEN)'$(PERL_PATH_SQ)' $< PREFIX='$(prefix_SQ)'\n endif\n \n # this is just added comfort for calling make directly in perl dir\n-- \n1.5.0.3.410.gca42\n\n"},{"id":"36496","messageId":"81b0412b0703061519h17ddc517rb11499893dda6ac5@mail.gmail.com","threadId":"7120","inReplyTo":"81b0412b0703061513g7aafc9daq46feea69d969089a@mail.gmail.com","subject":"Re: [PATCH] More build output cleaning up","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-06T23:19:07Z","receivedAt":"2007-03-06T23:19:07Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Oh, damn... I did it again. Stupid gmail...\nI'll try to resend them from my home account, but that\nprobably wont work (it never did). Vger (or whatever else)\nkeeps dropping them.\n"},{"id":"36811","messageId":"20070311184827.a98691c3.vsu@altlinux.ru","threadId":"7120","inReplyTo":"81b0412b0703061513g7aafc9daq46feea69d969089a@mail.gmail.com","subject":"Re: [PATCH] More build output cleaning up","fromName":"Sergey Vlasov","fromEmail":"vsu@altlinux.ru","sentAt":"2007-03-11T15:48:27Z","receivedAt":"2007-03-11T15:48:27Z","isPatch":true,"sender":{"key":"vsu@altlinux.ru","avatar":"https://avatars.githubusercontent.com/u/616082?v=4"},"body":"On Wed, 7 Mar 2007 00:13:08 +0100 Alex Riesen wrote:\n\n> - print output file name for .c files\n> - suppress output of the names of subdirectories when make changes into them\n> - use GEN prefix for makefile generation in perl/\n>\n> Signed-off-by: Alex Riesen \n> ---\n> Makefile | 8 +++++---\n> perl/Makefile | 2 +-\n> 2 files changed, 6 insertions(+), 4 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index 72d4291..eb6c421 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -605,14 +605,16 @@ ifdef NO_PERL_MAKEMAKER\n> \texport NO_PERL_MAKEMAKER\n> endif\n> ifndef V\n> -\tQUIET_CC = @echo ' ' CC $<;\n> +\tQUIET_CC = @echo ' ' CC $@;\n> \tQUIET_AR = @echo ' ' AR $@;\n> \tQUIET_LINK = @echo ' ' LINK $@;\n> \tQUIET_BUILT_IN = @echo ' ' BUILTIN $@;\n> \tQUIET_GEN = @echo ' ' GEN $@;\n> \tQUIET_SUBDIR0 = @subdir=\n> -\tQUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; $(MAKE) -C$$subdir\n> +\tQUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; \\\n> +\t\t\t $(MAKE) --no-print-directory -C $$subdir\n\nUsing --no-print-directory will break movement to the location of an\nerror/warning message at least in vim (emacs will probably have\nproblems too), if the error is in some file in a subdirectory. The\nproblem is that the nested make will output paths relative to the\nsubdirectory, but without \"Entering directory...\" messages the editor\nwill not know that filenames should be interpreted relative to that\nsubdirectory.\n\nCurrently this problem is not visible, because subdirectories with\ntheir own Makefiles (perl/ and git-gui/) do not contain C code - but\nthe problem will appear, e.g., if Git.xs will be added again.\n"},{"id":"36894","messageId":"81b0412b0703120204m2d7a543ep3eec68a580f595ff@mail.gmail.com","threadId":"7120","inReplyTo":"20070311184827.a98691c3.vsu@altlinux.ru","subject":"Re: [PATCH] More build output cleaning up","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-03-12T09:04:00Z","receivedAt":"2007-03-12T09:04:00Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 3/11/07, Sergey Vlasov wrote:\n>\n> Using --no-print-directory will break movement to the location of an\n> error/warning message at least in vim (emacs will probably have\n> problems too), if the error is in some file in a subdirectory. The\n\nYou can setup the make command-line to contain -w. It will work\nfor git and for any other project you may have.\n"}]}