{"thread":{"id":"7059","subject":"[PATCH 7/7] Remove byte-compiler warnings","startedAt":"2007-03-03T10:20:46Z","lastAt":"2007-03-03T10:20:46Z","messageCount":1,"participants":["Xavier Maillard"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"36165","messageId":"15326.1172917246@localhost","threadId":"7059","inReplyTo":null,"subject":"[PATCH 7/7] Remove byte-compiler warnings","fromName":"Xavier Maillard","fromEmail":"zedek@gnu.org","sentAt":"2007-03-03T10:20:46Z","receivedAt":"2007-03-03T10:20:46Z","isPatch":true,"sender":{"key":"zedek@gnu.org","avatar":null},"body":"\n* emacs/git-blame.el: Do not load cl at run-time. Added several defvar\n  to silent byte-compiler.\n  Interactive form in git-reblame was not correct, fixed that.\n\nSigned-off-by: Xavier Maillard <zedek@gnu.org>\n---\n contrib/emacs/git-blame.el |   16 ++++++++++++++--\n 1 files changed, 14 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el\nindex 64ad50b..ce029ad 100644\n--- a/contrib/emacs/git-blame.el\n+++ b/contrib/emacs/git-blame.el\n@@ -77,7 +77,8 @@\n ;;\n ;;; Code:\n \n-(require 'cl)\t\t\t      ; to use `push', `pop'\n+(eval-when-compile \n+  (require 'cl))\t\t\t      ; to use `push', `pop'\n \n (defun color-scale (l)\n   (let* ((colors ())\n@@ -127,11 +128,22 @@\n \n (defvar git-blame-mode nil)\n (make-variable-buffer-local 'git-blame-mode)\n+\n+(defvar git-blame-current nil)\n+(make-variable-buffer-local 'git-blame-current)\n+\n+(defvar git-blame-file nil)\n+(make-variable-buffer-local 'git-blame-file)\n+\n+(defvar git-blame-colors nil)\n+(make-variable-buffer-local 'git-blame-colors)\n+\n (unless (assq 'git-blame-mode minor-mode-alist)\n   (setq minor-mode-alist\n \t(cons (list 'git-blame-mode \" blame\")\n \t      minor-mode-alist)))\n \n+\n ;;;###autoload\n (defun git-blame-mode (&optional arg)\n   \"Minor mode for displaying Git blame\"\n@@ -157,9 +169,9 @@\n ;;;###autoload\n (defun git-reblame ()\n   \"Recalculate all blame information in the current buffer\"\n+  (interactive)\n   (unless git-blame-mode\n     (error \"git-blame is not active\"))\n-  (interactive)\n   (git-blame-cleanup)\n   (git-blame-run))\n \n-- \n1.5.0\n"}]}