{"thread":{"id":"7058","subject":"[PATCH 6/7] Small changes","startedAt":"2007-03-03T10:20:17Z","lastAt":"2007-03-05T08:46:47Z","messageCount":4,"participants":["Xavier Maillard","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"36164","messageId":"15313.1172917217@localhost","threadId":"7058","inReplyTo":null,"subject":"[PATCH 6/7] Small changes","fromName":"Xavier Maillard","fromEmail":"zedek@gnu.org","sentAt":"2007-03-03T10:20:17Z","receivedAt":"2007-03-03T10:20:17Z","isPatch":true,"sender":{"key":"zedek@gnu.org","avatar":null},"body":"\n* Makefile: add git-blame as a candidate to the\n byte-compilation. Change the function to call to byte-compile.\n\nSigned-off-by: Xavier Maillard \n---\n contrib/emacs/Makefile | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/emacs/Makefile b/contrib/emacs/Makefile\nindex 350846d..8554e39 100644\n--- a/contrib/emacs/Makefile\n+++ b/contrib/emacs/Makefile\n@@ -2,7 +2,7 @@\n \n EMACS = emacs\n \n-ELC = git.elc vc-git.elc\n+ELC = git.elc vc-git.elc git-blame.elc\n INSTALL ?= install\n INSTALL_ELC = $(INSTALL) -m 644\n prefix ?= $(HOME)\n@@ -15,6 +15,6 @@ install: all\n \t$(INSTALL_ELC) $(ELC) $(emacsdir)\n \n %.elc: %.el\n-\t$(EMACS) --batch --eval '(byte-compile-file \"$<\")'\n+\t$(EMACS) -batch -f batch-byte-compile $<\n \n clean:; rm -f $(ELC)\n-- \n1.5.0\n"},{"id":"36213","messageId":"7vps7q7z44.fsf@assigned-by-dhcp.cox.net","threadId":"7058","inReplyTo":"15313.1172917217@localhost","subject":"Re: [PATCH 6/7] Small changes","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-03T22:15:23Z","receivedAt":"2007-03-03T22:15:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Xavier Maillard writes:\n\n> * Makefile: add git-blame as a candidate to the\n> byte-compilation. Change the function to call to byte-compile.\n\nCould we have a bit more detailed description on the latter\nchange?\n\nExplaining why something needed a change is the point of a\ncommit log message. Summarizing what got changed and how is\ngood but that is secondary, because anybody can see that you\nchanged the handcrafted --eval to -f by running \"git show\", even\nif you did not have the above proposed log message.\n\nWhat is left unsaid is _why_ it is better to use single dash\nform of \"-batch\" and -f form instead of handcrafted --eval, and\nthe proposed log message does not clarify the reason.\n\n> %.elc: %.el\n> -\t$(EMACS) --batch --eval '(byte-compile-file \"$<\")'\n> +\t$(EMACS) -batch -f batch-byte-compile $<\n> \n> clean:; rm -f $(ELC)\n"},{"id":"36287","messageId":"200703050752.l257qRog007776@localhost.localdomain","threadId":"7058","inReplyTo":"7vps7q7z44.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 6/7] Small changes","fromName":"Xavier Maillard","fromEmail":"zedek@gnu.org","sentAt":"2007-03-05T07:52:27Z","receivedAt":"2007-03-05T07:52:27Z","isPatch":true,"sender":{"key":"zedek@gnu.org","avatar":null},"body":"\n From: Junio C Hamano \n\n Xavier Maillard writes:\n\n > * Makefile: add git-blame as a candidate to the\n > byte-compilation. Change the function to call to byte-compile.\n\n Could we have a bit more detailed description on the latter\n change?\n\nSure.\n\nbyte-compile-file is an interactive function.\nbatch--byte-compile is a batch function.\n\nFirst function would be (better) called when using emacs in its\n\"interactive\" form -ie. M-x byte-compile-file RET.\n\nbatch-byte-compile is reserved for batching use (no interaction\nwith the user).\n\nSo in non interactive mode, this is prefered way to do things.\n\n Explaining why something needed a change is the point of a\n commit log message. Summarizing what got changed and how is\n good but that is secondary, because anybody can see that you\n changed the handcrafted --eval to -f by running \"git show\", even\n if you did not have the above proposed log message.\n\nSorry Iam not \"good\" at commit log :/ \n\n What is left unsaid is _why_ it is better to use single dash\n form of \"-batch\" and -f form instead of handcrafted --eval, and\n the proposed log message does not clarify the reason.\n\nFirst reason is given by C-h f batch-byte-compile RET which\ngives:\n\nbatch-byte-compile is an autoloaded Lisp function in `bytecomp'.\n(batch-byte-compile &optional noforce)\n\nRun `byte-compile-file' on the files remaining on the command line.\nUse this from the command line, with `-batch';\nit won't work in an interactive Emacs.\nEach file is processed even if an error occurred previously.\nFor example, invoke \"emacs -batch -f batch-byte-compile $emacs/ ~/*.el\".\nIf noforce is non-nil, don't recompile a file that seems to be\n\nSecond reason is \"by habit\" :)\n\n\nHope Ihave been clear. If you want me to submit something again\nfrom these patches, please tell how to do so (and modify what\nIhave changed).\n\n-- \nXavier\n"},{"id":"36303","messageId":"7v8xec13ig.fsf@assigned-by-dhcp.cox.net","threadId":"7058","inReplyTo":"200703050752.l257qRog007776@localhost.localdomain","subject":"Re: [PATCH 6/7] Small changes","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-05T08:46:47Z","receivedAt":"2007-03-05T08:46:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Xavier Maillard writes:\n\n> From: Junio C Hamano \n>\n> Xavier Maillard writes:\n>\n> > * Makefile: add git-blame as a candidate to the\n> > byte-compilation. Change the function to call to byte-compile.\n>\n> Could we have a bit more detailed description on the latter\n> change?\n>\n> Sure.\n> ...\n> Hope Ihave been clear.\n\nThanks. Received your other message and will apply.\n"}]}