{"thread":{"id":"7044","subject":"[PATCH] Automatically add GIT as a VC backend","startedAt":"2007-03-01T23:52:58Z","lastAt":"2007-03-03T09:31:58Z","messageCount":3,"participants":["Xavier Maillard","Alexandre Julliard"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"36032","messageId":"28587.1172793178@localhost","threadId":"7044","inReplyTo":null,"subject":"[PATCH] Automatically add GIT as a VC backend","fromName":"Xavier Maillard","fromEmail":"zedek@gnu.org","sentAt":"2007-03-01T23:52:58Z","receivedAt":"2007-03-01T23:52:58Z","isPatch":true,"sender":{"key":"zedek@gnu.org","avatar":null},"body":"Hi,\n\nA small patch with following changes:\n\nAutomatically add GIT as a VC backend\n\nRemove byte-compiler warning with an eval of vc\n---\n contrib/emacs/vc-git.el |   13 +++++++------\n 1 files changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/contrib/emacs/vc-git.el b/contrib/emacs/vc-git.el\nindex e456ab9..a2d3932 100644\n--- a/contrib/emacs/vc-git.el\n+++ b/contrib/emacs/vc-git.el\n@@ -22,18 +22,19 @@\n ;; This file contains a VC backend for the git version control\n ;; system.\n ;;\n-;; To install: put this file on the load-path and add GIT to the list\n-;; of supported backends in `vc-handled-backends'; the following line,\n-;; placed in your ~/.emacs, will accomplish this:\n-;;\n-;;     (add-to-list 'vc-handled-backends 'GIT)\n+;; To install: put this file on the load-path.\n ;;\n ;; TODO\n ;;  - changelog generation\n ;;  - working with revisions other than HEAD\n ;;\n \n-(eval-when-compile (require 'cl))\n+(eval-when-compile \n+  (require 'cl)\n+  (require 'vc))\n+\n+;; Add it automatically\n+(add-to-list 'vc-handled-backends 'GIT)\n \n (defvar git-commits-coding-system 'utf-8\n   \"Default coding system for git commits.\")\n-- \nXavier\n"},{"id":"36069","messageId":"87zm6vvqzt.fsf@wine.dyndns.org","threadId":"7044","inReplyTo":"28587.1172793178@localhost","subject":"Re: [PATCH] Automatically add GIT as a VC backend","fromName":"Alexandre Julliard","fromEmail":"julliard@winehq.org","sentAt":"2007-03-02T11:12:22Z","receivedAt":"2007-03-02T11:12:22Z","isPatch":true,"sender":{"key":"julliard@winehq.org","avatar":null},"body":"Xavier Maillard <zedek@gnu.org> writes:\n\n> @@ -22,18 +22,19 @@\n>  ;; This file contains a VC backend for the git version control\n>  ;; system.\n>  ;;\n> -;; To install: put this file on the load-path and add GIT to the list\n> -;; of supported backends in `vc-handled-backends'; the following line,\n> -;; placed in your ~/.emacs, will accomplish this:\n> -;;\n> -;;     (add-to-list 'vc-handled-backends 'GIT)\n> +;; To install: put this file on the load-path.\n\nSimply putting it on the load-path is not enough to make it work,\nyou'd still have to load it explicitly; it's not clear to me that this\nis better than adding it to vc-handled-backends. We can of course\nsupport both approaches, so the rest of your patch is fine, I just\ndon't think the installation instructions should be changed.\n\n-- \nAlexandre Julliard\njulliard@winehq.org\n"},{"id":"36158","messageId":"14819.1172914318@localhost","threadId":"7044","inReplyTo":"87zm6vvqzt.fsf@wine.dyndns.org","subject":"Re: [PATCH] Automatically add GIT as a VC backend","fromName":"Xavier Maillard","fromEmail":"zedek@gnu.org","sentAt":"2007-03-03T09:31:58Z","receivedAt":"2007-03-03T09:31:58Z","isPatch":true,"sender":{"key":"zedek@gnu.org","avatar":null},"body":"Alexandre Julliard <julliard@winehq.org> wrote:\n\n> Xavier Maillard <zedek@gnu.org> writes:\n> \n> > @@ -22,18 +22,19 @@\n> >  ;; This file contains a VC backend for the git version control\n> >  ;; system.\n> >  ;;\n> > -;; To install: put this file on the load-path and add GIT to the list\n> > -;; of supported backends in `vc-handled-backends'; the following line,\n> > -;; placed in your ~/.emacs, will accomplish this:\n> > -;;\n> > -;;     (add-to-list 'vc-handled-backends 'GIT)\n> > +;; To install: put this file on the load-path.\n> \n> Simply putting it on the load-path is not enough to make it work,\n> you'd still have to load it explicitly; it's not clear to me that this\n> is better than adding it to vc-handled-backends. \n\nYou are right.\n\nXavier\n"}]}