{"thread":{"id":"7015","subject":"[PATCH] Show binary file size change in diff --stat","startedAt":"2007-02-28T13:03:11Z","lastAt":"2007-03-01T06:58:00Z","messageCount":13,"participants":["Andy Parkins","Johannes Schindelin","Nicolas Pitre","Rogan Dawes"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"35800","messageId":"200702281303.11951.andyparkins@gmail.com","threadId":"7015","inReplyTo":null,"subject":"[PATCH] Show binary file size change in diff --stat","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-28T13:03:11Z","receivedAt":"2007-02-28T13:03:11Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"Previously, a binary file in the diffstat would show as:\n\n some-binary-file.bin       |  Bin\n\nThe space after the \"Bin\" was never used.  This patch changes binary\nlines in the diffstat to be:\n\n some-binary-file.bin       |  Bin +123456B -12345B\n\nThe \"+\" item is the size of the new version, the \"-\" item is the size of\nthe old version.  If a size is 0 it's not shown (although it would\nprobably be better to treat no-file differently from zero-byte-file).\n\nThe \"B\" (for bytes) is shown to highlight the fact that these numbers\nare not \"number of lines\", but actual bytes.\n\nThe user can see what changed in the binary file, and how big the new\nfile is.  This is in keeping with the information in the rest of the\ndiffstat.\n\nThe diffstat_t members \"added\" and \"deleted\" were unused when the file\nwas binary, so this patch loads them with the file sizes in\nbuiltin_diffstat().  These figures are then read in show_stats() when\nthe file is marked binary.\n\nSigned-off-by: Andy Parkins <andyparkins@gmail.com>\n---\n diff.c |   15 ++++++++++++---\n 1 files changed, 12 insertions(+), 3 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex d1eae72..174b84e 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -808,7 +808,14 @@ static void show_stats(struct diffstat_t* data, struct diff_options *options)\n \n \t\tif (data->files[i]->is_binary) {\n \t\t\tshow_name(prefix, name, len, reset, set);\n-\t\t\tprintf(\"  Bin\\n\");\n+\t\t\tprintf(\"  Bin \");\n+\t\t\tif (added != 0)\n+\t\t\t\tprintf(\"%s+%iB%s\", add_c, added, reset);\n+\t\t\tif (added != 0 && deleted != 0 )\n+\t\t\t\tprintf(\" \");\n+\t\t\tif (deleted != 0)\n+\t\t\t\tprintf(\"%s-%iB%s\", del_c, deleted, reset);\n+\t\t\tprintf(\"\\n\");\n \t\t\tgoto free_diffstat_file;\n \t\t}\n \t\telse if (data->files[i]->is_unmerged) {\n@@ -1179,9 +1186,11 @@ static void builtin_diffstat(const char *name_a, const char *name_b,\n \tif (fill_mmfile(&mf1, one) < 0 || fill_mmfile(&mf2, two) < 0)\n \t\tdie(\"unable to read files to diff\");\n \n-\tif (mmfile_is_binary(&mf1) || mmfile_is_binary(&mf2))\n+\tif (mmfile_is_binary(&mf1) || mmfile_is_binary(&mf2)) {\n \t\tdata->is_binary = 1;\n-\telse {\n+\t\tdata->added = mf2.size;\n+\t\tdata->deleted = mf1.size;\n+\t} else {\n \t\t/* Crazy xdl interfaces.. */\n \t\txpparam_t xpp;\n \t\txdemitconf_t xecfg;\n-- \n1.5.0.2.778.gdcb06\n"},{"id":"35807","messageId":"Pine.LNX.4.63.0702281535070.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7015","inReplyTo":"200702281303.11951.andyparkins@gmail.com","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-02-28T14:44:48Z","receivedAt":"2007-02-28T14:44:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 28 Feb 2007, Andy Parkins wrote:\n\n> Previously, a binary file in the diffstat would show as:\n> \n>  some-binary-file.bin       |  Bin\n> \n> The space after the \"Bin\" was never used.  This patch changes binary\n> lines in the diffstat to be:\n> \n>  some-binary-file.bin       |  Bin +123456B -12345B\n\nThis seemed as a good idea to me at first. But I think it is a little \nmisleading: Imagine for example that you have raw image data (which I \ntrack with Git, too). If only part of that changes, this representation is \nmisleading.\n\nHow about \"Bin 123456 -> 12345 bytes\" instead?\n\nCiao,\nDscho\n"},{"id":"35808","messageId":"alpine.LRH.0.82.0702280951080.29426@xanadu.home","threadId":"7015","inReplyTo":"Pine.LNX.4.63.0702281535070.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2007-02-28T14:51:50Z","receivedAt":"2007-02-28T14:51:50Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Wed, 28 Feb 2007, Johannes Schindelin wrote:\n\n> How about \"Bin 123456 -> 12345 bytes\" instead?\n\nI agree.\n\n\nNicolas\n"},{"id":"35815","messageId":"200702281515.10016.andyparkins@gmail.com","threadId":"7015","inReplyTo":"Pine.LNX.4.63.0702281535070.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"[PATCH] Show binary file size change in diff --stat","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-28T15:15:09Z","receivedAt":"2007-02-28T15:15:09Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"Previously, a binary file in the diffstat would show as:\n\n some-binary-file.bin       |  Bin\n\nThe space after the \"Bin\" was never used.  This patch changes binary\nlines in the diffstat to be:\n\n some-binary-file.bin       |  Bin 123456 -> 12345 bytes\n\nThe very nice \"->\" notation was suggested by Johannes Schindelin, and\nshows the before and after sizes more clearly than \"+\" and \"-\" would.\nIf a size is 0 it's not shown (although it would probably be better to\ntreat no-file differently from zero-byte-file).\n\nThe user can see what changed in the binary file, and how big the new\nfile is.  This is in keeping with the information in the rest of the\ndiffstat.\n\nThe diffstat_t members \"added\" and \"deleted\" were unused when the file\nwas binary, so this patch loads them with the file sizes in\nbuiltin_diffstat().  These figures are then read in show_stats() when\nthe file is marked binary.\n\nSigned-off-by: Andy Parkins <andyparkins@gmail.com>\n---\n\nGood call.\n\nI like it.  \"->\" is much better than \"+\" and \"-\"; they would\nimply that a set of bytes had been removed and another set added to\nreplace them - obviously nonsense.\n\n diff.c |   17 ++++++++++++++---\n 1 files changed, 14 insertions(+), 3 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex d1eae72..ea322e2 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -808,7 +808,16 @@ static void show_stats(struct diffstat_t* data, struct diff_options *options)\n \n \t\tif (data->files[i]->is_binary) {\n \t\t\tshow_name(prefix, name, len, reset, set);\n-\t\t\tprintf(\"  Bin\\n\");\n+\t\t\tprintf(\"  Bin \");\n+\t\t\tif (added != 0)\n+\t\t\t\tprintf(\"%s%i%s\", add_c, added, reset);\n+\t\t\tif (added != 0 && deleted != 0 )\n+\t\t\t\tprintf(\" -> \");\n+\t\t\tif (deleted != 0)\n+\t\t\t\tprintf(\"%s%i%s\", del_c, deleted, reset);\n+\t\t\tif (added != 0 || deleted != 0 )\n+\t\t\t\tprintf(\" bytes\");\n+\t\t\tprintf(\"\\n\");\n \t\t\tgoto free_diffstat_file;\n \t\t}\n \t\telse if (data->files[i]->is_unmerged) {\n@@ -1179,9 +1188,11 @@ static void builtin_diffstat(const char *name_a, const char *name_b,\n \tif (fill_mmfile(&mf1, one) < 0 || fill_mmfile(&mf2, two) < 0)\n \t\tdie(\"unable to read files to diff\");\n \n-\tif (mmfile_is_binary(&mf1) || mmfile_is_binary(&mf2))\n+\tif (mmfile_is_binary(&mf1) || mmfile_is_binary(&mf2)) {\n \t\tdata->is_binary = 1;\n-\telse {\n+\t\tdata->added = mf2.size;\n+\t\tdata->deleted = mf1.size;\n+\t} else {\n \t\t/* Crazy xdl interfaces.. */\n \t\txpparam_t xpp;\n \t\txdemitconf_t xecfg;\n-- \n1.5.0.2.205.gea888-dirty\n"},{"id":"35817","messageId":"200702281526.26247.andyparkins@gmail.com","threadId":"7015","inReplyTo":"Pine.LNX.4.63.0702281535070.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"[PATCH] Show binary file size change in diff --stat","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-28T15:26:26Z","receivedAt":"2007-02-28T15:26:26Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"Previously, a binary file in the diffstat would show as:\n\n some-binary-file.bin       |  Bin\n\nThe space after the \"Bin\" was never used.  This patch changes binary\nlines in the diffstat to be:\n\n some-binary-file.bin       |  Bin 12345 -> 123456 bytes\n\nThe very nice \"->\" notation was suggested by Johannes Schindelin, and\nshows the before and after sizes more clearly than \"+\" and \"-\" would.\n\nThe user can see what changed in the binary file, and how big the new\nfile is.  This is in keeping with the information in the rest of the\ndiffstat.\n\nThe diffstat_t members \"added\" and \"deleted\" were unused when the file\nwas binary, so this patch loads them with the file sizes in\nbuiltin_diffstat().  These figures are then read in show_stats() when\nthe file is marked binary.\n\nSigned-off-by: Andy Parkins <andyparkins@gmail.com>\n---\n\nGAHHH!!!\n\nIgnore previous; I forgot to swap the order of the added and deleted items.\nI've also removed the conditionals on the 0 byte sizes - they're always shown.\n\n\n diff.c |   13 ++++++++++---\n 1 files changed, 10 insertions(+), 3 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex d1eae72..cfddbb4 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -808,7 +808,12 @@ static void show_stats(struct diffstat_t* data, struct diff_options *options)\n \n \t\tif (data->files[i]->is_binary) {\n \t\t\tshow_name(prefix, name, len, reset, set);\n-\t\t\tprintf(\"  Bin\\n\");\n+\t\t\tprintf(\"  Bin \");\n+\t\t\tprintf(\"%s%i%s\", del_c, deleted, reset);\n+\t\t\tprintf(\" -> \");\n+\t\t\tprintf(\"%s%i%s\", add_c, added, reset);\n+\t\t\tprintf(\" bytes\");\n+\t\t\tprintf(\"\\n\");\n \t\t\tgoto free_diffstat_file;\n \t\t}\n \t\telse if (data->files[i]->is_unmerged) {\n@@ -1179,9 +1184,11 @@ static void builtin_diffstat(const char *name_a, const char *name_b,\n \tif (fill_mmfile(&mf1, one) < 0 || fill_mmfile(&mf2, two) < 0)\n \t\tdie(\"unable to read files to diff\");\n \n-\tif (mmfile_is_binary(&mf1) || mmfile_is_binary(&mf2))\n+\tif (mmfile_is_binary(&mf1) || mmfile_is_binary(&mf2)) {\n \t\tdata->is_binary = 1;\n-\telse {\n+\t\tdata->added = mf2.size;\n+\t\tdata->deleted = mf1.size;\n+\t} else {\n \t\t/* Crazy xdl interfaces.. */\n \t\txpparam_t xpp;\n \t\txdemitconf_t xecfg;\n-- \n1.5.0.2.205.gea888-dirty\n"},{"id":"35822","messageId":"Pine.LNX.4.63.0702281630430.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7015","inReplyTo":"200702281515.10016.andyparkins@gmail.com","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-02-28T15:37:01Z","receivedAt":"2007-02-28T15:37:01Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 28 Feb 2007, Andy Parkins wrote:\n\n> +\t\t\t\tprintf(\"%s%i%s\", add_c, added, reset);\n\nPlease use \"%d\" instead of \"%i\" (I forgot why, but I remember Junio saying \nthat we should do it...).\n\n> +\t\t\tif (added != 0 && deleted != 0 )\n> +\t\t\t\tprintf(\" -> \");\n\nEither you want to have\n\n\tBin +123456 bytes\n\nor\n\n\tBin 0 -> 123456 bytes\n\nfor added files (and the obvious thing for deleted ones), but with your \npatch, both added and deleted get\n\n\tBin 123456 bytes\n\nwhich is not so optimal.\n\nCiao,\nDscho\n"},{"id":"35867","messageId":"200702281842.15147.andyparkins@gmail.com","threadId":"7015","inReplyTo":"Pine.LNX.4.63.0702281630430.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-28T18:42:13Z","receivedAt":"2007-02-28T18:42:13Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Wednesday 2007, February 28, Johannes Schindelin wrote:\n\n> for added files (and the obvious thing for deleted ones), but with\n> your patch, both added and deleted get\n>\n> \tBin 123456 bytes\n>\n> which is not so optimal.\n\nSee my corrected patch.  However, while you're interested: how would one \ntell the difference between 0 bytes and (no file).  I'm thinking of \nthese possibilities:\n\n new -> 123456\n 0 -> 123456\n 123456 -> deleted\n 123456 -> 0\n\nFor example - does mmfile_t.ptr set to NULL mean anything?\n\n\n\nAndy\n-- \nDr Andy Parkins, M Eng (hons), MIET\nandyparkins@gmail.com\n"},{"id":"35869","messageId":"45E5D0D7.5070305@dawes.za.net","threadId":"7015","inReplyTo":"200702281303.11951.andyparkins@gmail.com","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Rogan Dawes","fromEmail":"discard@dawes.za.net","sentAt":"2007-02-28T18:58:31Z","receivedAt":"2007-02-28T18:58:31Z","isPatch":true,"sender":{"key":"discard@dawes.za.net","avatar":null},"body":"Andy Parkins wrote:\n> Previously, a binary file in the diffstat would show as:\n> \n>  some-binary-file.bin       |  Bin\n> \n> The space after the \"Bin\" was never used.  This patch changes binary\n> lines in the diffstat to be:\n> \n>  some-binary-file.bin       |  Bin +123456B -12345B\n> \n> The \"+\" item is the size of the new version, the \"-\" item is the size of\n> the old version.  If a size is 0 it's not shown (although it would\n> probably be better to treat no-file differently from zero-byte-file).\n> \n> The \"B\" (for bytes) is shown to highlight the fact that these numbers\n> are not \"number of lines\", but actual bytes.\n> \n> The user can see what changed in the binary file, and how big the new\n> file is.  This is in keeping with the information in the rest of the\n> diffstat.\n> \n> The diffstat_t members \"added\" and \"deleted\" were unused when the file\n> was binary, so this patch loads them with the file sizes in\n> builtin_diffstat().  These figures are then read in show_stats() when\n> the file is marked binary.\n\nHow about showing the size of the changes between the 2 files via the \nlibxdiff binary patch function?\n\nIt would probably not be that difficult to generate a binary patch, and \nthen derive some stats from it.\n\nRogan\n"},{"id":"35877","messageId":"Pine.LNX.4.63.0702282040430.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7015","inReplyTo":"200702281842.15147.andyparkins@gmail.com","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-02-28T19:41:29Z","receivedAt":"2007-02-28T19:41:29Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 28 Feb 2007, Andy Parkins wrote:\n\n> On Wednesday 2007, February 28, Johannes Schindelin wrote:\n> \n> > for added files (and the obvious thing for deleted ones), but with\n> > your patch, both added and deleted get\n> >\n> > \tBin 123456 bytes\n> >\n> > which is not so optimal.\n> \n> See my corrected patch.  However, while you're interested: how would one \n> tell the difference between 0 bytes and (no file).  I'm thinking of \n> these possibilities:\n> \n>  new -> 123456\n>  0 -> 123456\n>  123456 -> deleted\n>  123456 -> 0\n> \n> For example - does mmfile_t.ptr set to NULL mean anything?\n\nIn non-binary case, we have only plusses or minusses, so you cannot tell \neither. You have to look into the summary for that.\n\nCiao,\nDscho\n"},{"id":"35878","messageId":"Pine.LNX.4.63.0702282042000.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7015","inReplyTo":"45E5D0D7.5070305@dawes.za.net","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-02-28T19:42:41Z","receivedAt":"2007-02-28T19:42:41Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 28 Feb 2007, Rogan Dawes wrote:\n\n> How about showing the size of the changes between the 2 files via the \n> libxdiff binary patch function?\n\nI briefly considered this, too. But what would it tell you in the case of \na jpg? I think it has more disadvantages than advantages...\n\nCiao,\nDscho\n"},{"id":"35887","messageId":"45E5F3D4.8000509@dawes.za.net","threadId":"7015","inReplyTo":"Pine.LNX.4.63.0702282042000.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Rogan Dawes","fromEmail":"discard@dawes.za.net","sentAt":"2007-02-28T21:27:48Z","receivedAt":"2007-02-28T21:27:48Z","isPatch":true,"sender":{"key":"discard@dawes.za.net","avatar":null},"body":"Johannes Schindelin wrote:\n> Hi,\n> \n> On Wed, 28 Feb 2007, Rogan Dawes wrote:\n> \n>> How about showing the size of the changes between the 2 files via the \n>> libxdiff binary patch function?\n> \n> I briefly considered this, too. But what would it tell you in the case of \n> a jpg? I think it has more disadvantages than advantages...\n> \n> Ciao,\n> Dscho\n\nIt would still tell you the extent of the changes. i.e. Did we change \nonly 10 bytes of the file, or is it a dramatic change?\n\nThis is exactly what the text statistics show. +(new lines + modified \nlines) -(deleted lines + modified lines)\n\nInstead of having a \"line-based\" record size, simply use individual \nbytes, since binary files don't have lines (most of them, anyway!).\n\nRogan\n"},{"id":"35906","messageId":"Pine.LNX.4.63.0703010208070.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"7015","inReplyTo":"45E5F3D4.8000509@dawes.za.net","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-03-01T01:09:56Z","receivedAt":"2007-03-01T01:09:56Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 28 Feb 2007, Rogan Dawes wrote:\n\n> Johannes Schindelin wrote:\n> \n> > On Wed, 28 Feb 2007, Rogan Dawes wrote:\n> > \n> > > How about showing the size of the changes between the 2 files via \n> > > the libxdiff binary patch function?\n> > \n> > I briefly considered this, too. But what would it tell you in the case \n> > of a jpg? I think it has more disadvantages than advantages...\n> \n> It would still tell you the extent of the changes. i.e. Did we change \n> only 10 bytes of the file, or is it a dramatic change?\n\nI was not explicit enough, okay. I was not so worried about the case where \nonly 10 bytes changed. If you insert a single dot in a jpg image, chances \nare that your binary content will change _a lot_.\n\nSo, no problem deducing from 10 bytes changed that it was a minor change. \nBut you cannot deduce the opposite of a 1MB change!\n\nHth,\nDscho\n"},{"id":"35919","messageId":"45E67978.9030805@dawes.za.net","threadId":"7015","inReplyTo":"Pine.LNX.4.63.0703010208070.22628@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Show binary file size change in diff --stat","fromName":"Rogan Dawes","fromEmail":"discard@dawes.za.net","sentAt":"2007-03-01T06:58:00Z","receivedAt":"2007-03-01T06:58:00Z","isPatch":true,"sender":{"key":"discard@dawes.za.net","avatar":null},"body":"Johannes Schindelin wrote:\n> Hi,\n> \n> On Wed, 28 Feb 2007, Rogan Dawes wrote:\n> \n>> Johannes Schindelin wrote:\n>>\n>>> On Wed, 28 Feb 2007, Rogan Dawes wrote:\n>>>\n>>>> How about showing the size of the changes between the 2 files via \n>>>> the libxdiff binary patch function?\n>>> I briefly considered this, too. But what would it tell you in the case \n>>> of a jpg? I think it has more disadvantages than advantages...\n>> It would still tell you the extent of the changes. i.e. Did we change \n>> only 10 bytes of the file, or is it a dramatic change?\n> \n> I was not explicit enough, okay. I was not so worried about the case where \n> only 10 bytes changed. If you insert a single dot in a jpg image, chances \n> are that your binary content will change _a lot_.\n> \n> So, no problem deducing from 10 bytes changed that it was a minor change. \n> But you cannot deduce the opposite of a 1MB change!\n> \n> Hth,\n> Dscho\n> \n\nYeah, I did understand that.\n\nHowever, if we were to generalise, making a change to an XML document \n(wrapping the whole thing in an additional tag, with the associated \nindentation adjustments), we'd still see all the lines in the file \nchange, even though the actual (semantic?) change is small. However, we \nwould still report the full numbers of lines added and deleted regardless.\n\nWhy should a binary file be any different? It would be up to the \nobserver to make a conclusion as to the significance of the numbers, \nbased on their intrinsic knowledge of the file type, and its properties.\n\nI just believe that showing bytes changed for binary files is \n_consistent_ with what we do for text.\n\nRogan\n"}]}