{"thread":{"id":"7014","subject":"[PATCH] git-cvsexportcommit: don't cleanup .msg if not yet committed to cvs.","startedAt":"2007-02-28T12:35:39Z","lastAt":"2007-03-01T01:29:38Z","messageCount":3,"participants":["Gerrit Pape","Simon 'corecode' Schubert","Martin Langhoff"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"35797","messageId":"20070228123539.23809.qmail@d6daeb0e3466c1.315fe32.mid.smarden.org","threadId":"7014","inReplyTo":"20070227181721.GA4244@bogon.ms20.nix","subject":"[PATCH] git-cvsexportcommit: don't cleanup .msg if not yet committed to cvs.","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2007-02-28T12:35:39Z","receivedAt":"2007-02-28T12:35:39Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"Unless the -c option is given, and the commit to cvs was successful,\n.msg shouldn't be deleted to be able to run the command suggested by\ngit-cvsexportcommit.\n\nSee http://bugs.debian.org/412732\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n git-cvsexportcommit.perl |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl\nindex d08216c..67224b4 100755\n--- a/git-cvsexportcommit.perl\n+++ b/git-cvsexportcommit.perl\n@@ -248,13 +248,14 @@ if ($opt_c) {\n \tdie \"Exiting: The commit did not succeed\";\n     }\n     print \"Committed successfully to CVS\\n\";\n+    # clean up\n+    unlink(\".msg\");\n } else {\n     print \"Ready for you to commit, just run:\\n\\n   $cmd\\n\";\n }\n \n # clean up\n unlink(\".cvsexportcommit.diff\");\n-unlink(\".msg\");\n \n sub usage {\n \tprint STDERR <<END;\n-- \n1.5.0.1\n"},{"id":"35907","messageId":"45E629B1.2050805@fs.ei.tum.de","threadId":"7014","inReplyTo":"20070228123539.23809.qmail@d6daeb0e3466c1.315fe32.mid.smarden.org","subject":"Re: [PATCH] git-cvsexportcommit: don't cleanup .msg if not yet committed to cvs.","fromName":"Simon 'corecode' Schubert","fromEmail":"corecode@fs.ei.tum.de","sentAt":"2007-03-01T01:17:37Z","receivedAt":"2007-03-01T01:17:37Z","isPatch":true,"sender":{"key":"corecode@fs.ei.tum.de","avatar":"https://gravatar.com/avatar/eff9dbf0cdac0d1e6a6cd7ed0e50763edcb376b493b5253a35ff167918ad79e1?d=mp&s=160"},"body":"Gerrit Pape wrote:\n> Unless the -c option is given, and the commit to cvs was successful,\n> .msg shouldn't be deleted to be able to run the command suggested by\n> git-cvsexportcommit.\n\nthanks, i've been meaning to search for the cause of this.\n\ncheers\n  simon\n\n-- \nServe - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /\"\\\nWork - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \\ /\nParty Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \\\nDude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \\\n\n"},{"id":"35910","messageId":"46a038f90702281729r71fd8241t554a3a281d211ecb@mail.gmail.com","threadId":"7014","inReplyTo":"20070228123539.23809.qmail@d6daeb0e3466c1.315fe32.mid.smarden.org","subject":"Re: [PATCH] git-cvsexportcommit: don't cleanup .msg if not yet committed to cvs.","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2007-03-01T01:29:38Z","receivedAt":"2007-03-01T01:29:38Z","isPatch":true,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"Ack. I though I had sent this same fix about a month ago as\n\n\"cvsexportcommit: do not delete .msg when performing manual commits\"\n461cc1944cf17210149c20bafa7dbbc467b2e89f\n\nbut it looks like I didn't. Shame on me.\n\n\n\nmartin\n"}]}