{"thread":{"id":"6895","subject":"[PATCH] disable t4016-diff-quote.sh on some filesystems","startedAt":"2007-02-20T09:27:40Z","lastAt":"2007-02-20T19:47:07Z","messageCount":2,"participants":["Alex Riesen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"35096","messageId":"81b0412b0702200127m231425d6p67d2d67e6d7d9b04@mail.gmail.com","threadId":"6895","inReplyTo":null,"subject":"[PATCH] disable t4016-diff-quote.sh on some filesystems","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-02-20T09:27:40Z","receivedAt":"2007-02-20T09:27:40Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"because the filesystems (most typically FAT and NTFS) do not support\nHT nor LF in filenames.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n\n---\nGod help me...\n\n  t/t4016-diff-quote.sh |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\n\nFrom 0edbc6df977e7d954032eaf72720c93b86ab4c0f Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Tue, 20 Feb 2007 10:04:32 +0100\nSubject: [PATCH] disable t4016-diff-quote.sh on some filesystems\n\n---\n t/t4016-diff-quote.sh |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t4016-diff-quote.sh b/t/t4016-diff-quote.sh\nindex edde8f5..8e9422c 100755\n--- a/t/t4016-diff-quote.sh\n+++ b/t/t4016-diff-quote.sh\n@@ -13,6 +13,10 @@ P1='pathname\twith HT'\n P2='pathname with SP'\n P3='pathname\n with LF'\n+if ! test : 2>/dev/null >\"$P1\" ; then\n+\techo >&2 'Filesystem does not support tabs in names'\n+\ttest_done\n+fi\n \n test_expect_success setup '\n \techo P0.0 >\"$P0.0\" &&\n-- \n1.5.0.rc4.84.g67fc1\n\n"},{"id":"35136","messageId":"7vk5ycvcg4.fsf@assigned-by-dhcp.cox.net","threadId":"6895","inReplyTo":"81b0412b0702200127m231425d6p67d2d67e6d7d9b04@mail.gmail.com","subject":"Re: [PATCH] disable t4016-diff-quote.sh on some filesystems","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-02-20T19:47:07Z","receivedAt":"2007-02-20T19:47:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Alex Riesen\" <raa.lkml@gmail.com> writes:\n\n> because the filesystems (most typically FAT and NTFS) do not support\n> HT nor LF in filenames.\n>\n> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n>\n> ---\n> God help me...\n> \n>  t/t4016-diff-quote.sh |    4 ++++\n> 1 files changed, 4 insertions(+), 0 deletions(-)\n\nBuddha help me.\n\nYou are still lacking the \"good stuff\" in what I'd end up saving\nin a separate file and applying, which is the attachment part...\n\n> From 0edbc6df977e7d954032eaf72720c93b86ab4c0f Mon Sep 17 00:00:00 2001\n> From: Alex Riesen <raa.lkml@gmail.com>\n> Date: Tue, 20 Feb 2007 10:04:32 +0100\n> Subject: [PATCH] disable t4016-diff-quote.sh on some filesystems\n>\n> ---\n>  t/t4016-diff-quote.sh |    4 ++++\n>  1 files changed, 4 insertions(+), 0 deletions(-)\n\n... but that is a minor detail.  I can survive.\n\n> +if ! test : 2>/dev/null >\"$P1\" ; then\n> +\techo >&2 'Filesystem does not support tabs in names'\n> +\ttest_done\n> +fi\n\nI do not understand what this test-colon is doing?  Did you mean\n\n\tif ! : >\"$P1\" 2>&1\n        then\n\t\t...\n\tfi\n\nI would have written it like this, to check if it really\nsucceeded creating and also we can remove it.\n\n\t: >\"$P1\" 2>&1 && test -f \"$P1\" && rm -f \"$P1\" || {\n\t\t...\n\t}\n"}]}