{"thread":{"id":"6864","subject":"Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message","startedAt":"2007-02-17T22:02:24Z","lastAt":"2007-02-23T10:02:56Z","messageCount":5,"participants":["Andy Parkins","Marco Costalba"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"34897","messageId":"200702172202.25730.andyparkins@gmail.com","threadId":"6864","inReplyTo":"200702172200.13461.andyparkins@gmail.com","subject":"Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-17T22:02:24Z","receivedAt":"2007-02-17T22:02:24Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Saturday 2007, February 17, Andy Parkins wrote:\n> Signed-off-by: Andy Parkins \n> ---\n> Hey Marco; I've finally got around to rebasing. The problem I had\n> was an error in my .git/config was making git-fetch just return\n> without fetching so I wasn't getting your new master head.\n\nApologies all: this and following patches should have been marked qgit4; \nnot mainline git.\n\nAndy\n-- \nDr Andrew Parkins, M Eng (Hons), AMIEE\nandyparkins@gmail.com\n"},{"id":"34940","messageId":"e5bfff550702172325w32f980b3x58b05face97ec7d2@mail.gmail.com","threadId":"6864","inReplyTo":"200702172202.25730.andyparkins@gmail.com","subject":"Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2007-02-18T07:25:14Z","receivedAt":"2007-02-18T07:25:14Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 2/17/07, Andy Parkins wrote:\n> On Saturday 2007, February 17, Andy Parkins wrote:\n> > Signed-off-by: Andy Parkins \n> > ---\n> > Hey Marco; I've finally got around to rebasing. The problem I had\n> > was an error in my .git/config was making git-fetch just return\n> > without fetching so I wasn't getting your new master head.\n>\n> Apologies all: this and following patches should have been marked qgit4;\n> not mainline git.\n>\n\nHi Andy,\n\nthanks for your patches, but I can see only this email and the '[PATCH\n2/3] Improve default column widths by changing resize modes', I miss\nbody of [PATCH 1/3] and [PATCH 3/3].\n\nPlease take a look at http://marc.theaimsgroup.com/?l=git&r=1&b=200702&w=2\nto see what's landed on git list.\n\nMarco\n\nP.S: I will be on travel next week, so I won't be able to connect regularly.\n"},{"id":"34951","messageId":"200702181044.53115.andyparkins@gmail.com","threadId":"6864","inReplyTo":"e5bfff550702172325w32f980b3x58b05face97ec7d2@mail.gmail.com","subject":"Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-18T10:44:49Z","receivedAt":"2007-02-18T10:44:49Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Sunday 2007, February 18, Marco Costalba wrote:\n\n> thanks for your patches, but I can see only this email and the\n> '[PATCH 2/3] Improve default column widths by changing resize modes',\n> I miss body of [PATCH 1/3] and [PATCH 3/3].\n\nI think that the mailing list spam filter is objecting because the email \ncontains HTML tags. I'll send the patches to you directly to bypass \nthe spam filter.\n\n\nAndy\n-- \nDr Andrew Parkins, M Eng (Hons), AMIEE\nandyparkins@gmail.com\n"},{"id":"35301","messageId":"e5bfff550702230003o5a24a422h7c52a544318da1d4@mail.gmail.com","threadId":"6864","inReplyTo":"200702181044.53115.andyparkins@gmail.com","subject":"Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2007-02-23T08:03:10Z","receivedAt":"2007-02-23T08:03:10Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On 2/18/07, Andy Parkins wrote:\n> On Sunday 2007, February 18, Marco Costalba wrote:\n>\n> > thanks for your patches, but I can see only this email and the\n> > '[PATCH 2/3] Improve default column widths by changing resize modes',\n> > I miss body of [PATCH 1/3] and [PATCH 3/3].\n>\n> I think that the mailing list spam filter is objecting because the email\n> contains HTML tags. I'll send the patches to you directly to bypass\n> the spam filter.\n>\n>\n\nHi Andy,\n\n I finally apply and pushed your patches to\ngit://repo.or.cz/qgit4.git, I have to say I really like your fancy\nhtml log message.\n\nJust a couple of notes:\n\n- Font family is set to TYPE_WRITER_FONT, but font size is not taken\ninto account and seems fixed.\n\n- There are some alignement issues in the header, sometimes author,\ndate, etc.. are left shifted without a clear reason wasting valuable\nscreen space.\n\nHere are some snapshots to better clarify the points.\n\nhttp://digilander.libero.it/mcostalba/andy1.png\nhttp://digilander.libero.it/mcostalba/andy2.png\nhttp://digilander.libero.it/mcostalba/andy3.png\n\nAnyway a nice job.\n\nThanks\nMarco\n"},{"id":"35315","messageId":"200702231003.03361.andyparkins@gmail.com","threadId":"6864","inReplyTo":"e5bfff550702230003o5a24a422h7c52a544318da1d4@mail.gmail.com","subject":"Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2007-02-23T10:02:56Z","receivedAt":"2007-02-23T10:02:56Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Friday 2007 February 23 08:03, Marco Costalba wrote:\n> I finally apply and pushed your patches to\n> git://repo.or.cz/qgit4.git, I have to say I really like your fancy\n> html log message.\n\n:-) I'm glad you like it. I was trying to make it look a bit like the email \nheader in kmail. I'm a bit disappointed with it aesthetically, but I do find \nit makes it a lot easier to view the separate log components without much \nbrain power.\n\n> - Font family is set to TYPE_WRITER_FONT, but font size is not taken\n> into account and seems fixed.\n\nAh yes - probably a one-liner to fix. I'll patch soon.\n\n> - There are some alignement issues in the header, sometimes author,\n> date, etc.. are left shifted without a clear reason wasting valuable\n> screen space.\n\nYes you are certainly correct. I'm going to point at Qt for the blame. I \nhave no idea why it's adding that space. It goes away when the rowspan is \nremoved from the short log part. Additionally, Qt (despite the \ndocumentation) seems to ignore width=100% to table or divs, so I can't make \nthe header actually look as nice as it could.\n\nOnce I figure out how to make it look better I'll certainly post patches, but \nat the moment it's a fight between me and Qt :-) The solution, is going to \nbe a compromise I think. I might have to make the short log non-centered and \nnon-rowspanning :-(\n\n> Anyway a nice job.\n\nThanks.\n\n\n\nAndy\n\n-- \nDr Andy Parkins, M Eng (hons), MIET\nandyparkins@gmail.com\n"}]}