{"thread":{"id":"6848","subject":"Full disk behavior of git","startedAt":"2007-02-16T16:33:49Z","lastAt":"2007-02-17T06:31:31Z","messageCount":2,"participants":["Bill Lear","Shawn O. Pearce"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"34808","messageId":"17877.56557.546383.815806@lisa.zopyra.com","threadId":"6848","inReplyTo":null,"subject":"Full disk behavior of git","fromName":"Bill Lear","fromEmail":"rael@zopyra.com","sentAt":"2007-02-16T16:33:49Z","receivedAt":"2007-02-16T16:33:49Z","isPatch":false,"sender":{"key":"rael@zopyra.com","avatar":"https://gravatar.com/avatar/c4f2d2790ca3828d3b4e7dfebabf61d2fe94fd82fa49cdac2a5295dd2d46a874?d=mp&s=160"},"body":"I wanted to report an error we belatedly uncovered while using 1.4.4.1\nto pull into a repo on a disk that filled up.  We run a nightly script\nto build our code base and we did not notice these errors in the build\nuntil a few days later.\n\nThe build scripts continued to run each evening after this write\nfailure happened, and a subsequent pull showed this:\n\n% git pull\nremote: Generating pack...\nremote: Done counting 369 objects.\nremote: Result has 246 objects.\nremote: Deltifying 246 objects.\n[...]\nremote: Total 246, written 246 (delta 150), reused 190 (delta 95)\nerror: Could not read 828c0a0649d2d6b43ed13853bba33f7764f034fa\n* refs/heads/origin: fast forward to branch 'master' of\nssh+git://source/repos/git/fus\n   old..new: ebeb03b..b7e8cd6\nerror: Could not read 828c0a0649d2d6b43ed13853bba33f7764f034fa\nUpdating ebeb03b..b7e8cd6\nFast forward\n  src/cp/tu.cc                                 |    3 +-\n  src/cp/tu.flw.cc                             |   81 +-\n  src/cp/tu.plt.cc                             |    3 +-\n[...]\n\nand the pull seemed to complete ok.\n\nWe checked the repo:\n\n% git-fsck-objects --full\nerror: 08b4bc0910b3e945312e3d0ed3aea77287b61ebf: object not found\nerror: 828c0a0649d2d6b43ed13853bba33f7764f034fa: object not found\nerror: 93edcb9bcaacb3e7caddbcc4188dd5b96ee5c8b2: object not found\nerror: ecf4705ae985133dabdc207d81bd2d9c5a4f1402: object not found\ndangling commit a7ccd43df37e8c2551358bc32e7341be6a21cb16\ndangling tree 2f54a7d7980dac6bb6c4f54e54793e24ef0ac892\ndangling tree 9a35dfe6020c361e3fe15bddd2c80d7cbcd665fe\ndangling tree 0056712d4f15f5bce79743512ec30d8360789a71\ndangling tree 899b33309b5a5530e331841eb82d64882b577181\n\nI'm obviously unsure as to what exactly happened, but I did want to\npoint this out in case git should be cleaning up these objects on a\nfailed pull --- not that I think it necessarily should, but I did want\nto take this as an opportunity to share what is probably a rare\nfailure scenario and let others ponder.\n\nAs a final point, our \"build master\" now informs me that he has\nbeen trapping error status from git pull, e.g.:\n\n  git pull || { echo \"pull failed\"; exit 1; }\n\nhowever, it appears that the pull read errors above are not resulting\nin an error status being returned.\n\n\nBill\n"},{"id":"34849","messageId":"20070217063130.GC27864@spearce.org","threadId":"6848","inReplyTo":"17877.56557.546383.815806@lisa.zopyra.com","subject":"Re: Full disk behavior of git","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-02-17T06:31:31Z","receivedAt":"2007-02-17T06:31:31Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Bill Lear <rael@zopyra.com> wrote:\n> As a final point, our \"build master\" now informs me that he has\n> been trapping error status from git pull, e.g.:\n> \n>   git pull || { echo \"pull failed\"; exit 1; }\n> \n> however, it appears that the pull read errors above are not resulting\n> in an error status being returned.\n\nThis was a bug in the 1.4.4.x series.  It has been fixed in 1.5.0.\nUpgrade.  :-)\n\n-- \nShawn.\n"}]}