{"thread":{"id":"6841","subject":"[PATCH] git-blame: prevent argument parsing segfault","startedAt":"2007-02-16T07:38:21Z","lastAt":"2007-02-16T08:23:37Z","messageCount":2,"participants":["Tommi Kyntola","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"34780","messageId":"45D55F6D.5090900@ray.fi","threadId":"6841","inReplyTo":null,"subject":"[PATCH] git-blame: prevent argument parsing segfault","fromName":"Tommi Kyntola","fromEmail":"tommi.kyntola@ray.fi","sentAt":"2007-02-16T07:38:21Z","receivedAt":"2007-02-16T07:38:21Z","isPatch":true,"sender":{"key":"tommi.kyntola@ray.fi","avatar":null},"body":"\nDescription:\nk@samael /localhome/k/git.git/git/gitweb % git-blame --incremental\nzsh: segmentation fault  git blame --incremental\n\nThe 3rd branch in builtin-blame.c should also check for lacking\narguments. Running that in top dir avoids the problem because\nthe 'prefix' is NULL. The --incremental is no to blame here,\nit only triggers the segfault and even without that flag it goes\nchecking argv too far.\n\nI didn't check the pu branch, and I'm sorry if this is a dupe.\n\ncheers,\nTommi \"Kynde\" Kyntola\n\ndiff --git a/builtin-blame.c b/builtin-blame.c\nindex 7a5665f..6d51b1f 100644\n--- a/builtin-blame.c\n+++ b/builtin-blame.c\n@@ -2211,6 +2211,8 @@ int cmd_blame(int argc, const char **argv, const char *prefix)\n                 }\n                 else {\n                         /* (3) */\n+                       if (argc <= i)\n+                               usage(blame_usage);\n                         path = add_prefix(prefix, argv[i]);\n                         if (i + 1 == argc - 1) {\n                                 final_commit_name = argv[i + 1];\n"},{"id":"34787","messageId":"7vsld67bp2.fsf@assigned-by-dhcp.cox.net","threadId":"6841","inReplyTo":"45D55F6D.5090900@ray.fi","subject":"Re: [PATCH] git-blame: prevent argument parsing segfault","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-02-16T08:23:37Z","receivedAt":"2007-02-16T08:23:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  Sign-off?\n"}]}