{"thread":{"id":"6834","subject":"[PATCH]: remove extra-verbosity from git-clone (http)","startedAt":"2007-02-15T17:10:07Z","lastAt":"2007-03-20T06:46:35Z","messageCount":5,"participants":["Fernando Herrera","Chris Wright","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"34720","messageId":"58d389c20702150910x24ec218bjdb9cb49ee03fd1df@mail.gmail.com","threadId":"6834","inReplyTo":null,"subject":"[PATCH]: remove extra-verbosity from git-clone (http)","fromName":"Fernando Herrera","fromEmail":"fherrera@onirica.com","sentAt":"2007-02-15T17:10:07Z","receivedAt":"2007-02-15T17:10:07Z","isPatch":true,"sender":{"key":"fherrera@onirica.com","avatar":null},"body":"Hi,\n\nthe attached patch removes the extra verbosity when cloning a http\nrepository. I noticed this after some git upgrade in fedora. Please,\nconsider applying it, getting tons of \"got XXX\", \"walk XXX\" lines by\ndefault is a little bit annoying.\n\nSalu2\n\nPS: Thanks for this so great piece os software!\n\n\n--- git-clone.sh.orig\t2007-02-15 19:03:51.000000000 +0200\n+++ git-clone.sh\t2007-02-15 19:04:06.000000000 +0200\n@@ -59,7 +59,7 @@\n \t\telse\n \t\t\ttname=$name\n \t\tfi\n-\t\tgit-http-fetch -v -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n+\t\tgit-http-fetch -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n \tdone <\"$clone_tmp/refs\"\n \trm -fr \"$clone_tmp\"\n \thttp_fetch \"$1/HEAD\" \"$GIT_DIR/REMOTE_HEAD\" ||\n"},{"id":"37558","messageId":"20070319230436.GB12555@sequoia.sous-sol.org","threadId":"6834","inReplyTo":"58d389c20702150910x24ec218bjdb9cb49ee03fd1df@mail.gmail.com","subject":"Re: [PATCH]: remove extra-verbosity from git-clone (http)","fromName":"Chris Wright","fromEmail":"chrisw@sous-sol.org","sentAt":"2007-03-19T23:04:36Z","receivedAt":"2007-03-19T23:04:36Z","isPatch":true,"sender":{"key":"chrisw@sous-sol.org","avatar":null},"body":"* Fernando Herrera (fherrera@onirica.com) wrote:\n> the attached patch removes the extra verbosity when cloning a http\n> repository. I noticed this after some git upgrade in fedora. Please,\n> consider applying it, getting tons of \"got XXX\", \"walk XXX\" lines by\n> default is a little bit annoying.\n> \n> Salu2\n> \n> PS: Thanks for this so great piece os software!\n> \n> --- git-clone.sh.orig\t2007-02-15 19:03:51.000000000 +0200\n> +++ git-clone.sh\t2007-02-15 19:04:06.000000000 +0200\n> @@ -59,7 +59,7 @@\n>  \t\telse\n>  \t\t\ttname=$name\n>  \t\tfi\n> -\t\tgit-http-fetch -v -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n> +\t\tgit-http-fetch -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n>  \tdone <\"$clone_tmp/refs\"\n>  \trm -fr \"$clone_tmp\"\n>  \thttp_fetch \"$1/HEAD\" \"$GIT_DIR/REMOTE_HEAD\" ||\n\nWas there any problem with this patch from Fernando?  I don't care much\neither way (I simply never use http fetch myself ;-).  Just doing some\nold bugzilla cleanup and noticed this still was neither picked up nor\nreplied to.  So, in case it just fell through the cracks...\n\nthanks,\n-chris\n"},{"id":"37561","messageId":"7vslc0er1e.fsf@assigned-by-dhcp.cox.net","threadId":"6834","inReplyTo":"20070319230436.GB12555@sequoia.sous-sol.org","subject":"Re: [PATCH]: remove extra-verbosity from git-clone (http)","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-19T23:45:33Z","receivedAt":"2007-03-19T23:45:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Chris Wright <chrisw@sous-sol.org> writes:\n\n> * Fernando Herrera (fherrera@onirica.com) wrote:\n>> the attached patch removes the extra verbosity when cloning a http\n>> repository. I noticed this after some git upgrade in fedora. Please,\n>> consider applying it, getting tons of \"got XXX\", \"walk XXX\" lines by\n>> default is a little bit annoying.\n>> \n>> Salu2\n>> \n>> PS: Thanks for this so great piece os software!\n>> \n>> --- git-clone.sh.orig\t2007-02-15 19:03:51.000000000 +0200\n>> +++ git-clone.sh\t2007-02-15 19:04:06.000000000 +0200\n>> @@ -59,7 +59,7 @@\n>>  \t\telse\n>>  \t\t\ttname=$name\n>>  \t\tfi\n>> -\t\tgit-http-fetch -v -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n>> +\t\tgit-http-fetch -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n>>  \tdone <\"$clone_tmp/refs\"\n>>  \trm -fr \"$clone_tmp\"\n>>  \thttp_fetch \"$1/HEAD\" \"$GIT_DIR/REMOTE_HEAD\" ||\n>\n> Was there any problem with this patch from Fernando?  I don't care much\n> either way (I simply never use http fetch myself ;-).  Just doing some\n> old bugzilla cleanup and noticed this still was neither picked up nor\n> replied to.  So, in case it just fell through the cracks...\n\nI saw it.  The -v option used not to be there, but we added it\nwith an explicit purpose of not boring people fetching over http\nconnection (which used to be slow especially before packfiles\nwere introduced).  I do not care much either way, but I suspect\nthere actually are people who want to see that \"assuring look\"\nof something happening.  I dunno.\n\nI am certainly *not* opposed to have an explicit option or a\nper-user configuration to make it not pass -v to http-fetch.  I\nam just wondering if we want to change the default.  Especially\npeople new to git may wonder what is happening without _any_\nfeedback if we turned it off by default.\n"},{"id":"37570","messageId":"20070320021818.GG10574@sequoia.sous-sol.org","threadId":"6834","inReplyTo":"7vslc0er1e.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH]: remove extra-verbosity from git-clone (http)","fromName":"Chris Wright","fromEmail":"chrisw@sous-sol.org","sentAt":"2007-03-20T02:18:18Z","receivedAt":"2007-03-20T02:18:18Z","isPatch":true,"sender":{"key":"chrisw@sous-sol.org","avatar":null},"body":"* Junio C Hamano (junkio@cox.net) wrote:\n> I saw it.  The -v option used not to be there, but we added it\n> with an explicit purpose of not boring people fetching over http\n> connection (which used to be slow especially before packfiles\n> were introduced).  I do not care much either way, but I suspect\n> there actually are people who want to see that \"assuring look\"\n> of something happening.  I dunno.\n\nActually, I very much agree now that I've actually tried it\nmyself when testing the simple patch below.\n\n> I am certainly *not* opposed to have an explicit option or a\n> per-user configuration to make it not pass -v to http-fetch.  I\n> am just wondering if we want to change the default.  Especially\n> people new to git may wonder what is happening without _any_\n> feedback if we turned it off by default.\n\nWell, there's enough to go on already.  So how about this simple change\nfor those few that are bothered by the verbose output?  Works in my\nbasic testing.\n\nthanks,\n-chris\n--\nSubject: [PATCH] make git clone -q suppress the noise with http fetch\n\nWe already have -q in git clone.  So for those who care to suppress\nthe noise during an http based clone, make -q actually do a quiet\nhttp fetch.\n\nSigned-off-by: Chris Wright <chrisw@sous-sol.org>\nCc: Fernando Herrera <fherrera@onirica.com>\n---\n git-clone.sh |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-clone.sh b/git-clone.sh\nindex 1bd54de..ab6c5c0 100755\n--- a/git-clone.sh\n+++ b/git-clone.sh\n@@ -42,6 +42,7 @@ clone_dumb_http () {\n \thttp_fetch \"$1/info/refs\" \"$clone_tmp/refs\" ||\n \t\tdie \"Cannot get remote repository information.\n Perhaps git-update-server-info needs to be run there?\"\n+\ttest \"z$quiet\" = z && v=-v || v=\n \twhile read sha1 refname\n \tdo\n \t\tname=`expr \"z$refname\" : 'zrefs/\\(.*\\)'` &&\n@@ -59,7 +60,7 @@ Perhaps git-update-server-info needs to be run there?\"\n \t\telse\n \t\t\ttname=$name\n \t\tfi\n-\t\tgit-http-fetch -v -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n+\t\tgit-http-fetch $v -a -w \"$tname\" \"$name\" \"$1/\" || exit 1\n \tdone <\"$clone_tmp/refs\"\n \trm -fr \"$clone_tmp\"\n \thttp_fetch \"$1/HEAD\" \"$GIT_DIR/REMOTE_HEAD\" ||\n"},{"id":"37601","messageId":"7vtzwg9zuc.fsf@assigned-by-dhcp.cox.net","threadId":"6834","inReplyTo":"20070320021818.GG10574@sequoia.sous-sol.org","subject":"Re: [PATCH]: remove extra-verbosity from git-clone (http)","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-03-20T06:46:35Z","receivedAt":"2007-03-20T06:46:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sounds sane.  Thanks.\n"}]}