{"thread":{"id":"6779","subject":"Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))","startedAt":"2007-02-12T08:39:46Z","lastAt":"2007-02-12T12:00:52Z","messageCount":5,"participants":["Geert Uytterhoeven","Jeff King","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"34265","messageId":"Pine.LNX.4.62.0702120934120.10436@chinchilla.sonytel.be","threadId":"6779","inReplyTo":null,"subject":"Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))","fromName":"Geert Uytterhoeven","fromEmail":"geert@linux-m68k.org","sentAt":"2007-02-12T08:39:46Z","receivedAt":"2007-02-12T08:39:46Z","isPatch":true,"sender":{"key":"geert@linux-m68k.org","avatar":"https://gravatar.com/avatar/8105b34f653a7b5b98e225e565b11ebcc762ad4ab1a9d905a4663db029a9e6bc?d=mp&s=160"},"body":"\tHi,\n\nI received the email below, showing a _full_ (i.e. every single line) diff\nbetween the old and the new version:\n\n| Date: Sun, 11 Feb 2007 20:00:54 GMT\n| From: Linux Kernel Mailing List \n| To: git-commits-head@vger.kernel.org\n| Subject: [PATCH] Char: serial167, cleanup\n| \n| Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=44bafdf37b30234671d4e2fb595dea4c3717d089\n| Commit: 44bafdf37b30234671d4e2fb595dea4c3717d089\n| Parent: 30a063a900518926966f4d75333c1bfbde1658fa\n| Author: Jiri Slaby \n| AuthorDate: Sat Feb 10 01:45:08 2007 -0800\n| Committer: Linus Torvalds \n| CommitDate: Sun Feb 11 10:51:28 2007 -0800\n| \n| [PATCH] Char: serial167, cleanup\n| \n| serial167, cleanup\n| \n| - Lindent the code\n| - remove 3 pointers from paranoia_check\n| \n| Signed-off-by: Jiri Slaby \n| Signed-off-by: Andrew Morton \n| Signed-off-by: Linus Torvalds \n| ---\n| drivers/char/serial167.c | 5616 +++++++++++++++++++++++-----------------------\n| 1 files changed, 2792 insertions(+), 2824 deletions(-)\n| \n| diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c\n| dissimilarity index 67%\n| index af50d32..5fd314a 100644\n| --- a/drivers/char/serial167.c\n| +++ b/drivers/char/serial167.c\n| @@ -1,2824 +1,2792 @@\n| -/*\n| - * linux/drivers/char/serial167.c\n| - *\n\n [...]\n\n| -#endif\n| -\n| -MODULE_LICENSE(\"GPL\");\n| +/*\n| + * linux/drivers/char/serial167.c\n| + *\n\n [...]\n\n| +#endif\n| +\n| +MODULE_LICENSE(\"GPL\");\n| -\n| To unsubscribe from this list: send the line \"unsubscribe git-commits-head\" in\n| the body of a message to majordomo@vger.kernel.org\n| More majordomo info at http://vger.kernel.org/majordomo-info.html\n\nAt first I thought the new version had CR/LF line endings or so, but that\nisn't the case.\n\nJust using\n\n| anakin$ git show 44bafdf37b30234671d4e2fb595dea4c3717d089 | diffstat\n| serial167.c | 3322 +++++++++++++++++++++++++++++-------------------------------\n| 1 file changed, 1645 insertions(+), 1677 deletions(-)\n| anakin$\n\nshows that far from all lines were changed.\n\nGr{oetje,eeting}s,\n\n\t\t\t\t\t\tGeert\n\nP.S. I'm not subscribed to git@vger.kernel.org, please CC me on replies\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n\t\t\t\t\t\t\t -- Linus Torvalds\n"},{"id":"34266","messageId":"20070212085102.GA12605@coredump.intra.peff.net","threadId":"6779","inReplyTo":"Pine.LNX.4.62.0702120934120.10436@chinchilla.sonytel.be","subject":"Re: Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-02-12T08:51:03Z","receivedAt":"2007-02-12T08:51:03Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Feb 12, 2007 at 09:39:46AM +0100, Geert Uytterhoeven wrote:\n\n> At first I thought the new version had CR/LF line endings or so, but that\n> isn't the case.\n\nClose. It looks like tabs/spaces changes. Try\n\n git show 44bafd | cat -A | less\n\n-Peff\n"},{"id":"34267","messageId":"20070212092028.GB12605@coredump.intra.peff.net","threadId":"6779","inReplyTo":"Pine.LNX.4.62.0702120934120.10436@chinchilla.sonytel.be","subject":"Re: Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-02-12T09:20:30Z","receivedAt":"2007-02-12T09:20:30Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Feb 12, 2007 at 09:39:46AM +0100, Geert Uytterhoeven wrote:\n\n> I received the email below, showing a _full_ (i.e. every single line) diff\n> between the old and the new version:\n\nHmm. I'm not sure what is generating this, but the diffstat in the email\nis wrong (anybody know where the mailing list feeder script lives?).\n\n> | diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c\n> | dissimilarity index 67%\n> | index af50d32..5fd314a 100644\n> | --- a/drivers/char/serial167.c\n> | +++ b/drivers/char/serial167.c\n> | @@ -1,2824 +1,2792 @@\n> | -/*\n> | - * linux/drivers/char/serial167.c\n> | - *\n\nThis may or may not be related to the diffstat issue; you can get a\nsimilar effect by asking for a lot of context. For example:\n\n git show --unified=150 44bafd\n\n> | anakin$ git show 44bafdf37b30234671d4e2fb595dea4c3717d089 | diffstat\n> | serial167.c | 3322 +++++++++++++++++++++++++++++-------------------------------\n> | 1 file changed, 1645 insertions(+), 1677 deletions(-)\n\nThis is also what git produces, using\n\n git show --stat 44bafd\n\nI think there is probably some erroneous magic going on in whatever\nscript generates the mail.\n\n-Peff\n"},{"id":"34269","messageId":"20070212093813.GA15779@coredump.intra.peff.net","threadId":"6779","inReplyTo":"20070212092028.GB12605@coredump.intra.peff.net","subject":"Re: Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-02-12T09:38:13Z","receivedAt":"2007-02-12T09:38:13Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Feb 12, 2007 at 04:20:30AM -0500, Jeff King wrote:\n\n> > | diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c\n> > | dissimilarity index 67%\n> > | index af50d32..5fd314a 100644\n\nOK, I see now. This is triggered by using 'git show -B', which breaks\nthe diff apart into a big rewriting chunk. Unfortunately, I don't know\nenough about how -B works to say whether this makes sense or not.\n\n-Peff\n"},{"id":"34279","messageId":"Pine.LNX.4.63.0702121257590.22628@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"6779","inReplyTo":"20070212093813.GA15779@coredump.intra.peff.net","subject":"Re: Why a _full_ diff? (was: [PATCH] Char: serial167, cleanup (fwd))","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-02-12T12:00:52Z","receivedAt":"2007-02-12T12:00:52Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 12 Feb 2007, Jeff King wrote:\n\n> On Mon, Feb 12, 2007 at 04:20:30AM -0500, Jeff King wrote:\n> \n> > > | diff --git a/drivers/char/serial167.c b/drivers/char/serial167.c\n> > > | dissimilarity index 67%\n> > > | index af50d32..5fd314a 100644\n> \n> OK, I see now. This is triggered by using 'git show -B', which breaks\n> the diff apart into a big rewriting chunk. Unfortunately, I don't know\n> enough about how -B works to say whether this makes sense or not.\n\nAFAICT you can provide a minimum score with -B, just as with -M, i.e. if \nthe diff score is larger than this value, it is interpreted as a complete \nrewrite.\n\nHth,\nDscho\n"}]}