{"thread":{"id":"6747","subject":"[PATCH 6/7] git-blame.el: Doc fixes and cleanup","startedAt":"2007-02-09T08:21:51Z","lastAt":"2007-02-09T11:02:59Z","messageCount":3,"participants":["David Kågedal","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"34042","messageId":"87irebpwps.fsf@morpheus.local","threadId":"6747","inReplyTo":null,"subject":"[PATCH 6/7] git-blame.el: Doc fixes and cleanup","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2007-02-09T08:21:51Z","receivedAt":"2007-02-09T08:21:51Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"\nSigned-off-by: David Kågedal <davidk@lysator.liu.se>\n---\n contrib/emacs/git-blame.el |   14 ++++++++++----\n 1 files changed, 10 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el\nindex f183964..7daa4e6 100644\n--- a/contrib/emacs/git-blame.el\n+++ b/contrib/emacs/git-blame.el\n@@ -123,6 +123,7 @@\n \n ;;;###autoload\n (defun git-blame-mode (&optional arg)\n+  \"Minor mode for displaying Git blame\"\n   (interactive \"P\")\n   (if arg\n       (setq git-blame-mode (eq arg 1))\n@@ -170,20 +171,25 @@\n       (process-send-region git-blame-proc (point-min) (point-max))\n       (process-send-eof git-blame-proc))))\n \n+(defun remove-git-blame-text-properties (start end)\n+  (let ((modified (buffer-modified-p))\n+        (inhibit-read-only t))\n+    (remove-text-properties start end '(point-entered nil))\n+    (set-buffer-modified-p modified)))\n+\n (defun git-blame-cleanup ()\n   \"Remove all blame properties\"\n     (mapcar 'delete-overlay git-blame-overlays)\n     (setq git-blame-overlays nil)\n-    (let ((modified (buffer-modified-p)))\n-      (remove-text-properties (point-min) (point-max) '(point-entered nil))\n-      (set-buffer-modified-p modified)))\n+    (remove-git-blame-text-properties (point-min) (point-max)))\n \n (defun git-blame-sentinel (proc status)\n   (with-current-buffer (process-buffer proc)\n     (with-current-buffer git-blame-file\n       (setq git-blame-proc nil)))\n   ;;(kill-buffer (process-buffer proc))\n-  (message \"git blame finished\"))\n+  ;;(message \"git blame finished\")\n+  )\n \n (defvar in-blame-filter nil)\n \n-- \n1.5.0.rc3.204.g93c76\n\n\n-- \nDavid Kågedal\n"},{"id":"34051","messageId":"eqhfdv$8uq$1@sea.gmane.org","threadId":"6747","inReplyTo":"87irebpwps.fsf@morpheus.local","subject":"Re: [PATCH 6/7] git-blame.el: Doc fixes and cleanup","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-02-09T09:39:45Z","receivedAt":"2007-02-09T09:39:45Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"[Cc: git@vger.kernel.org]\n\nDavid K?gedal wrote:\n\n> @@ -123,6 +123,7 @@\n>  \n>  ;;;###autoload\n>  (defun git-blame-mode (&optional arg)\n> +  \"Minor mode for displaying Git blame\"\n>    (interactive \"P\")\n>    (if arg\n>        (setq git-blame-mode (eq arg 1))\n\nWe should probably also change file description in header, and autoload\ninstruction in Installation: section of commentary:\n\n;;; git-blame.el --- Minor mode for displaying Git blame  -*- coding: utf-8 -*-\n;;\n\n[...]\n\n;; If you do not want to load this package before it is necessary, you\n;; can make use of the `autoload' feature, e.g. by adding to your .emacs\n;; the following lines\n;;\n;;    (autoload 'git-blame-mode \"git-blame\"\n;;              \"Minor mode for displaying Git blame\" t)\n\n(docstring is needed because INTERACTIVE is _fourth_ parameter).\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"34056","messageId":"871wkzpp98.fsf@morpheus.local","threadId":"6747","inReplyTo":"eqhfdv$8uq$1@sea.gmane.org","subject":"Re: [PATCH 6/7] git-blame.el: Doc fixes and cleanup","fromName":"David Kågedal","fromEmail":"davidk@lysator.liu.se","sentAt":"2007-02-09T11:02:59Z","receivedAt":"2007-02-09T11:02:59Z","isPatch":true,"sender":{"key":"davidk@lysator.liu.se","avatar":"https://avatars.githubusercontent.com/u/60530?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> [Cc: git@vger.kernel.org]\n>\n> David K?gedal wrote:\n>\n>> @@ -123,6 +123,7 @@\n>>  \n>>  ;;;###autoload\n>>  (defun git-blame-mode (&optional arg)\n>> +  \"Minor mode for displaying Git blame\"\n>>    (interactive \"P\")\n>>    (if arg\n>>        (setq git-blame-mode (eq arg 1))\n>\n> We should probably also change file description in header, and autoload\n> instruction in Installation: section of commentary:\n\nAgreed.\n\n> ;;; git-blame.el --- Minor mode for displaying Git blame  -*- coding: utf-8 -*-\n> ;;\n>\n> [...]\n>\n> ;; If you do not want to load this package before it is necessary, you\n> ;; can make use of the `autoload' feature, e.g. by adding to your .emacs\n> ;; the following lines\n> ;;\n> ;;    (autoload 'git-blame-mode \"git-blame\"\n> ;;              \"Minor mode for displaying Git blame\" t)\n>\n> (docstring is needed because INTERACTIVE is _fourth_ parameter).\n\nYes?  Of course you need the doc string here, since the file isn't\nloaded yet.\n\n-- \nDavid Kågedal\n"}]}