{"thread":{"id":"66899","subject":"[PATCH] doc: update README file name in my first contribution","startedAt":"2026-11-20T17:04:13Z","lastAt":"2026-11-20T18:31:23Z","messageCount":3,"participants":["Ophir Bleicher via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"558976","messageId":"pull.2495.git.git.1795194253192.gitgitgadget@gmail.com","threadId":"66899","inReplyTo":null,"subject":"[PATCH] doc: update README file name in my first contribution","fromName":"Ophir Bleicher via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-11-20T17:04:13Z","receivedAt":"2026-11-20T17:04:13Z","isPatch":true,"sender":{"key":"name:Ophir Bleicher","avatar":null},"body":"From: Ophir Bleicher <ophirble@gmail.com>\n\nThe translation notice in MyFirstContribution.adoc referenced\npo/README, but the actual file name is po/README.md.\nChanged it to po/README.md.\n\nSigned-off-by: Ophir Bleicher <ophirble@gmail.com>\n---\n    doc: update README file name in my first contribution\n    \n    The translation notice in MyFirstContribution.adoc referenced po/README,\n    but the actual file name is po/README.md. Changed it to po/README.md.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2495%2FOphirBleicher%2Fpatch-2-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2495/OphirBleicher/patch-2-v1\nPull-Request: https://github.com/git/git/pull/2495\n\n Documentation/MyFirstContribution.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc\nindex c58253fd54..29dc402e5a 100644\n--- a/Documentation/MyFirstContribution.adoc\n+++ b/Documentation/MyFirstContribution.adoc\n@@ -186,7 +186,7 @@ decent starting point as we can now add build rules and register the command.\n \n NOTE: Your throwaway text, as well as much of the text you will be adding over\n the course of this tutorial, is user-facing. That means it needs to be\n-localizable. Take a look at `po/README` under \"Marking strings for translation\".\n+localizable. Take a look at `po/README.md` under \"Marking strings for translation\".\n Throughout the tutorial, we will mark strings for translation as necessary; you\n should also do so when writing your user-facing commands in the future.\n \n\nbase-commit: f7de81456940dd6f3274e461149bba12965de609\n-- \ngitgitgadget\n\n"},{"id":"558984","messageId":"xmqqbj7jqs24.fsf@gitster.g","threadId":"66899","inReplyTo":"pull.2495.git.git.1795194253192.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: update README file name in my first contribution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-20T18:24:51Z","receivedAt":"2026-11-20T18:24:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Ophir Bleicher via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Ophir Bleicher <ophirble@gmail.com>\n>\n> The translation notice in MyFirstContribution.adoc referenced\n\n\"references\".  We refer to the status quo in the present tense.\n\n> po/README, but the actual file name is po/README.md.\n> Changed it to po/README.md.\n\nHave a blank line between the observation and the action.  Write the\naction part as if you are telling an imaginary person what to do,\ni.e.\n\n\"Change it to\".\n\n> -localizable. Take a look at `po/README` under \"Marking strings for translation\".\n> +localizable. Take a look at `po/README.md` under \"Marking strings for translation\".\n\nLooking good.\n\nWill queue with commit message tweaks.\n\nTHanks.\n\n"},{"id":"558985","messageId":"pull.2495.v2.git.git.1795199483155.gitgitgadget@gmail.com","threadId":"66899","inReplyTo":"pull.2495.git.git.1795194253192.gitgitgadget@gmail.com","subject":"[PATCH v2] doc: update README file name in my first contribution","fromName":"Ophir Bleicher via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-11-20T18:31:23Z","receivedAt":"2026-11-20T18:31:23Z","isPatch":true,"sender":{"key":"name:Ophir Bleicher","avatar":null},"body":"From: Ophir Bleicher <ophirble@gmail.com>\n\nThe translation notice in MyFirstContribution.adoc references\npo/README, but the actual file name is po/README.md.\n\nChange it to po/README.md.\n\nSigned-off-by: Ophir Bleicher <ophirble@gmail.com>\n---\n    doc: update README file name in my first contribution\n    \n    The translation notice in MyFirstContribution.adoc referenced po/README,\n    but the actual file name is po/README.md. Changed it to po/README.md.\n    \n    Changes from v1:\n    \n     * Update commit message grammatical syntax\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2495%2FOphirBleicher%2Fpatch-2-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2495/OphirBleicher/patch-2-v2\nPull-Request: https://github.com/git/git/pull/2495\n\nRange-diff vs v1:\n\n 1:  4e8ec81b21 ! 1:  11905ef191 doc: update README file name in my first contribution\n     @@ Metadata\n       ## Commit message ##\n          doc: update README file name in my first contribution\n      \n     -    The translation notice in MyFirstContribution.adoc referenced\n     +    The translation notice in MyFirstContribution.adoc references\n          po/README, but the actual file name is po/README.md.\n     -    Changed it to po/README.md.\n     +\n     +    Change it to po/README.md.\n      \n          Signed-off-by: Ophir Bleicher <ophirble@gmail.com>\n      \n\n\n Documentation/MyFirstContribution.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc\nindex c58253fd54..29dc402e5a 100644\n--- a/Documentation/MyFirstContribution.adoc\n+++ b/Documentation/MyFirstContribution.adoc\n@@ -186,7 +186,7 @@ decent starting point as we can now add build rules and register the command.\n \n NOTE: Your throwaway text, as well as much of the text you will be adding over\n the course of this tutorial, is user-facing. That means it needs to be\n-localizable. Take a look at `po/README` under \"Marking strings for translation\".\n+localizable. Take a look at `po/README.md` under \"Marking strings for translation\".\n Throughout the tutorial, we will mark strings for translation as necessary; you\n should also do so when writing your user-facing commands in the future.\n \n\nbase-commit: f7de81456940dd6f3274e461149bba12965de609\n-- \ngitgitgadget\n\n"}]}