{"thread":{"id":"66776","subject":"[Outreachy PATCH] api-parse-options.adoc: restore a dropped word","startedAt":"2026-11-04T22:45:59Z","lastAt":"2026-11-04T23:13:22Z","messageCount":2,"participants":["Cynthia Uche","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"557509","messageId":"20261104224559.4197-1-herroyalpriestess@gmail.com","threadId":"66776","inReplyTo":null,"subject":"[Outreachy PATCH] api-parse-options.adoc: restore a dropped word","fromName":"Cynthia Uche","fromEmail":"herroyalpriestess@gmail.com","sentAt":"2026-11-04T22:45:59Z","receivedAt":"2026-11-04T22:45:59Z","isPatch":true,"sender":{"key":"herroyalpriestess@gmail.com","avatar":null},"body":"The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with \"..., the\nparser early.\", which is not a sentence. The word \"stopping\" was lost\nin 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION\nfrom being used together, 2009-03-09), which rewrote the end of that\nsentence.\n\nRestore it, and rewrap the following line.\n\nSigned-off-by: Cynthia Uche <herroyalpriestess@gmail.com>\n---\n Documentation/technical/api-parse-options.adoc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc\nindex 6dfea34220..14f0d2b572 100644\n--- a/Documentation/technical/api-parse-options.adoc\n+++ b/Documentation/technical/api-parse-options.adoc\n@@ -127,8 +127,8 @@ Flags are the bitwise-or of:\n \t`PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in\n \t`--unknown value` will be mistakenly interpreted as a\n \tnon-option, not as a value belonging to the unknown option,\n-\tthe parser early.  That's why parse_options() errors out if\n-\tboth options are set.\n+\tstopping the parser early.  That's why parse_options() errors\n+\tout if both options are set.\n \tNote that non-option arguments are always kept, even without\n \tthis flag.\n \n-- \n2.56.GIT\n\n\n"},{"id":"557514","messageId":"xmqq1p90yyul.fsf@gitster.g","threadId":"66776","inReplyTo":"20261104224559.4197-1-herroyalpriestess@gmail.com","subject":"Re: [Outreachy PATCH] api-parse-options.adoc: restore a dropped word","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-04T23:13:22Z","receivedAt":"2026-11-04T23:13:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Cynthia Uche <herroyalpriestess@gmail.com> writes:\n\n> The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with \"..., the\n> parser early.\", which is not a sentence. The word \"stopping\" was lost\n> in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION\n> from being used together, 2009-03-09), which rewrote the end of that\n> sentence.\n\nMakes sense.  Thanks for finding and fixing.\n\n>\n> Restore it, and rewrap the following line.\n>\n> Signed-off-by: Cynthia Uche <herroyalpriestess@gmail.com>\n> ---\n>  Documentation/technical/api-parse-options.adoc | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc\n> index 6dfea34220..14f0d2b572 100644\n> --- a/Documentation/technical/api-parse-options.adoc\n> +++ b/Documentation/technical/api-parse-options.adoc\n> @@ -127,8 +127,8 @@ Flags are the bitwise-or of:\n>  \t`PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in\n>  \t`--unknown value` will be mistakenly interpreted as a\n>  \tnon-option, not as a value belonging to the unknown option,\n> -\tthe parser early.  That's why parse_options() errors out if\n> -\tboth options are set.\n> +\tstopping the parser early.  That's why parse_options() errors\n> +\tout if both options are set.\n>  \tNote that non-option arguments are always kept, even without\n>  \tthis flag.\n\n"}]}