{"thread":{"id":"6676","subject":"Handling of 'git-config foo=bar'","startedAt":"2007-02-04T11:33:50Z","lastAt":"2007-02-04T20:20:12Z","messageCount":3,"participants":["Yann Dirson","Junio C Hamano","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"33569","messageId":"20070204113350.GN5362@nan92-1-81-57-214-146.fbx.proxad.net","threadId":"6676","inReplyTo":null,"subject":"Handling of 'git-config foo=bar'","fromName":"Yann Dirson","fromEmail":"ydirson@altern.org","sentAt":"2007-02-04T11:33:50Z","receivedAt":"2007-02-04T11:33:50Z","isPatch":false,"sender":{"key":"ydirson@altern.org","avatar":"https://avatars.githubusercontent.com/u/1190950?v=4"},"body":"Currently, running \"git-config foo=bar\", ie. presumably an erroneous\nattempt at setting \"foo\", indeed queries \"foo=bar\", so outputs nothing\nand reports success.\n\nDo we want to allow \"=\" signs in config var names ?  It would seem\nreasonable to refuse them, and report an error to the innocent user\n(OK, i'm not that innocent, but still ;)\n\nOr does that sound a bad idea to anyone ?\n\nBest regards,\n-- \nYann.\n"},{"id":"33584","messageId":"7vsldlr8wg.fsf@assigned-by-dhcp.cox.net","threadId":"6676","inReplyTo":"20070204113350.GN5362@nan92-1-81-57-214-146.fbx.proxad.net","subject":"Re: Handling of 'git-config foo=bar'","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-02-04T19:59:43Z","receivedAt":"2007-02-04T19:59:43Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Yann Dirson <ydirson@altern.org> writes:\n\n> Currently, running \"git-config foo=bar\", ie. presumably an erroneous\n> attempt at setting \"foo\", indeed queries \"foo=bar\", so outputs nothing\n> and reports success.\n>\n> Do we want to allow \"=\" signs in config var names ?  It would seem\n> reasonable to refuse them, and report an error to the innocent user\n> (OK, i'm not that innocent, but still ;)\n>\n> Or does that sound a bad idea to anyone ?\n\nSomething like:\n\n   git config remote.origin.fetch=refs/heads/master:refs/heads/origin\n   git config remote.origin.fetch+=refs/heads/next:refs/heads/next\n   git config remote.origin.fetch+=+refs/heads/pu:refs/heads/pu\n   git config remote.origin.fetch+=refs/heads/maint:refs/heads/maint\n\nsounds sensible.\n\nHowever, my feeling is \"git repo-config\" is primarily for use by\nscripts, and we are better off educating users not to be afraid\nof viewing and editing .git/config file themselves.\n"},{"id":"33588","messageId":"eq5f34$ir9$1@sea.gmane.org","threadId":"6676","inReplyTo":"7vsldlr8wg.fsf@assigned-by-dhcp.cox.net","subject":"Re: Handling of 'git-config foo=bar'","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-02-04T20:20:12Z","receivedAt":"2007-02-04T20:20:12Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Yann Dirson <ydirson@altern.org> writes:\n> \n>> Currently, running \"git-config foo=bar\", ie. presumably an erroneous\n>> attempt at setting \"foo\", indeed queries \"foo=bar\", so outputs nothing\n>> and reports success.\n>>\n>> Do we want to allow \"=\" signs in config var names ?  It would seem\n>> reasonable to refuse them, and report an error to the innocent user\n>> (OK, i'm not that innocent, but still ;)\n>>\n>> Or does that sound a bad idea to anyone ?\n> \n> Something like:\n> \n>    git config remote.origin.fetch=refs/heads/master:refs/heads/origin\n>    git config remote.origin.fetch+=refs/heads/next:refs/heads/next\n>    git config remote.origin.fetch+=+refs/heads/pu:refs/heads/pu\n>    git config remote.origin.fetch+=refs/heads/maint:refs/heads/maint\n> \n> sounds sensible.\n> \n> However, my feeling is \"git repo-config\" is primarily for use by\n> scripts, and we are better off educating users not to be afraid\n> of viewing and editing .git/config file themselves.\n\nI think the question was not if we want new syntax for setting variables,\nbut if we want to disallow '=' in variable (key) names. They are pretty\nrestricted, and I cannot think offhand of variable name we would want that\nwould need to have '=' in it...\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}