{"thread":{"id":"66758","subject":"[PATCH] repo_config_values: freeze the structure for now","startedAt":"2026-11-03T19:52:10Z","lastAt":"2026-11-04T16:13:12Z","messageCount":3,"participants":["Junio C Hamano","Patrick Steinhardt","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"557366","messageId":"xmqq1p917kwl.fsf@gitster.g","threadId":"66758","inReplyTo":null,"subject":"[PATCH] repo_config_values: freeze the structure for now","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-03T19:52:10Z","receivedAt":"2026-11-03T19:52:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The configuration and settings per repository is currently in an\nunfortunate mess.  Especially given that repo_config_values() cannot\nwork on any repository instance other than the_repository, moving\nmore members into this structure is unwelcome.\n\nAcked-by: Patrick Steinhardt <ps@pks.im>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n\n * Just for wider visibility.  This is a resend of the patch in\n   https://lore.kernel.org/git/xmqqh5hzjdwr.fsf_-_@gitster.g/\n\n environment.h | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/environment.h b/environment.h\nindex 49c86e8879..87b0ab7251 100644\n--- a/environment.h\n+++ b/environment.h\n@@ -123,6 +123,13 @@ enum object_creation_mode {\n \tOBJECT_CREATION_USES_RENAMES = 1\n };\n \n+/*\n+ * See https://lore.kernel.org/git/anlmwaEtwcCPse1N@pks.im/ and later\n+ * discussions.  Until we figure out what to do with this and\n+ * repo_settings, and allow them to be truly usable on a repository\n+ * instance that is not the_repository, do *NOT* add any new members\n+ * to this structure.\n+ */\n struct repo_config_values {\n \t/* section \"core\" config values */\n \tchar *attributes_file;\n-- \n2.56.0-511-g14903f623d\n\n\n"},{"id":"557406","messageId":"aurSZcNENBrgxowu@pks.im","threadId":"66758","inReplyTo":"xmqq1p917kwl.fsf@gitster.g","subject":"Re: [PATCH] repo_config_values: freeze the structure for now","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-11-04T06:36:21Z","receivedAt":"2026-11-04T06:36:21Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Nov 03, 2026 at 11:52:10AM -0800, Junio C Hamano wrote:\n> The configuration and settings per repository is currently in an\n> unfortunate mess.  Especially given that repo_config_values() cannot\n> work on any repository instance other than the_repository, moving\n> more members into this structure is unwelcome.\n> \n> Acked-by: Patrick Steinhardt <ps@pks.im>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n\nYou already got my Acked-by, but let me state explicitly that I'm happy\nwith this change. Thanks!\n\nPatrick\n\n"},{"id":"557459","messageId":"cfa38152-2fca-4734-94df-bcac44fb499d@gmail.com","threadId":"66758","inReplyTo":"aurSZcNENBrgxowu@pks.im","subject":"Re: [PATCH] repo_config_values: freeze the structure for now","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2026-11-04T16:13:12Z","receivedAt":"2026-11-04T16:13:12Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 11/4/2026 1:36 AM, Patrick Steinhardt wrote:\n> On Tue, Nov 03, 2026 at 11:52:10AM -0800, Junio C Hamano wrote:\n>> The configuration and settings per repository is currently in an\n>> unfortunate mess.  Especially given that repo_config_values() cannot\n>> work on any repository instance other than the_repository, moving\n>> more members into this structure is unwelcome.\n>>\n>> Acked-by: Patrick Steinhardt <ps@pks.im>\n>> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> \n> You already got my Acked-by, but let me state explicitly that I'm happy\n> with this change. Thanks!\nI will also contribute my +1 to this. This has grown organically, but\nclearly needs a redesign from first principles to avoid making the\nsituation worse.\n\nThanks,\n-Stolee\n\n\n"}]}