{"thread":{"id":"66694","subject":"[PATCH] ident: remove unused author_ident_sufficiently_given()","startedAt":"2026-10-28T19:52:23Z","lastAt":"2026-10-28T19:52:23Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"556699","messageId":"xmqqo6cd8ux4.fsf@gitster.g","threadId":"66694","inReplyTo":null,"subject":"[PATCH] ident: remove unused author_ident_sufficiently_given()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-28T19:52:23Z","receivedAt":"2026-10-28T19:52:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"A pair of functions {author,committer}_ident_sufficiently_given()\nwere created to replace user_ident_explicitly_given() in d6991ceedc\n(ident: keep separate \"explicit\" flags for author and committer,\n2012-11-14).\n\nBut author_ident_sufficiently_given() is never used in our history.\nWe only check if committer ident is sufficiently given and use it to\nnudge the user to set user.{name,email} configuration variables.\n\nRemove the unused author_ident_sufficiently_given() function.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n ident.c | 5 -----\n ident.h | 1 -\n 2 files changed, 6 deletions(-)\n\ndiff --git a/ident.c b/ident.c\nindex 0b7aacecd7..eb73d073d8 100644\n--- a/ident.c\n+++ b/ident.c\n@@ -602,11 +602,6 @@ int committer_ident_sufficiently_given(void)\n \treturn ident_is_sufficient(committer_ident_explicitly_given);\n }\n \n-int author_ident_sufficiently_given(void)\n-{\n-\treturn ident_is_sufficient(author_ident_explicitly_given);\n-}\n-\n static int set_ident(const char *var, const char *value)\n {\n \tif (!strcmp(var, \"author.name\")) {\ndiff --git a/ident.h b/ident.h\nindex 3c03403879..7e60e36415 100644\n--- a/ident.h\n+++ b/ident.h\n@@ -60,7 +60,6 @@ const char *fmt_ident(const char *name, const char *email,\n const char *fmt_name(enum want_ident);\n \n int committer_ident_sufficiently_given(void);\n-int author_ident_sufficiently_given(void);\n \n struct config_context;\n int git_ident_config(const char *, const char *, const struct config_context *,\n-- \n2.56.0-433-ga9209adf11\n\n\n"}]}