{"thread":{"id":"66668","subject":"[GSoC PATCH] t7104: use test_path_is_file instead of test -f","startedAt":"2026-10-26T16:45:36Z","lastAt":"2026-10-27T19:29:35Z","messageCount":4,"participants":["Tilak Kumar","Junio C Hamano","Tilak Raaz"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"556370","messageId":"20261026164536.50520-1-raaztilak07@gmail.com","threadId":"66668","inReplyTo":null,"subject":"[GSoC PATCH] t7104: use test_path_is_file instead of test -f","fromName":"Tilak Kumar","fromEmail":"raaztilak07@gmail.com","sentAt":"2026-10-26T16:45:36Z","receivedAt":"2026-10-26T16:45:36Z","isPatch":true,"sender":{"key":"raaztilak07@gmail.com","avatar":null},"body":"Use the helper so that a missing file is reported\nwith a clear message instead of a silent failure.\n\nSigned-off-by: Tilak Kumar <raaztilak07@gmail.com>\n---\n t/t7104-reset-hard.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7104-reset-hard.sh b/t/t7104-reset-hard.sh\nindex c23d6e3f52..acf145e69b 100755\n--- a/t/t7104-reset-hard.sh\n+++ b/t/t7104-reset-hard.sh\n@@ -29,7 +29,7 @@ test_expect_success 'reset --hard should restore unmerged ones' '\n \n \tgit reset --hard &&\n \tgit ls-files --error-unmatch before/1 before/2 hello later/3 &&\n-\ttest -f hello\n+\ttest_path_is_file hello\n \n '\n \n-- \n2.55.0\n\n\n"},{"id":"556408","messageId":"xmqq7bj4p3ax.fsf@gitster.g","threadId":"66668","inReplyTo":"20261026164536.50520-1-raaztilak07@gmail.com","subject":"Re: [GSoC PATCH] t7104: use test_path_is_file instead of test -f","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-26T21:20:06Z","receivedAt":"2026-10-26T21:20:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tilak Kumar <raaztilak07@gmail.com> writes:\n\n> Use the helper so that a missing file is reported\n> with a clear message instead of a silent failure.\n\nThis makes sense but what is GSoC doing in the patch title?  Has the\nprogram already been announced for 2027?\n\n> Signed-off-by: Tilak Kumar <raaztilak07@gmail.com>\n> ---\n>  t/t7104-reset-hard.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t7104-reset-hard.sh b/t/t7104-reset-hard.sh\n> index c23d6e3f52..acf145e69b 100755\n> --- a/t/t7104-reset-hard.sh\n> +++ b/t/t7104-reset-hard.sh\n> @@ -29,7 +29,7 @@ test_expect_success 'reset --hard should restore unmerged ones' '\n>  \n>  \tgit reset --hard &&\n>  \tgit ls-files --error-unmatch before/1 before/2 hello later/3 &&\n> -\ttest -f hello\n> +\ttest_path_is_file hello\n>  \n>  '\n\n"},{"id":"556420","messageId":"CABB4Jh3QD5-4d8+cSgVj+WbP3Uj+FHqL4kS_4uP5anepTEQCQQ@mail.gmail.com","threadId":"66668","inReplyTo":"xmqq7bj4p3ax.fsf@gitster.g","subject":"Re: [GSoC PATCH] t7104: use test_path_is_file instead of test -f","fromName":"Tilak Raaz","fromEmail":"raaztilak07@gmail.com","sentAt":"2026-10-27T03:16:04Z","receivedAt":"2026-10-27T03:16:04Z","isPatch":true,"sender":{"key":"raaztilak07@gmail.com","avatar":null},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> This makes sense but what is GSoC doing in the patch title?  Has the\n> program already been announced for 2027?\n\nNot yet.I added the prefix while preparing to apply for GSoC 2027,\nwhich was premature. I will use a plain [PATCH] prefix going forward.\nThanks for the feedback.\nI can resend this as v2 with the subject fixed if that is helpful.\nThanks.\n\n"},{"id":"556565","messageId":"xmqq8q3jj61s.fsf@gitster.g","threadId":"66668","inReplyTo":"CABB4Jh3QD5-4d8+cSgVj+WbP3Uj+FHqL4kS_4uP5anepTEQCQQ@mail.gmail.com","subject":"Re: [GSoC PATCH] t7104: use test_path_is_file instead of test -f","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-27T19:29:35Z","receivedAt":"2026-10-27T19:29:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tilak Raaz <raaztilak07@gmail.com> writes:\n\n> Junio C Hamano <gitster@pobox.com> writes:\n>\n>> This makes sense but what is GSoC doing in the patch title?  Has the\n>> program already been announced for 2027?\n>\n> Not yet.I added the prefix while preparing to apply for GSoC 2027,\n> which was premature.\n\nOK, that is fine and makes your patches more informative.\n\nMy question was not rhetorical, complaining about the use of the\nmark.  I knew (and confirmed later with the people who run the\nprogram at Google) that the announcement would not be made until\nDecember, and wanted to know if there is public information that\nsays otherwise.\n\nThanks.\n\n"}]}