{"thread":{"id":"66646","subject":"[Outreachy] Microproject: Modernize file check in t5300-pack-object.sh","startedAt":"2026-10-23T15:48:42Z","lastAt":"2026-10-29T18:36:50Z","messageCount":11,"participants":["Ogundipe Sola Taiwo","Usman Akinyemi","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"556069","messageId":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","threadId":"66646","inReplyTo":null,"subject":"[Outreachy] Microproject: Modernize file check in t5300-pack-object.sh","fromName":"Ogundipe Sola Taiwo","fromEmail":"ogundipesolataiwo12@gmail.com","sentAt":"2026-10-23T15:48:42Z","receivedAt":"2026-10-23T15:48:42Z","isPatch":false,"sender":{"key":"ogundipesolataiwo12@gmail.com","avatar":null},"body":"Hi everyone,\n\nMy name is Sola Ogundipe. I'm an Outreachy applicant for the December 2026 round.\nI've cloned and setup the repo locally and also played around with adding a git command\nfollowing the \"My First Contribution Tutorial\".\n\nI'd like to work on modernizing the 5 occurences of file check in the t5300-pack-object.sh\nfile. I've checked the public inbox and found no one working on fixing the same issue for\nthis file.\n\nPlease let me know if I should proceed with the changes.\n\nBest regards,\nSola\n\n\n"},{"id":"556302","messageId":"20261026102017.2689-1-ogundipesolataiwo12@gmail.com","threadId":"66646","inReplyTo":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","subject":"[PATCH] t5300: modernize test path checks in t5300","fromName":"Ogundipe Sola Taiwo","fromEmail":"ogundipesolataiwo12@gmail.com","sentAt":"2026-10-26T10:20:13Z","receivedAt":"2026-10-26T10:20:13Z","isPatch":true,"sender":{"key":"ogundipesolataiwo12@gmail.com","avatar":null},"body":"This commit improves test t5300-pack-object by converting old-style\npath checks to use the `test_path_is_file` helper function.\n\nSigned-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n---\n t/t5300-pack-object.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\nindex aac139e6a0..e5ce478484 100755\n--- a/t/t5300-pack-object.sh\n+++ b/t/t5300-pack-object.sh\n@@ -283,11 +283,11 @@ test_expect_success 'survive missing objects/pack directory' '\n \t\tGOP=.git/objects/pack &&\n \t\trm -fr $GOP &&\n \t\tgit index-pack --stdin --keep=test <../test-3-${packname_3}.pack &&\n-\t\ttest -f $GOP/pack-${packname_3}.pack &&\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.pack &&\n \t\tcmp $GOP/pack-${packname_3}.pack ../test-3-${packname_3}.pack &&\n-\t\ttest -f $GOP/pack-${packname_3}.idx &&\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.idx &&\n \t\tcmp $GOP/pack-${packname_3}.idx ../test-3-${packname_3}.idx &&\n-\t\ttest -f $GOP/pack-${packname_3}.keep\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.keep\n \t)\n '\n\n@@ -376,7 +376,7 @@ test_expect_success 'build pack index for an existing pack' '\n \trm -f test-4.keep &&\n \tgit index-pack --keep=why test-4.pack &&\n \tcmp test-1-${packname_1}.idx test-4.idx &&\n-\ttest -f test-4.keep &&\n+\ttest_path_is_file test-4.keep &&\n\n \t:\n '\n@@ -616,7 +616,7 @@ test_expect_success 'setup: fake a SHA1 hash collision' '\n \t\tcd corrupt &&\n \t\tlong_a=$(git hash-object -w ../a | sed -e \"s!^..!&/!\") &&\n \t\tlong_b=$(git hash-object -w ../b | sed -e \"s!^..!&/!\") &&\n-\t\ttest -f\t.git/objects/$long_b &&\n+\t\ttest_path_is_file .git/objects/$long_b &&\n \t\tcp -f\t.git/objects/$long_a \\\n \t\t\t.git/objects/$long_b\n \t)\n--\n2.56.0.116.g6de20f6092.dirty\n\n\n"},{"id":"556401","messageId":"CAPSxiM-xyBNHuA5Lm=e-L6z5zu8dGN5kLwGCPjaYQT8XO9Gizg@mail.gmail.com","threadId":"66646","inReplyTo":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","subject":"Re: [Outreachy] Microproject: Modernize file check in t5300-pack-object.sh","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-26T20:32:11Z","receivedAt":"2026-10-26T20:32:11Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":">\n> Hi everyone,\n>\n> My name is Sola Ogundipe. I'm an Outreachy applicant for the December 2026 round.\n> I've cloned and setup the repo locally and also played around with adding a git command\n> following the \"My First Contribution Tutorial\".\nHello Sola,\n\nWelcome to the Git project and thanks for your interest to the Git project.\n>\n> I'd like to work on modernizing the 5 occurences of file check in the t5300-pack-object.sh\n> file. I've checked the public inbox and found no one working on fixing the same issue for\n> this file.\n>\n> Please let me know if I should proceed with the changes.\n>\nYou can work on it.\n> Best regards,\n> Sola\n>\nThanks.\n\n"},{"id":"556530","messageId":"CAPSxiM85tDse=qD8cEP42uyGFV9JTJYV8_98SWTm1wTmWj7kPw@mail.gmail.com","threadId":"66646","inReplyTo":"20261026102017.2689-1-ogundipesolataiwo12@gmail.com","subject":"Re: [PATCH] t5300: modernize test path checks in t5300","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-27T16:56:33Z","receivedAt":"2026-10-27T16:56:33Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Mon, Oct 26, 2026 at 11:20 AM Ogundipe Sola Taiwo\n<ogundipesolataiwo12@gmail.com> wrote:\n>\n> This commit improves test t5300-pack-object by converting old-style\n\nCould you rephrase this to avoid “This commit”? It's redundant in a\ncommit message.\"\nPlease describe the change directly instead. Also, I believe, the term\npatch is more\nappropriate and not \"commit\".\n\n> path checks to use the `test_path_is_file` helper function.\n>\n> Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n> ---\nApart from that, the changes looks good to me.\n> --\n> 2.56.0.116.g6de20f6092.dirty\n>\n\n"},{"id":"556555","messageId":"20261027183623.3600-1-ogundipesolataiwo12@gmail.com","threadId":"66646","inReplyTo":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","subject":"[PATCH v2] t5300: modernize test path checks in t5300","fromName":"Ogundipe Sola Taiwo","fromEmail":"ogundipesolataiwo12@gmail.com","sentAt":"2026-10-27T18:36:20Z","receivedAt":"2026-10-27T18:36:20Z","isPatch":true,"sender":{"key":"ogundipesolataiwo12@gmail.com","avatar":null},"body":"Improves test t5300-pack-object by converting old-style\npath checks to use the `test_path_is_file` helper function.\n\nSigned-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n---\nChanges in v2:\n- Rephrase patch summary to remove redundant wording\n\n t/t5300-pack-object.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\nindex aac139e6a0..e5ce478484 100755\n--- a/t/t5300-pack-object.sh\n+++ b/t/t5300-pack-object.sh\n@@ -283,11 +283,11 @@ test_expect_success 'survive missing objects/pack directory' '\n \t\tGOP=.git/objects/pack &&\n \t\trm -fr $GOP &&\n \t\tgit index-pack --stdin --keep=test <../test-3-${packname_3}.pack &&\n-\t\ttest -f $GOP/pack-${packname_3}.pack &&\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.pack &&\n \t\tcmp $GOP/pack-${packname_3}.pack ../test-3-${packname_3}.pack &&\n-\t\ttest -f $GOP/pack-${packname_3}.idx &&\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.idx &&\n \t\tcmp $GOP/pack-${packname_3}.idx ../test-3-${packname_3}.idx &&\n-\t\ttest -f $GOP/pack-${packname_3}.keep\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.keep\n \t)\n '\n\n@@ -376,7 +376,7 @@ test_expect_success 'build pack index for an existing pack' '\n \trm -f test-4.keep &&\n \tgit index-pack --keep=why test-4.pack &&\n \tcmp test-1-${packname_1}.idx test-4.idx &&\n-\ttest -f test-4.keep &&\n+\ttest_path_is_file test-4.keep &&\n\n \t:\n '\n@@ -616,7 +616,7 @@ test_expect_success 'setup: fake a SHA1 hash collision' '\n \t\tcd corrupt &&\n \t\tlong_a=$(git hash-object -w ../a | sed -e \"s!^..!&/!\") &&\n \t\tlong_b=$(git hash-object -w ../b | sed -e \"s!^..!&/!\") &&\n-\t\ttest -f\t.git/objects/$long_b &&\n+\t\ttest_path_is_file .git/objects/$long_b &&\n \t\tcp -f\t.git/objects/$long_a \\\n \t\t\t.git/objects/$long_b\n \t)\n\nRange-diff against v1:\n1:  ca6cd5870e = 1:  ca6cd5870e t5300: modernize test path checks in t5300\n--\n2.56.0.116.g6de20f6092.dirty\n\n\n"},{"id":"556557","messageId":"20261027184342.3948-1-ogundipesolataiwo12@gmail.com","threadId":"66646","inReplyTo":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","subject":"[Outreachy] Microproject: Modernize file check in t5300-pack-object.sh","fromName":"Ogundipe Sola Taiwo","fromEmail":"ogundipesolataiwo12@gmail.com","sentAt":"2026-10-27T18:42:43Z","receivedAt":"2026-10-27T18:42:43Z","isPatch":false,"sender":{"key":"ogundipesolataiwo12@gmail.com","avatar":null},"body":"> Could you rephrase this to avoid “This commit”? It's redundant in a\n> commit message.\"\n> Please describe the change directly instead. Also, I believe, the term\n> patch is more\n> appropriate and not \"commit\".\n\nThanks for catching that. I've rephrased it.\n\n"},{"id":"556662","messageId":"CAPSxiM9sZXbLQQsMFiWqXDmiGGM7FzCAH2hWizLL-mX3575g_Q@mail.gmail.com","threadId":"66646","inReplyTo":"20261027183623.3600-1-ogundipesolataiwo12@gmail.com","subject":"Re: [PATCH v2] t5300: modernize test path checks in t5300","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-28T14:02:03Z","receivedAt":"2026-10-28T14:02:03Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":">\n> Improves test t5300-pack-object by converting old-style\nLooks good now. Thanks.\n\n"},{"id":"556664","messageId":"xmqqy0bhdid1.fsf@gitster.g","threadId":"66646","inReplyTo":"20261027183623.3600-1-ogundipesolataiwo12@gmail.com","subject":"Re: [PATCH v2] t5300: modernize test path checks in t5300","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-28T14:12:26Z","receivedAt":"2026-10-28T14:12:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com> writes:\n\n> Improves test t5300-pack-object by converting old-style\n> path checks to use the `test_path_is_file` helper function.\n\n\"Improves\" -> \"Improve\".  It would be nicer to state how use of the\nhelper improves.\n\nSee similar test updates from others and review comment on them in\nthe past 4 weeks from the list archive.\n\nThanks.\n\n>\n> Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n> ---\n> Changes in v2:\n> - Rephrase patch summary to remove redundant wording\n>\n>  t/t5300-pack-object.sh | 10 +++++-----\n>  1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\n> index aac139e6a0..e5ce478484 100755\n> --- a/t/t5300-pack-object.sh\n> +++ b/t/t5300-pack-object.sh\n> @@ -283,11 +283,11 @@ test_expect_success 'survive missing objects/pack directory' '\n>  \t\tGOP=.git/objects/pack &&\n>  \t\trm -fr $GOP &&\n>  \t\tgit index-pack --stdin --keep=test <../test-3-${packname_3}.pack &&\n> -\t\ttest -f $GOP/pack-${packname_3}.pack &&\n> +\t\ttest_path_is_file $GOP/pack-${packname_3}.pack &&\n>  \t\tcmp $GOP/pack-${packname_3}.pack ../test-3-${packname_3}.pack &&\n> -\t\ttest -f $GOP/pack-${packname_3}.idx &&\n> +\t\ttest_path_is_file $GOP/pack-${packname_3}.idx &&\n>  \t\tcmp $GOP/pack-${packname_3}.idx ../test-3-${packname_3}.idx &&\n> -\t\ttest -f $GOP/pack-${packname_3}.keep\n> +\t\ttest_path_is_file $GOP/pack-${packname_3}.keep\n>  \t)\n>  '\n>\n> @@ -376,7 +376,7 @@ test_expect_success 'build pack index for an existing pack' '\n>  \trm -f test-4.keep &&\n>  \tgit index-pack --keep=why test-4.pack &&\n>  \tcmp test-1-${packname_1}.idx test-4.idx &&\n> -\ttest -f test-4.keep &&\n> +\ttest_path_is_file test-4.keep &&\n>\n>  \t:\n>  '\n> @@ -616,7 +616,7 @@ test_expect_success 'setup: fake a SHA1 hash collision' '\n>  \t\tcd corrupt &&\n>  \t\tlong_a=$(git hash-object -w ../a | sed -e \"s!^..!&/!\") &&\n>  \t\tlong_b=$(git hash-object -w ../b | sed -e \"s!^..!&/!\") &&\n> -\t\ttest -f\t.git/objects/$long_b &&\n> +\t\ttest_path_is_file .git/objects/$long_b &&\n>  \t\tcp -f\t.git/objects/$long_a \\\n>  \t\t\t.git/objects/$long_b\n>  \t)\n>\n> Range-diff against v1:\n> 1:  ca6cd5870e = 1:  ca6cd5870e t5300: modernize test path checks in t5300\n> --\n> 2.56.0.116.g6de20f6092.dirty\n\n"},{"id":"556765","messageId":"20261029114846.1601-1-ogundipesolataiwo12@gmail.com","threadId":"66646","inReplyTo":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","subject":"[Outreachy] Microproject: Modernize file check in t5300-pack-object.sh","fromName":"Ogundipe Sola Taiwo","fromEmail":"ogundipesolataiwo12@gmail.com","sentAt":"2026-10-29T11:48:31Z","receivedAt":"2026-10-29T11:48:31Z","isPatch":false,"sender":{"key":"ogundipesolataiwo12@gmail.com","avatar":null},"body":"> \"Improves\" -> \"Improve\".  It would be nicer to state how use of the\n> helper improves.\n>\n> See similar test updates from others and review comment on them in\n> the past 4 weeks from the list archive.\n\nWill do. Thanks\n\n> Thanks.\n\n\n"},{"id":"556766","messageId":"20261029120210.3722-1-ogundipesolataiwo12@gmail.com","threadId":"66646","inReplyTo":"20261023154851.7876-1-ogundipesolataiwo12@gmail.com","subject":"[PATCH v3] t5300: modernize test path checks in t5300","fromName":"Ogundipe Sola Taiwo","fromEmail":"ogundipesolataiwo12@gmail.com","sentAt":"2026-10-29T12:02:06Z","receivedAt":"2026-10-29T12:02:06Z","isPatch":true,"sender":{"key":"ogundipesolataiwo12@gmail.com","avatar":null},"body":"Replace `test -f` commands with `test_path_is_file`, because\nit makes debugging a failing test easier by reporting what\nexpectation was not met.\n\nSigned-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n---\nChanges in v3:\n- Rephrase patch summary to state how the use of `test_path_is_file`\n\timproves the debugging of failing tests.\n\n t/t5300-pack-object.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\nindex aac139e6a0..e5ce478484 100755\n--- a/t/t5300-pack-object.sh\n+++ b/t/t5300-pack-object.sh\n@@ -283,11 +283,11 @@ test_expect_success 'survive missing objects/pack directory' '\n \t\tGOP=.git/objects/pack &&\n \t\trm -fr $GOP &&\n \t\tgit index-pack --stdin --keep=test <../test-3-${packname_3}.pack &&\n-\t\ttest -f $GOP/pack-${packname_3}.pack &&\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.pack &&\n \t\tcmp $GOP/pack-${packname_3}.pack ../test-3-${packname_3}.pack &&\n-\t\ttest -f $GOP/pack-${packname_3}.idx &&\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.idx &&\n \t\tcmp $GOP/pack-${packname_3}.idx ../test-3-${packname_3}.idx &&\n-\t\ttest -f $GOP/pack-${packname_3}.keep\n+\t\ttest_path_is_file $GOP/pack-${packname_3}.keep\n \t)\n '\n\n@@ -376,7 +376,7 @@ test_expect_success 'build pack index for an existing pack' '\n \trm -f test-4.keep &&\n \tgit index-pack --keep=why test-4.pack &&\n \tcmp test-1-${packname_1}.idx test-4.idx &&\n-\ttest -f test-4.keep &&\n+\ttest_path_is_file test-4.keep &&\n\n \t:\n '\n@@ -616,7 +616,7 @@ test_expect_success 'setup: fake a SHA1 hash collision' '\n \t\tcd corrupt &&\n \t\tlong_a=$(git hash-object -w ../a | sed -e \"s!^..!&/!\") &&\n \t\tlong_b=$(git hash-object -w ../b | sed -e \"s!^..!&/!\") &&\n-\t\ttest -f\t.git/objects/$long_b &&\n+\t\ttest_path_is_file .git/objects/$long_b &&\n \t\tcp -f\t.git/objects/$long_a \\\n \t\t\t.git/objects/$long_b\n \t)\n\nRange-diff against v2:\n1:  ca6cd5870e ! 1:  bbce4f6440 t5300: modernize test path checks in t5300\n    @@ Metadata\n      ## Commit message ##\n         t5300: modernize test path checks in t5300\n\n    -    Improves test t5300-pack-object by converting old-style\n    -    path checks to use the `test_path_is_file` helper function.\n    +    Replace `test -f` commands with `test_path_is_file`, because\n    +    it makes debugging a failing test easier by reporting what\n    +    expectation was not met.\n\n         Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n\n--\n2.56.0.116.g6de20f6092.dirty\n\n\n"},{"id":"556814","messageId":"xmqq33to2w1p.fsf@gitster.g","threadId":"66646","inReplyTo":"20261029120210.3722-1-ogundipesolataiwo12@gmail.com","subject":"Re: [PATCH v3] t5300: modernize test path checks in t5300","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-29T18:36:50Z","receivedAt":"2026-10-29T18:36:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com> writes:\n\n> Replace `test -f` commands with `test_path_is_file`, because\n> it makes debugging a failing test easier by reporting what\n> expectation was not met.\n>\n> Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>\n> ---\n> Changes in v3:\n> - Rephrase patch summary to state how the use of `test_path_is_file`\n> \timproves the debugging of failing tests.\n>\n>  t/t5300-pack-object.sh | 10 +++++-----\n>  1 file changed, 5 insertions(+), 5 deletions(-)\n\nWill queue.  Thanks.\n\n"}]}