{"thread":{"id":"66613","subject":"[Outreachy PATCH] t2104: avoid suppressing git's exit code","startedAt":"2026-10-21T03:37:23Z","lastAt":"2026-10-23T17:56:15Z","messageCount":4,"participants":["Cynthia Uche","Patrick Steinhardt","Priestess","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"555647","messageId":"20261021033723.5265-1-herroyalpriestess@gmail.com","threadId":"66613","inReplyTo":null,"subject":"[Outreachy PATCH] t2104: avoid suppressing git's exit code","fromName":"Cynthia Uche","fromEmail":"herroyalpriestess@gmail.com","sentAt":"2026-10-21T03:37:23Z","receivedAt":"2026-10-21T03:37:23Z","isPatch":true,"sender":{"key":"herroyalpriestess@gmail.com","avatar":null},"body":"The exit code of the upstream command in a pipeline is lost, so a\ncrash in 'git ls-files' would go unnoticed. Write the output to a\nfile and compare that instead.\n\nSigned-off-by: Cynthia Uche <herroyalpriestess@gmail.com>\n---\n t/t2104-update-index-skip-worktree.sh | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t2104-update-index-skip-worktree.sh b/t/t2104-update-index-skip-worktree.sh\nindex 7a0778ed98..68a4339e24 100755\n--- a/t/t2104-update-index-skip-worktree.sh\n+++ b/t/t2104-update-index-skip-worktree.sh\n@@ -34,7 +34,8 @@ test_expect_success 'setup' '\n \tmkdir sub &&\n \ttouch ./1 ./2 sub/1 sub/2 &&\n \tgit add 1 2 sub/1 sub/2 &&\n-\tgit ls-files -t | test_cmp expect.full -\n+\tgit ls-files -t >actual &&\n+\ttest_cmp expect.full actual\n '\n \n test_expect_success 'index is at version 2' '\n@@ -43,7 +44,8 @@ test_expect_success 'index is at version 2' '\n \n test_expect_success 'update-index --skip-worktree' '\n \tgit update-index --skip-worktree 1 sub/1 &&\n-\tgit ls-files -t | test_cmp expect.skip -\n+\tgit ls-files -t >actual &&\n+\ttest_cmp expect.skip actual\n '\n \n test_expect_success 'index is at version 3 after having some skip-worktree entries' '\n@@ -51,12 +53,14 @@ test_expect_success 'index is at version 3 after having some skip-worktree entri\n '\n \n test_expect_success 'ls-files -t' '\n-\tgit ls-files -t | test_cmp expect.skip -\n+\tgit ls-files -t >actual &&\n+\ttest_cmp expect.skip actual\n '\n \n test_expect_success 'update-index --no-skip-worktree' '\n \tgit update-index --no-skip-worktree 1 sub/1 &&\n-\tgit ls-files -t | test_cmp expect.full -\n+\tgit ls-files -t >actual &&\n+\ttest_cmp expect.full actual\n '\n \n test_expect_success 'index version is back to 2 when there is no skip-worktree entry' '\n-- \n2.56.GIT\n\n\n"},{"id":"555692","messageId":"athxA6S50czDEUYj@pks.im","threadId":"66613","inReplyTo":"20261021033723.5265-1-herroyalpriestess@gmail.com","subject":"Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-21T08:00:03Z","receivedAt":"2026-10-21T08:00:03Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Wed, Oct 21, 2026 at 04:37:23AM +0100, Cynthia Uche wrote:\n> The exit code of the upstream command in a pipeline is lost, so a\n> crash in 'git ls-files' would go unnoticed. Write the output to a\n> file and compare that instead.\n\nMakes sense, and the patch looks obviously good to me, too. Thanks!\n\nPatrick\n\n"},{"id":"555809","messageId":"CAOcE0wLUZP+HG_X+C72U4vT4eYp=F9XK79aBdAiArYODxcYeAA@mail.gmail.com","threadId":"66613","inReplyTo":"athxA6S50czDEUYj@pks.im","subject":"Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code","fromName":"Priestess","fromEmail":"herroyalpriestess@gmail.com","sentAt":"2026-10-22T01:22:43Z","receivedAt":"2026-10-22T01:22:43Z","isPatch":true,"sender":{"key":"herroyalpriestess@gmail.com","avatar":null},"body":"> Makes sense, and the patch looks obviously good to me, too. Thanks!\n\nThanks for the review, Patrick.\n\n"},{"id":"556087","messageId":"xmqq8q3o7134.fsf@gitster.g","threadId":"66613","inReplyTo":"CAOcE0wLUZP+HG_X+C72U4vT4eYp=F9XK79aBdAiArYODxcYeAA@mail.gmail.com","subject":"Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-23T17:56:15Z","receivedAt":"2026-10-23T17:56:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Priestess <herroyalpriestess@gmail.com> writes:\n\n>> Makes sense, and the patch looks obviously good to me, too. Thanks!\n>\n> Thanks for the review, Patrick.\n\nThanks, both.  Queued.\n\n"}]}