{"thread":{"id":"66588","subject":"[PATCH v2] archive-zip: refactor 'path too long' error message to use Q_()","startedAt":"2026-10-19T15:27:24Z","lastAt":"2026-10-20T09:42:14Z","messageCount":2,"participants":["kerylefondji7@gmail.com","Phillip Wood"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"555428","messageId":"20261019152725.714-1-kerylefondji7@gmail.com","threadId":"66588","inReplyTo":"1a15474a4114ba8b","subject":"[PATCH v2] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-19T15:27:24Z","receivedAt":"2026-10-19T15:27:24Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji <kerylefondji7@gmail.com>\n\nReplace _() with Q_() in the 'path too long' error message. Although\npathlen is always greater than 0xffff when this error is hit, Q_() is\nrequired to support correct translation for languages that require\ndifferent plural forms depending on the count.\n\nSigned-off-by: Keryle Fondji <kerylefondji7@gmail.com>\n---\n archive-zip.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 6f73ca6d58..e4f8ef5a36 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,\n \t}\n \n \tif (pathlen > 0xffff) {\n-\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n+\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\", \"path too long (%d chars, SHA1: %s): %s\", pathlen),\n \t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n \t}\n \n-- \n2.53.0\n\n\n"},{"id":"555520","messageId":"e06ea3e7-7555-42b9-8ea5-65e9d3b25281@gmail.com","threadId":"66588","inReplyTo":"20261019152725.714-1-kerylefondji7@gmail.com","subject":"Re: [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2026-10-20T09:42:14Z","receivedAt":"2026-10-20T09:42:14Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Keryle\n\nOn 19/10/2026 16:27, kerylefondji7@gmail.com wrote:\n> From: Keryle Fondji <kerylefondji7@gmail.com>\n> > Replace _() with Q_() in the 'path too long' error message. Although\n> pathlen is always greater than 0xffff when this error is hit, Q_() is\n> required to support correct translation for languages that require\n> different plural forms depending on the count.\n\nThis is good. As Junio has pointed out the code needs wrapping now that it is using Q_().\n\nThanks\n\nPhillip\n\n> Signed-off-by: Keryle Fondji <kerylefondji7@gmail.com>\n> ---\n>   archive-zip.c | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> > diff --git a/archive-zip.c b/archive-zip.c\n> index 6f73ca6d58..e4f8ef5a36 100644\n> --- a/archive-zip.c\n> +++ b/archive-zip.c\n> @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,\n>   \t}\n>   >   \tif (pathlen > 0xffff) {\n> -\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n> +\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\", \"path too long (%d chars, SHA1: %s): %s\", pathlen),\n>   \t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n>   \t}\n>   "}]}