{"thread":{"id":"66583","subject":"[PATCH] archive-zip: refactor 'path too long' error message to use Q_()","startedAt":"2026-10-19T08:44:27Z","lastAt":"2026-10-26T17:33:10Z","messageCount":18,"participants":["kerylefondji7@gmail.com","Phillip Wood","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"555396","messageId":"20261019084427.1879-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":null,"subject":"[PATCH] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-19T08:44:27Z","receivedAt":"2026-10-19T08:44:27Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nThe error message used \"chars\" even when pathlen was 1.\n\nReplace _() with Q_() to handle both singular and plural forms\ncorrectly depending on the value of pathlen.\n\nSigned-off-by: Keryle Fondji \n---\n archive-zip.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 6f73ca6d58..e4f8ef5a36 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,\n \t}\n \n \tif (pathlen > 0xffff) {\n-\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n+\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\", \"path too long (%d chars, SHA1: %s): %s\", pathlen),\n \t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n \t}\n \n-- \n2.53.0\n\n\n"},{"id":"555415","messageId":"96187a3b-411c-42bd-8979-fb45006daa34@gmail.com","threadId":"66583","inReplyTo":"20261019084427.1879-1-kerylefondji7@gmail.com","subject":"Re: [PATCH] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2026-10-19T13:58:10Z","receivedAt":"2026-10-19T13:58:10Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Keryle\n\nOn 19/10/2026 09:44, kerylefondji7@gmail.com wrote:\n> From: Keryle Fondji \n> > The error message used \"chars\" even when pathlen was 1.\n\nLooking at the code below, pathlen has to be longer than 0xffff to trigger this message. However there can be more than one form of the plural string though. The gettext manual has the following example of the Polish translation of \"file\" for different numbers of files [1]\n\n\t1 plik\n\t2,3,4 pliki\n\t5-21 plików\n\t22-24 pliki\n\t25-31 plików\n\nso using Q_() is correct, but we should explain that it is to accommodate different plural forms, rather than because pathlen can be 1.\n\nThanks\n\nPhillip\n\n[1] https://www.gnu.org/software/gettext/manual/gettext.html#Additional-functions-for-plural-forms\n\n> > Replace _() with Q_() to handle both singular and plural forms\n> correctly depending on the value of pathlen.\n> > Signed-off-by: Keryle Fondji \n> ---\n> archive-zip.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> > diff --git a/archive-zip.c b/archive-zip.c\n> index 6f73ca6d58..e4f8ef5a36 100644\n> --- a/archive-zip.c\n> +++ b/archive-zip.c\n> @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,\n> \t}\n> > \tif (pathlen > 0xffff) {\n> -\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n> +\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\", \"path too long (%d chars, SHA1: %s): %s\", pathlen),\n> \t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n> \t}\n> "},{"id":"555466","messageId":"xmqqmrs92y4c.fsf@gitster.g","threadId":"66583","inReplyTo":"96187a3b-411c-42bd-8979-fb45006daa34@gmail.com","subject":"Re: [PATCH] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-19T21:12:35Z","receivedAt":"2026-10-19T21:12:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Phillip Wood writes:\n\n> Hi Keryle\n>\n> On 19/10/2026 09:44, kerylefondji7@gmail.com wrote:\n>> From: Keryle Fondji \n>> \n>> The error message used \"chars\" even when pathlen was 1.\n>\n> Looking at the code below, pathlen has to be longer than 0xffff to \n> trigger this message. However there can be more than one form of the \n> plural string though. The gettext manual has the following example of \n> the Polish translation of \"file\" for different numbers of files [1]\n>\n> \t1 plik\n> \t2,3,4 pliki\n> \t5-21 plików\n> \t22-24 pliki\n> \t25-31 plików\n>\n> so using Q_() is correct, but we should explain that it is to \n> accommodate different plural forms, rather than because pathlen can be 1.\n\nGood.\n\n>> Replace _() with Q_() to handle both singular and plural forms\n>> correctly depending on the value of pathlen.\n\nThis is written better.\n\n>> Signed-off-by: Keryle Fondji \n>> ---\n>> archive-zip.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/archive-zip.c b/archive-zip.c\n>> index 6f73ca6d58..e4f8ef5a36 100644\n>> --- a/archive-zip.c\n>> +++ b/archive-zip.c\n>> @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args,\n>> \t}\n>> \n>> \tif (pathlen > 0xffff) {\n>> -\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n>> +\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\", \"path too long (%d chars, SHA1: %s): %s\", pathlen),\n>> \t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n\nThis is overly long and must be line-wrapped.\n\n\n>> \t}\n>> \n\n"},{"id":"555523","messageId":"20261020102210.829-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"xmqqmrs92y4c.fsf@gitster.g","subject":"[PATCH v3 0/1] archive-zip: refactor 'path too long' error message","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-20T10:22:09Z","receivedAt":"2026-10-20T10:22:09Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nThis v3 addresses the review feedback by wrapping the overly long line\nin archive-zip.c, while keeping the proper use of Q_() for plural forms.\n\nKeryle Fondji (1):\n archive-zip: refactor 'path too long' error message to use Q_()\n\n archive-zip.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\n-- \n2.53.0\n\n\n"},{"id":"555524","messageId":"20261020102210.829-2-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"20261020102210.829-1-kerylefondji7@gmail.com","subject":"[PATCH v3 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-20T10:22:10Z","receivedAt":"2026-10-20T10:22:10Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nReplace _() with Q_() in the 'path too long' error message. Although\npathlen is always greater than 0xffff when this error is hit, Q_() is\nrequired to support correct translation for languages that require\ndifferent plural forms depending on the count.\n\nSigned-off-by: Keryle Fondji \n---\n archive-zip.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 6f73ca6d58..9df49ae160 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n \t}\n \n \tif (pathlen > 0xffff) {\n-\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n-\t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n+\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n+\t \"path too long (%d chars, SHA1: %s): %s\",\n+ pathlen),\n+\t (int)pathlen, oid_to_hex(oid), path);\n \t}\n \n \tif (S_ISDIR(mode) || S_ISGITLINK(mode)) {\n-- \n2.53.0\n\n\n"},{"id":"555555","messageId":"c578557c-c38e-48f3-ba61-fb2e0b139099@gmail.com","threadId":"66583","inReplyTo":"20261020102210.829-2-kerylefondji7@gmail.com","subject":"Re: [PATCH v3 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2026-10-20T15:05:06Z","receivedAt":"2026-10-20T15:05:06Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Keryle\n\nOn 20/10/2026 11:22, kerylefondji7@gmail.com wrote:\n> From: Keryle Fondji \n> > @@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n> \t}\n> > \tif (pathlen > 0xffff) {\n> -\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n> -\t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n> +\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n> +\t \"path too long (%d chars, SHA1: %s): %s\",\n> + pathlen),\n> +\t (int)pathlen, oid_to_hex(oid), path);\n\nThe indentation seems to have got messed up here, the level is wrong and it seems to contain spaces as well - if I apply the patch I see\n\nApplying: archive-zip: refactor 'path too long' error message to use Q_()\n.git/rebase-apply/patch:17: indent with spaces.\n pathlen),\nwarning: 1 line applied after fixing whitespace errors.\n\nThe code should be wrapped so that lines are not much longer than 80 characters and should be indented with tabs (possibly followed by a few spaces so that the arguments are aligned).\n\nThanks\n\nPhillip\n\n\n> \t}\n> > \tif (S_ISDIR(mode) || S_ISGITLINK(mode)) {\n\n\n"},{"id":"555599","messageId":"20261020183908.861-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"xmqqmrs92y4c.fsf@gitster.g","subject":"[PATCH v4 0/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-20T18:39:07Z","receivedAt":"2026-10-20T18:39:07Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nIn v4:\n- Fix code indentation by using tabs instead of spaces.\n- Align Q_() arguments with spaces under the open parenthesis.\n- Ensure line lengths remain strictly under 80 characters.\n\nThanks to reviewers for the feedback!\n\nKeryle Fondji (1):\n archive-zip: refactor 'path too long' error message to use Q_()\n\n archive-zip.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\n-- \n2.53.0\n\n\n"},{"id":"555600","messageId":"20261020183908.861-2-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"20261020183908.861-1-kerylefondji7@gmail.com","subject":"[PATCH v4 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-20T18:39:08Z","receivedAt":"2026-10-20T18:39:08Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nReplace _() with Q_() in the 'path too long' error message. Although\npathlen is always greater than 0xffff when this error is hit, Q_() is\nrequired to support correct translation for languages that require\ndifferent plural forms depending on the count.\n\nSigned-off-by: Keryle Fondji \n---\n archive-zip.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 6f73ca6d58..5ab3ba786f 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n \t}\n \n \tif (pathlen > 0xffff) {\n-\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n-\t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n+\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n+\t \"path too long (%d chars, SHA1: %s): %s\",\n+\t pathlen),\n+\t\t(int)pathlen, oid_to_hex(oid), path);\n \t}\n \n \tif (S_ISDIR(mode) || S_ISGITLINK(mode)) {\n-- \n2.53.0\n\n\n"},{"id":"555846","messageId":"20261022102831.656-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"xmqqmrs92y4c.fsf@gitster.g","subject":"Re: [PATCH v4] archive-zip: refactor 'path too long' error","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-22T10:28:30Z","receivedAt":"2026-10-22T10:28:30Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"Hi everyone,\n\nJust following up on this v4 patch to check if any further changes\nare needed.\n\nIf the patch looks good as is, please let me know if it would be\nokay for me to start working on another microproject in the meantime.\n\nThanks,\n\nKeryle\n\n"},{"id":"555869","messageId":"57e076d3-cfea-475d-b68d-a9f36746db35@gmail.com","threadId":"66583","inReplyTo":"20261020183908.861-2-kerylefondji7@gmail.com","subject":"Re: [PATCH v4 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2026-10-22T14:29:30Z","receivedAt":"2026-10-22T14:29:30Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Keryle\n\nOn 20/10/2026 19:39, kerylefondji7@gmail.com wrote:\n> > diff --git a/archive-zip.c b/archive-zip.c\n> index 6f73ca6d58..5ab3ba786f 100644\n> --- a/archive-zip.c\n> +++ b/archive-zip.c\n> @@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n> \t}\n> > \tif (pathlen > 0xffff) {\n> -\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n> -\t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n> +\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n> +\t \"path too long (%d chars, SHA1: %s): %s\",\n> +\t pathlen),\n> +\t\t(int)pathlen, oid_to_hex(oid), path);\n\nThe indentation is still messed up. If you look at the deleted lines you can see that\nwe've lost a level of indentation inside the \"if\" block and the function arguments no\nlonger line up. It should look like\n\n\tif (pathlen > 0xffff) {\n\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n\t\t\t\t\"path too long (%d chars, SHA1: %s): %s\",\n\t\t\t\tpathlen),\n\t\t\t (int)pathlen, oid_to_hex(oid), path);\n\t}\n\nThanks\n\nPhillip\n\n"},{"id":"555887","messageId":"xmqq1p9hhbue.fsf@gitster.g","threadId":"66583","inReplyTo":"57e076d3-cfea-475d-b68d-a9f36746db35@gmail.com","subject":"Re: [PATCH v4 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-22T17:41:29Z","receivedAt":"2026-10-22T17:41:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Phillip Wood writes:\n\n> Hi Keryle\n>\n> On 20/10/2026 19:39, kerylefondji7@gmail.com wrote:\n>> \n>> diff --git a/archive-zip.c b/archive-zip.c\n>> index 6f73ca6d58..5ab3ba786f 100644\n>> --- a/archive-zip.c\n>> +++ b/archive-zip.c\n>> @@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n>> \t}\n>> \n>> \tif (pathlen > 0xffff) {\n>> -\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n>> -\t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n>> +\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n>> +\t \"path too long (%d chars, SHA1: %s): %s\",\n>> +\t pathlen),\n>> +\t\t(int)pathlen, oid_to_hex(oid), path);\n>\n> The indentation is still messed up. If you look at the deleted lines you can see that\n> we've lost a level of indentation inside the \"if\" block and the function arguments no\n> longer line up. It should look like\n>\n> \tif (pathlen > 0xffff) {\n> \t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n> \t\t\t\t\"path too long (%d chars, SHA1: %s): %s\",\n> \t\t\t\tpathlen),\n> \t\t\t (int)pathlen, oid_to_hex(oid), path);\n> \t}\n>\n> Thanks\n\nThanks. Just in case Keryle is reading the message in a terminal or\nwebmail app with variable width fonts, the easiest way to see what\nis wrong in the posted patch is to visit\n\n https://lore.kernel.org/git/57e076d3-cfea-475d-b68d-a9f36746db35@gmail.com/\n\nwhich should show the patch in fixed-width font and even uses real\ntab chars properly (so you can click-hold on the left end of a line\nand move your mouse right to highlight the indentation to tell the\ndifference between a run of spaces and a tab).\n\n"},{"id":"555995","messageId":"20261023120358.8061-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"xmqq1p9hhbue.fsf@gitster.g","subject":"[PATCH v5 0/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-23T12:03:57Z","receivedAt":"2026-10-23T12:03:57Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nThis v5 corrects the line alignment and indentation issues reported\nby Phillip Wood and Junio C Hamano:\n\n- Pure tabs are used for structural indentation on all primary lines.\n- Tabs combined with spaces are used for alignment on the continuation\n line ((int)pathlen...) to align arguments under the opening parenthesis.\n\nIn previous attempts, mixing tabs and spaces incorrectly caused formatting\nerrors, but this structure now matches the expected Git style.\n\nKeryle Fondji (1):\n archive-zip: refactor 'path too long' error message to use Q_()\n\n archive-zip.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\n-- \n2.53.0\n\n\n"},{"id":"555996","messageId":"20261023120358.8061-2-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"20261023120358.8061-1-kerylefondji7@gmail.com","subject":"[PATCH v5 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-23T12:03:58Z","receivedAt":"2026-10-23T12:03:58Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nReplace _() with Q_() in the 'path too long' error message. Although\npathlen is always greater than 0xffff when this error is hit, Q_() is\nrequired to support correct translation for languages that require\ndifferent plural forms depending on the count.\n\nSigned-off-by: Keryle Fondji \n---\n archive-zip.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 5ab3ba786f..160efd878f 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -328,10 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n \t}\n \n \tif (pathlen > 0xffff) {\n-\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n-\t \"path too long (%d chars, SHA1: %s): %s\",\n-\t pathlen),\n-\t\t(int)pathlen, oid_to_hex(oid), path);\n+\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n+\t\t\t\t\"path too long (%d chars, SHA1: %s): %s\",\n+\t\t\t\tpathlen),\n+\t\t\t (int)pathlen, oid_to_hex(oid), path);\n \t}\n \n \tif (S_ISDIR(mode) || S_ISGITLINK(mode)) {\n-- \n2.53.0\n\n\n"},{"id":"556060","messageId":"8b75a831-f8b7-4e8d-9dbf-0f7fca5e7bc7@gmail.com","threadId":"66583","inReplyTo":"20261023120358.8061-2-kerylefondji7@gmail.com","subject":"Re: [PATCH v5 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2026-10-23T15:09:59Z","receivedAt":"2026-10-23T15:09:59Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Keryle\n\nOn 23/10/2026 13:03, kerylefondji7@gmail.com wrote:\n> > diff --git a/archive-zip.c b/archive-zip.c\n> index 5ab3ba786f..160efd878f 100644\n> --- a/archive-zip.c\n> +++ b/archive-zip.c\n> @@ -328,10 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n> \t}\n> > \tif (pathlen > 0xffff) {\n> -\t return error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n> -\t \"path too long (%d chars, SHA1: %s): %s\",\n> -\t pathlen),\n> -\t\t(int)pathlen, oid_to_hex(oid), path);\n> +\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n> +\t\t\t\t\"path too long (%d chars, SHA1: %s): %s\",\n> +\t\t\t\tpathlen),\n> +\t\t\t (int)pathlen, oid_to_hex(oid), path);\n\nThe indentation looks good, but this does not apply to master. When you get feedback about a patch, you should send an amended patch that applies to master, not a fix that applies on top of the patch you previously sent. If a patch series contains more than one patch, you can use \"git rebase -i\" to prepare the new version. If there is a single patch like this series you can use \"git commit --amend\".\n\nThanks\n\nPhillip\n\n\n"},{"id":"556113","messageId":"20261023213813.3318-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"xmqq1p9hhbue.fsf@gitster.g","subject":"[PATCH v6 0/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-23T21:38:12Z","receivedAt":"2026-10-23T21:38:12Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\nThis v6 addresses the feedback from Phillip Wood regarding commit\nstructure and patch applicability.\n\nIn previous attempts (like v5), the diff showed 4 deletions and 4\ninsertions because it was compared against prior iteration\nattempts. Since this v6 is flattened into a single clean commit\napplied directly on top of master, the diff naturally shows 2\ndeletions (-) (removing the original master lines) and 4\ninsertions (+) (adding the complete Q_() structure with correct\ntab/space alignments).\n\nSummary of changes in v6:\n- Rebased as a single commit directly on top of master.\n- Maintained the exact indentation approved in v5.\n- Cleaned up unrelated modifications from the working directory.\n\nThanks again to Phillip Wood and Junio C Hamano for their guidance\n\nKeryle Fondji (1):\n archive-zip: refactor 'path too long' error message to use Q_()\n\n archive-zip.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\n-- \n2.53.0\n\n\n"},{"id":"556114","messageId":"20261023213813.3318-2-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"20261023213813.3318-1-kerylefondji7@gmail.com","subject":"[PATCH v6 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-23T21:38:13Z","receivedAt":"2026-10-23T21:38:13Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"From: Keryle Fondji \n\n---\n archive-zip.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 6f73ca6d58..160efd878f 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,\n \t}\n \n \tif (pathlen > 0xffff) {\n-\t\treturn error(_(\"path too long (%d chars, SHA1: %s): %s\"),\n-\t\t\t\t(int)pathlen, oid_to_hex(oid), path);\n+\t\treturn error(Q_(\"path too long (%d char, SHA1: %s): %s\",\n+\t\t\t\t\"path too long (%d chars, SHA1: %s): %s\",\n+\t\t\t\tpathlen),\n+\t\t\t (int)pathlen, oid_to_hex(oid), path);\n \t}\n \n \tif (S_ISDIR(mode) || S_ISGITLINK(mode)) {\n-- \n2.53.0\n\n\n"},{"id":"556377","messageId":"20261026172456.561-1-kerylefondji7@gmail.com","threadId":"66583","inReplyTo":"xmqq1p9hhbue.fsf@gitster.g","subject":"Re: [PATCH v6 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"","fromEmail":"kerylefondji7@gmail.com","sentAt":"2026-10-26T17:24:56Z","receivedAt":"2026-10-26T17:24:56Z","isPatch":true,"sender":{"key":"kerylefondji7@gmail.com","avatar":null},"body":"Hi everyone,\n\nJust a gentle follow-up on this v6 patch. I have rebased the commit directly on top of master as suggested by Phillip, ensuring a clean single-commit structure and proper indentation.\n\nPlease let me know if this version looks good to you or if any further adjustments are needed.\n\nThank you for your time and guidance!\n\nBest regards,\nKeryle\n\n"},{"id":"556379","messageId":"xmqqtsm8qsdl.fsf@gitster.g","threadId":"66583","inReplyTo":"20261026172456.561-1-kerylefondji7@gmail.com","subject":"Re: [PATCH v6 1/1] archive-zip: refactor 'path too long' error message to use Q_()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-26T17:33:10Z","receivedAt":"2026-10-26T17:33:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"kerylefondji7@gmail.com writes:\n\n> Hi everyone,\n>\n> Just a gentle follow-up on this v6 patch. I have rebased the commit directly on top of master as suggested by Phillip, ensuring a clean single-commit structure and proper indentation.\n>\n> Please let me know if this version looks good to you or if any further adjustments are needed.\n>\n> Thank you for your time and guidance!\n>\n> Best regards,\n> Keryle\n\nIt is not so friendly to send a reply to v4's review when the one\nyou want people to take a look at is v6, though.\n\nAccording to Documentation/SubmittingPatches\n\n https://lore.kernel.org/git/20261023213813.3318-2-kerylefondji7@gmail.com/\n\nis not ready. No commit log message to explain and justify the\nchanges, and it is not signed-off. The shape of the submission\nlooked nicer in v5 iteration in this regard.\n\n"}]}