{"thread":{"id":"66529","subject":"[Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","startedAt":"2026-10-14T08:12:09Z","lastAt":"2026-10-26T18:10:53Z","messageCount":7,"participants":["Okhuomon Ajayi","Usman Akinyemi","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"554963","messageId":"20261014081209.61966-1-okhuomonajayi54@gmail.com","threadId":"66529","inReplyTo":null,"subject":"[Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Okhuomon Ajayi","fromEmail":"okhuomonajayi54@gmail.com","sentAt":"2026-10-14T08:12:09Z","receivedAt":"2026-10-14T08:12:09Z","isPatch":true,"sender":{"key":"okhuomonajayi54@gmail.com","avatar":null},"body":"Since 84325f0730 (merge,diff: remove the_repository check before\nprefetching blobs, 2026-02-21), diffcore-break.c no longer references\nthe_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.\n\nWithout this, new use of the_repository in this file would fail to\ncompile.\n\nSigned-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>\n---\n diffcore-break.c | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/diffcore-break.c b/diffcore-break.c\nindex b5bcc956cc..71d0e48beb 100644\n--- a/diffcore-break.c\n+++ b/diffcore-break.c\n@@ -2,8 +2,6 @@\n  * Copyright (C) 2005 Junio C Hamano\n  */\n \n-#define USE_THE_REPOSITORY_VARIABLE\n-\n #include \"git-compat-util.h\"\n #include \"diffcore.h\"\n #include \"hash.h\"\n-- \n2.54.0\n\n\n"},{"id":"554993","messageId":"CAPSxiM8xEA5zAUb_Wd0M0=PGD44XeS7=NX0vsdMcyid8-EOV+g@mail.gmail.com","threadId":"66529","inReplyTo":"20261014081209.61966-1-okhuomonajayi54@gmail.com","subject":"Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-14T10:24:58Z","receivedAt":"2026-10-14T10:24:58Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":">\n> Since 84325f0730 (merge,diff: remove the_repository check before\n> prefetching blobs, 2026-02-21), diffcore-break.c no longer references\n> the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.\nGood finding.\n>\n> Without this, new use of the_repository in this file would fail to\n> compile.\nI do not understand this statement.\n>\n> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>\n> ---\n>  diffcore-break.c | 2 --\n>  1 file changed, 2 deletions(-)\n\n"},{"id":"555003","messageId":"CAFpMFfBVSaGSoFfw9pfOcDWMKnLwnpMSyT51Nu7f-ZXE2NyxZA@mail.gmail.com","threadId":"66529","inReplyTo":"CAPSxiM8xEA5zAUb_Wd0M0=PGD44XeS7=NX0vsdMcyid8-EOV+g@mail.gmail.com","subject":"Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Okhuomon Ajayi","fromEmail":"okhuomonajayi54@gmail.com","sentAt":"2026-10-14T10:57:11Z","receivedAt":"2026-10-14T10:57:11Z","isPatch":true,"sender":{"key":"okhuomonajayi54@gmail.com","avatar":null},"body":"On Wed, Oct 14, 2026 at 11:25 AM Usman Akinyemi\n<usmanakinyemi202@gmail.com> wrote:\n\n> > Without this, new use of the_repository in this file would fail to\n> > compile.\n> I do not understand this statement.\n\n\nThanks for the review.\nI meant that since the USE_THE_REPOSITORY_VARIABLE has been removed, any\nfuture use of  the_repository without adding the\nUSE_THE_REPOSITORY_VARIABLE macro would fail to compile.\nI see that my statement above is not clear, I would modify the\nwordings and send in a v2.\n\n"},{"id":"555007","messageId":"CAPSxiM8NTdJo8TeSYNis20F0JNkTDwXn0hu_ukMkz0uQrsJW+w@mail.gmail.com","threadId":"66529","inReplyTo":"CAFpMFfBVSaGSoFfw9pfOcDWMKnLwnpMSyT51Nu7f-ZXE2NyxZA@mail.gmail.com","subject":"Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2026-10-14T11:10:50Z","receivedAt":"2026-10-14T11:10:50Z","isPatch":true,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":">\n> Thanks for the review.\n> I meant that since the USE_THE_REPOSITORY_VARIABLE has been removed, any\n> future use of  the_repository without adding the\n> USE_THE_REPOSITORY_VARIABLE macro would fail to compile.\n> I see that my statement above is not clear, I would modify the\n> wordings and send in a v2.\nYou do not need to add that. That is literally like explaining if and\nelse statements\nin the commit message. It is not needed.\n\nThanks.\n\n"},{"id":"555008","messageId":"CAFpMFfB57cWn5WWjeRwKEDsAOSfs18HD99mZanKED0_YL6yVyw@mail.gmail.com","threadId":"66529","inReplyTo":"CAPSxiM8NTdJo8TeSYNis20F0JNkTDwXn0hu_ukMkz0uQrsJW+w@mail.gmail.com","subject":"Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Okhuomon Ajayi","fromEmail":"okhuomonajayi54@gmail.com","sentAt":"2026-10-14T11:12:52Z","receivedAt":"2026-10-14T11:12:52Z","isPatch":true,"sender":{"key":"okhuomonajayi54@gmail.com","avatar":null},"body":"On Wed, Oct 14, 2026 at 12:11 PM Usman Akinyemi\n<usmanakinyemi202@gmail.com> wrote:\n> > Thanks for the review.\n> > I meant that since the USE_THE_REPOSITORY_VARIABLE has been removed, any\n> > future use of  the_repository without adding the\n> > USE_THE_REPOSITORY_VARIABLE macro would fail to compile.\n> > I see that my statement above is not clear, I would modify the\n> > wordings and send in a v2.\n> You do not need to add that. That is literally like explaining if and\n> else statements\n> in the commit message. It is not needed.\n>\n> Thanks.\n\nYeah, i would take it out of the commit message in my v2\nThanks\n\n"},{"id":"555013","messageId":"20261014114904.85300-1-okhuomonajayi54@gmail.com","threadId":"66529","inReplyTo":"20261014081209.61966-1-okhuomonajayi54@gmail.com","subject":"[Outreachy PATCH v2] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Okhuomon Ajayi","fromEmail":"okhuomonajayi54@gmail.com","sentAt":"2026-10-14T11:49:04Z","receivedAt":"2026-10-14T11:49:04Z","isPatch":true,"sender":{"key":"okhuomonajayi54@gmail.com","avatar":null},"body":"Since 84325f0730 (merge,diff: remove the_repository check before\nprefetching blobs, 2026-02-21), diffcore-break.c no longer references\nthe_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.\n\nSigned-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>\n---\nChanges since v1:\n- Removed the last paragraph of the commit message, as suggested by\n  Usman. No code was changed.\n\n diffcore-break.c | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/diffcore-break.c b/diffcore-break.c\nindex b5bcc956cc..71d0e48beb 100644\n--- a/diffcore-break.c\n+++ b/diffcore-break.c\n@@ -2,8 +2,6 @@\n  * Copyright (C) 2005 Junio C Hamano\n  */\n \n-#define USE_THE_REPOSITORY_VARIABLE\n-\n #include \"git-compat-util.h\"\n #include \"diffcore.h\"\n #include \"hash.h\"\n-- \n2.54.0\n\n\n"},{"id":"556387","messageId":"xmqqbj8gqqmq.fsf@gitster.g","threadId":"66529","inReplyTo":"20261014114904.85300-1-okhuomonajayi54@gmail.com","subject":"Re: [Outreachy PATCH v2] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-26T18:10:53Z","receivedAt":"2026-10-26T18:10:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:\n\n> Since 84325f0730 (merge,diff: remove the_repository check before\n> prefetching blobs, 2026-02-21), diffcore-break.c no longer references\n> the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.\n>\n> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>\n> ---\n> Changes since v1:\n> - Removed the last paragraph of the commit message, as suggested by\n>   Usman. No code was changed.\n\nThanks for writing and reviewing.  Will queue.\n\n>\n>  diffcore-break.c | 2 --\n>  1 file changed, 2 deletions(-)\n>\n> diff --git a/diffcore-break.c b/diffcore-break.c\n> index b5bcc956cc..71d0e48beb 100644\n> --- a/diffcore-break.c\n> +++ b/diffcore-break.c\n> @@ -2,8 +2,6 @@\n>   * Copyright (C) 2005 Junio C Hamano\n>   */\n>  \n> -#define USE_THE_REPOSITORY_VARIABLE\n> -\n>  #include \"git-compat-util.h\"\n>  #include \"diffcore.h\"\n>  #include \"hash.h\"\n\n"}]}