{"thread":{"id":"66471","subject":"[PATCH] t0450: use test_path_is_file and test_path_is_missing","startedAt":"2026-10-06T10:14:58Z","lastAt":"2026-10-06T12:23:55Z","messageCount":2,"participants":["Muhammed Dilshad A","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"554262","messageId":"20261006101458.604775-1-dilsheddilu123@gmail.com","threadId":"66471","inReplyTo":null,"subject":"[PATCH] t0450: use test_path_is_file and test_path_is_missing","fromName":"Muhammed Dilshad A","fromEmail":"dilsheddilu123@gmail.com","sentAt":"2026-10-06T10:14:58Z","receivedAt":"2026-10-06T10:14:58Z","isPatch":true,"sender":{"key":"dilsheddilu123@gmail.com","avatar":null},"body":"Replace raw 'test -f' and '! test -f' assertions with the test helper\nfunctions 'test_path_is_file' and 'test_path_is_missing' to provide\ndiagnostic output when an assertion fails.\n\nSigned-off-by: Muhammed Dilshad A <dilsheddilu123@gmail.com>\n---\n t/t0450-txt-doc-vs-help.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0450-txt-doc-vs-help.sh b/t/t0450-txt-doc-vs-help.sh\nindex 55c0fb3cb7..a2da2b0192 100755\n--- a/t/t0450-txt-doc-vs-help.sh\n+++ b/t/t0450-txt-doc-vs-help.sh\n@@ -116,13 +116,13 @@ do\n \tif grep -q \"^$builtin$\" \"$TEST_DIRECTORY\"/t0450/adoc-missing\n \tthen\n \t\ttest_expect_success \"$builtin appropriately marked as not having .adoc\" '\n-\t\t\t! test -f \"$adoc\"\n+\t\t\ttest_path_is_missing \"$adoc\"\n \t\t'\n \telse\n \t\ttest_set_prereq \"$preq\"\n \n \t\ttest_expect_success \"$builtin appropriately marked as having .adoc\" '\n-\t\t\ttest -f \"$adoc\"\n+\t\t\ttest_path_is_file \"$adoc\"\n \t\t'\n \tfi\n \n-- \n2.55.0\n\n\n"},{"id":"554274","messageId":"asToW_aXYGCg0xuv@pks.im","threadId":"66471","inReplyTo":"20261006101458.604775-1-dilsheddilu123@gmail.com","subject":"Re: [PATCH] t0450: use test_path_is_file and test_path_is_missing","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-06T12:23:55Z","receivedAt":"2026-10-06T12:23:55Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Oct 06, 2026 at 03:44:58PM +0530, Muhammed Dilshad A wrote:\n> Replace raw 'test -f' and '! test -f' assertions with the test helper\n> functions 'test_path_is_file' and 'test_path_is_missing' to provide\n> diagnostic output when an assertion fails.\n> \n> Signed-off-by: Muhammed Dilshad A <dilsheddilu123@gmail.com>\n\nGood commit message, pinpointing exactly why we even bother to do this\nchange.\n\n> diff --git a/t/t0450-txt-doc-vs-help.sh b/t/t0450-txt-doc-vs-help.sh\n> index 55c0fb3cb7..a2da2b0192 100755\n> --- a/t/t0450-txt-doc-vs-help.sh\n> +++ b/t/t0450-txt-doc-vs-help.sh\n> @@ -116,13 +116,13 @@ do\n>  \tif grep -q \"^$builtin$\" \"$TEST_DIRECTORY\"/t0450/adoc-missing\n>  \tthen\n>  \t\ttest_expect_success \"$builtin appropriately marked as not having .adoc\" '\n> -\t\t\t! test -f \"$adoc\"\n> +\t\t\ttest_path_is_missing \"$adoc\"\n>  \t\t'\n>  \telse\n>  \t\ttest_set_prereq \"$preq\"\n>  \n>  \t\ttest_expect_success \"$builtin appropriately marked as having .adoc\" '\n> -\t\t\ttest -f \"$adoc\"\n> +\t\t\ttest_path_is_file \"$adoc\"\n>  \t\t'\n>  \tfi\n\nAnd the change looks obviously good to me, as well. Thanks!\n\nPatrick\n\n"}]}