{"thread":{"id":"66463","subject":"[PATCH] builtin/repo: rename \"references.format\" to \"references.storageFormat\"","startedAt":"2026-10-05T10:15:08Z","lastAt":"2026-10-06T05:53:27Z","messageCount":3,"participants":["Patrick Steinhardt","Karthik Nayak"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"554162","messageId":"20261005-pks-repo-ref-storage-format-v1-1-819a181572a9@pks.im","threadId":"66463","inReplyTo":null,"subject":"[PATCH] builtin/repo: rename \"references.format\" to \"references.storageFormat\"","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-05T10:14:55Z","receivedAt":"2026-10-05T10:15:08Z","isPatch":true,"body":"As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01)\nwe have adapt all sites that used to say \"reference format\" to instead\nsay \"reference storage format\".\n\nOne missed spot though was in git-repo(1), where we still print the\n\"references.format\" key. Fix that oversight by renaming the key to\n\"references.storageFormat\".\n\nSigned-off-by: Patrick Steinhardt <ps@pks.im>\n---\nHi,\n\nthis is a follow-up on 2f28db44d5 (Merge branch 'ps/ref-storage-format',\n2026-10-01), where I missed this one place. I noticed that only today\nwhile working on the object storage format extension.\n\nThanks!\n\nPatrick\n---\n Documentation/git-repo.adoc |  6 +++---\n builtin/repo.c              |  2 +-\n t/t1900-repo-info.sh        | 12 ++++++------\n 3 files changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc\nindex ed7d80c690..5af454e8ca 100644\n--- a/Documentation/git-repo.adoc\n+++ b/Documentation/git-repo.adoc\n@@ -119,7 +119,7 @@ values that they return:\n `path.gitdir.relative`::\n \tThe path to the Git repository directory relative to the current working directory.\n \n-`references.format`::\n+`references.storageFormat`::\n \tThe reference storage format. The valid values are:\n +\n include::ref-storage-format.adoc[]\n@@ -127,10 +127,10 @@ include::ref-storage-format.adoc[]\n EXAMPLES\n --------\n \n-* Retrieves the reference format of the current repository:\n+* Retrieves the reference storage format of the current repository:\n +\n ------------\n-git repo info references.format\n+git repo info references.storageFormat\n ------------\n +\n \ndiff --git a/builtin/repo.c b/builtin/repo.c\nindex 84e012f83f..15267e8d54 100644\n--- a/builtin/repo.c\n+++ b/builtin/repo.c\n@@ -137,7 +137,7 @@ static const struct repo_info_field repo_info_field[] = {\n \t{ \"path.commondir.relative\", get_path_commondir_relative },\n \t{ \"path.gitdir.absolute\", get_path_gitdir_absolute },\n \t{ \"path.gitdir.relative\", get_path_gitdir_relative },\n-\t{ \"references.format\", get_references_format },\n+\t{ \"references.storageFormat\", get_references_format },\n };\n \n static int repo_info_field_cmp(const void *va, const void *vb)\ndiff --git a/t/t1900-repo-info.sh b/t/t1900-repo-info.sh\nindex d115d2d9f9..ee84f33229 100755\n--- a/t/t1900-repo-info.sh\n+++ b/t/t1900-repo-info.sh\n@@ -39,10 +39,10 @@ test_repo_info () {\n }\n \n test_repo_info 'ref format files is retrieved correctly' \\\n-\t'git init --ref-storage-format=files' 'format-files' 'references.format' 'files'\n+\t'git init --ref-storage-format=files' 'format-files' 'references.storageFormat' 'files'\n \n test_repo_info 'ref format reftable is retrieved correctly' \\\n-\t'git init --ref-storage-format=reftable' 'format-reftable' 'references.format' 'reftable'\n+\t'git init --ref-storage-format=reftable' 'format-reftable' 'references.storageFormat' 'reftable'\n \n test_repo_info 'bare repository = false is retrieved correctly' \\\n \t'git init' 'nonbare' 'layout.bare' 'false'\n@@ -72,11 +72,11 @@ test_repo_info 'object.format = sha256 is retrieved correctly' \\\n test_expect_success 'values returned in order requested' '\n \tcat >expect <<-\\EOF &&\n \tlayout.bare=false\n-\treferences.format=files\n+\treferences.storageFormat=files\n \tlayout.bare=false\n \tEOF\n \tgit init --ref-storage-format=files ordered &&\n-\tgit -C ordered repo info layout.bare references.format layout.bare >actual &&\n+\tgit -C ordered repo info layout.bare references.storageFormat layout.bare >actual &&\n \ttest_cmp expect actual\n '\n \n@@ -87,8 +87,8 @@ test_expect_success 'git-repo-info fails if an invalid key is requested' '\n '\n \n test_expect_success 'git-repo-info outputs data even if there is an invalid field' '\n-\techo \"references.format=$(test_detect_ref_format)\" >expect &&\n-\ttest_must_fail git repo info foo references.format bar >actual &&\n+\techo \"references.storageFormat=$(test_detect_ref_format)\" >expect &&\n+\ttest_must_fail git repo info foo references.storageFormat bar >actual &&\n \ttest_cmp expect actual\n '\n \n\n---\nbase-commit: 8103b446517e0c44e67561b9d0ccce56efa60a71\nchange-id: 20261005-pks-repo-ref-storage-format-9ea2c5528970\n\n"},{"id":"554186","messageId":"CAOLa=ZTNNY_XuixqZ96TK0zFfDpWvxSupxVGOnH1VGXK4KF_0w@mail.gmail.com","threadId":"66463","inReplyTo":"20261005-pks-repo-ref-storage-format-v1-1-819a181572a9@pks.im","subject":"Re: [PATCH] builtin/repo: rename \"references.format\" to \"references.storageFormat\"","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2026-10-05T15:11:19Z","receivedAt":"2026-10-05T15:11:19Z","isPatch":true,"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01)\n> we have adapt all sites that used to say \"reference format\" to instead\n> say \"reference storage format\".\n>\n> One missed spot though was in git-repo(1), where we still print the\n> \"references.format\" key. Fix that oversight by renaming the key to\n> \"references.storageFormat\".\n\nThe patch looks good, but this does break backward compatibility. But\nsince the command it marked as experimental, this should be okay.\n\n[snip]\n"},{"id":"554236","messageId":"asSM12B35oka08Nu@pks.im","threadId":"66463","inReplyTo":"CAOLa=ZTNNY_XuixqZ96TK0zFfDpWvxSupxVGOnH1VGXK4KF_0w@mail.gmail.com","subject":"Re: [PATCH] builtin/repo: rename \"references.format\" to \"references.storageFormat\"","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-06T05:53:27Z","receivedAt":"2026-10-06T05:53:27Z","isPatch":true,"body":"On Mon, Oct 05, 2026 at 03:11:19PM +0000, Karthik Nayak wrote:\n> Patrick Steinhardt <ps@pks.im> writes:\n> \n> > As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01)\n> > we have adapt all sites that used to say \"reference format\" to instead\n> > say \"reference storage format\".\n> >\n> > One missed spot though was in git-repo(1), where we still print the\n> > \"references.format\" key. Fix that oversight by renaming the key to\n> > \"references.storageFormat\".\n> \n> The patch looks good, but this does break backward compatibility. But\n> since the command it marked as experimental, this should be okay.\n\nRight, I should've probably mentioned this as part of the commit\nmessage. We could for a while carry both keys of course. But given that\nit's marked as experimental I think it's okay to break the format and\ndrop the old key.\n\nThanks!\n\nPatrick\n\n"}]}