{"thread":{"id":"66384","subject":"[PATCH] ci: fix unit tests not running on windows","startedAt":"2026-09-24T13:09:27Z","lastAt":"2026-09-24T14:14:07Z","messageCount":2,"participants":["Karthik Nayak","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"553179","messageId":"20260924-785-unit-tests-don-t-run-on-windows-v1-1-223cd2e4df43@gmail.com","threadId":"66384","inReplyTo":null,"subject":"[PATCH] ci: fix unit tests not running on windows","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2026-09-24T13:09:18Z","receivedAt":"2026-09-24T13:09:27Z","isPatch":true,"body":"Since 3141df7ec4 (ci: don't skip smallest test slice in GitLab,\n2026-02-19) both our CI workflows at GitLab and GitHub use one-indexed\nslices to run windows tests. Modify the check for running unit tests on\nWindows to also be one-indexed as otherwise, the unit tests are never\nrun.\n\nSigned-off-by: Karthik Nayak <karthik.188@gmail.com>\n---\nThis is based on top of 2d486439fe (ci: fix unit tests not running on\nwindows, 2026-09-17), with Johannes's cargo fixes [1] merged in.\n\n[1]: pull.2233.git.1789819933.gitgitgadget@gmail.com\n---\n ci/run-test-slice.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/ci/run-test-slice.sh b/ci/run-test-slice.sh\nindex ff948e397f..d0063efc42 100755\n--- a/ci/run-test-slice.sh\n+++ b/ci/run-test-slice.sh\n@@ -10,8 +10,8 @@ TESTS=$(cd t && ./helper/test-tool path-utils slice-tests \"$1\" \"$2\" t[0-9]*.sh)\n group \"Run tests\" make --quiet -C t T=\"$(echo \"$TESTS\" | tr '\\n' ' ')\" ||\n handle_failed_tests\n \n-# We only have one unit test at the moment, so run it in the first slice\n-if [ \"$1\" == \"0\" ] ; then\n+# We only have one unit test at the moment, so run it in the first slice.\n+if [ \"$1\" == \"1\" ] ; then\n \tgroup \"Run unit tests\" make --quiet -C t unit-tests-test-tool\n fi\n \n\n---\nbase-commit: 42f706c773b555dd34b9b913e9acb0cac617b1f0\nchange-id: 20260917-785-unit-tests-don-t-run-on-windows-7831eeb33371\n\n\nThanks\n- Karthik\n\n"},{"id":"553191","messageId":"arUwKpju14AVHOIy@pks.im","threadId":"66384","inReplyTo":"20260924-785-unit-tests-don-t-run-on-windows-v1-1-223cd2e4df43@gmail.com","subject":"Re: [PATCH] ci: fix unit tests not running on windows","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-09-24T14:14:02Z","receivedAt":"2026-09-24T14:14:07Z","isPatch":true,"body":"On Thu, Sep 24, 2026 at 03:09:18PM +0200, Karthik Nayak wrote:\n> Since 3141df7ec4 (ci: don't skip smallest test slice in GitLab,\n> 2026-02-19) both our CI workflows at GitLab and GitHub use one-indexed\n> slices to run windows tests. Modify the check for running unit tests on\n> Windows to also be one-indexed as otherwise, the unit tests are never\n> run.\n\nOh, that's something that I missed indeed. At least we've still been\nrunning unit tests via Meson :)\n\n> diff --git a/ci/run-test-slice.sh b/ci/run-test-slice.sh\n> index ff948e397f..d0063efc42 100755\n> --- a/ci/run-test-slice.sh\n> +++ b/ci/run-test-slice.sh\n> @@ -10,8 +10,8 @@ TESTS=$(cd t && ./helper/test-tool path-utils slice-tests \"$1\" \"$2\" t[0-9]*.sh)\n>  group \"Run tests\" make --quiet -C t T=\"$(echo \"$TESTS\" | tr '\\n' ' ')\" ||\n>  handle_failed_tests\n>  \n> -# We only have one unit test at the moment, so run it in the first slice\n> -if [ \"$1\" == \"0\" ] ; then\n> +# We only have one unit test at the moment, so run it in the first slice.\n> +if [ \"$1\" == \"1\" ] ; then\n>  \tgroup \"Run unit tests\" make --quiet -C t unit-tests-test-tool\n>  fi\n\nThe diff looks good to me, thanks!\n\nPatrick\n"}]}