# Re: [PATCH] exec_cmd: RUNTIME_PREFIX on OpenBSD systems 3 messages from 2026-09-21 to 2026-09-22. Participants: Chris Torek, Johannes Sixt. Thread: https://gitlist.dev/t/66360 ## Chris Torek, 2026-09-21 13:00 Subject: Re: [PATCH] exec_cmd: RUNTIME_PREFIX on OpenBSD systems Message-ID: In-Reply-To: <1789994808-30642-mlmmj-3f9f948b@vger.kernel.org> ``` [Ugh, somehow plain text mode got turned off, re-sending] On Wed, Sep 16, 2026 at 8:41 PM Brad Smith wrote: > > @@ -209,6 +229,10 @@ static int git_get_exec_path(struct strbuf *buf, const char *argv0) > * after the first successful method. > */ > if ( > +#ifdef HAVE_GETEXECPATH > + git_get_exec_path_getexecpath(buf) && > +#endif /* HAVE_GETEXECPATH */ > + > #ifdef HAVE_BSD_KERN_PROC_SYSCTL > git_get_exec_path_bsd_sysctl(buf) && > #endif /* HAVE_BSD_KERN_PROC_SYSCTL */ > -- > 2.55.0 Sort of a minor nit, but given this code construct, there should probably be instructions saying to define only one of these. Chris ``` ## Johannes Sixt, 2026-09-21 16:43 Subject: Re: [PATCH] exec_cmd: RUNTIME_PREFIX on OpenBSD systems Message-ID: <9d1ac51b-9969-49a1-a911-7669872d28c4@kdbg.org> In-Reply-To: ``` Am 21.09.26 um 15:00 schrieb Chris Torek: > [Ugh, somehow plain text mode got turned off, re-sending] > > On Wed, Sep 16, 2026 at 8:41 PM Brad Smith wrote: >> >> @@ -209,6 +229,10 @@ static int git_get_exec_path(struct strbuf *buf, const char *argv0) >> * after the first successful method. >> */ >> if ( >> +#ifdef HAVE_GETEXECPATH >> + git_get_exec_path_getexecpath(buf) && >> +#endif /* HAVE_GETEXECPATH */ >> + >> #ifdef HAVE_BSD_KERN_PROC_SYSCTL >> git_get_exec_path_bsd_sysctl(buf) && >> #endif /* HAVE_BSD_KERN_PROC_SYSCTL */ >> -- >> 2.55.0 > > Sort of a minor nit, but given this code construct, there should probably be > instructions saying to define only one of these. This caught me too. But notice that the calls are chained by && so that the first successful call determines the outcome. -- Hannes ``` ## Chris Torek, 2026-09-22 01:17 Subject: Re: [PATCH] exec_cmd: RUNTIME_PREFIX on OpenBSD systems Message-ID: In-Reply-To: <9d1ac51b-9969-49a1-a911-7669872d28c4@kdbg.org> ``` On Mon, Sep 21, 2026 at 9:43 AM Johannes Sixt wrote: [re the multiple get exec path call sequence] > This caught me too. But notice that the calls are chained by && so that > the first successful call determines the outcome. I noticed the &&'s but I somehow thought that successful return was nonzero instead of zero. (It didn't help when gmail went a little wonky on me, either, hence the accidental rejected HTML email) Chris ```