{"thread":{"id":"66317","subject":"[PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them","startedAt":"2026-09-12T14:38:05Z","lastAt":"2026-10-27T10:45:14Z","messageCount":29,"participants":["Harald Nordgren via GitGitGadget","Junio C Hamano","Patrick Steinhardt","Harald Nordgren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"552622","messageId":"pull.2403.git.git.1789223882471.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":null,"subject":"[PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-09-12T14:38:02Z","receivedAt":"2026-09-12T14:38:05Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"From: Harald Nordgren <haraldnordgren@gmail.com>\n\nperforce, git-lfs, and JGit test git's own interop code, not anything\nplatform-specific, so installing them once on ubuntu-* (all three)\nand macos-* (perforce) is enough coverage. debian, i386/ubuntu,\nalpine, fedora and almalinux never install them, yet the presence\ncheck at the end of the script warned on all of them anyway.\n\nScope each check to the platforms that attempt the install, so a\nwarning means one actually failed.\n\nSigned-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n---\n    ci: only warn about perforce/git-lfs/JGit on platforms that need them\n    \n    Only warn about a missing perforce/git-lfs/JGit install on the platforms\n    that actually need and attempt them (ubuntu-*, plus macOS for perforce),\n    since every other platform never installs them and was warning\n    regardless.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2403%2FHaraldNordgren%2Fci-scope-optional-tool-warnings-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2403/HaraldNordgren/ci-scope-optional-tool-warnings-v1\nPull-Request: https://github.com/git/git/pull/2403\n\n ci/install-dependencies.sh | 54 ++++++++++++++++++++++----------------\n 1 file changed, 31 insertions(+), 23 deletions(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex 2f61fbb07c..a68cec64b4 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -171,30 +171,38 @@ Documentation)\n \t;;\n esac\n \n-if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n-\tp4d -V\n-\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n-\tp4 -V\n-else\n-\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n-fi\n+case \"$distro\" in\n+ubuntu-*|macos-*)\n+\tif type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n+\tthen\n+\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\t\tp4d -V\n+\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\t\tp4 -V\n+\telse\n+\t\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n+\tfi\n+\t;;\n+esac\n \n-if type git-lfs >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n-\tgit-lfs version\n-else\n-\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n-fi\n+case \"$distro\" in\n+ubuntu-*)\n+\tif type git-lfs >/dev/null 2>&1\n+\tthen\n+\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n+\t\tgit-lfs version\n+\telse\n+\t\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n+\tfi\n \n-if type jgit >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n-\tjgit version\n-else\n-\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n-fi\n+\tif type jgit >/dev/null 2>&1\n+\tthen\n+\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n+\t\tjgit version\n+\telse\n+\t\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n+\tfi\n+\t;;\n+esac\n \n end_group \"Install dependencies\"\n\nbase-commit: 47ce80527c56f462cb97db4ca8125342204d3783\n-- \ngitgitgadget\n"},{"id":"553311","messageId":"xmqq1pahupca.fsf@gitster.g","threadId":"66317","inReplyTo":"pull.2403.git.git.1789223882471.gitgitgadget@gmail.com","subject":"Re: [PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-09-25T19:02:13Z","receivedAt":"2026-09-25T19:02:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Harald Nordgren via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Harald Nordgren <haraldnordgren@gmail.com>\n>\n> perforce, git-lfs, and JGit test git's own interop code, not anything\n> platform-specific, so installing them once on ubuntu-* (all three)\n> and macos-* (perforce) is enough coverage. debian, i386/ubuntu,\n> alpine, fedora and almalinux never install them, yet the presence\n> check at the end of the script warned on all of them anyway.\n>\n> Scope each check to the platforms that attempt the install, so a\n> warning means one actually failed.\n>\n> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n> ---\n>     ci: only warn about perforce/git-lfs/JGit on platforms that need them\n>     \n>     Only warn about a missing perforce/git-lfs/JGit install on the platforms\n>     that actually need and attempt them (ubuntu-*, plus macOS for perforce),\n>     since every other platform never installs them and was warning\n>     regardless.\n\nIt is curious that nobody seems to have looked at this patch, as my\ncursory look suggests it would be a no brainer to check correctness\nof this under the assumption that nothing will change externally.\n\nThe maintenance to keep this in sync with what exactly are tested in\neach platforms will be made more costly with this change, but I do\nnot know by how much.  If somebody wants to start testing p4 on a\ndifferent platform, for example, as I think t98xx will just punt\nwithout failing if p4 is not available, it will probably be a while\nuntil they eventually notice that their test do not run due to lack\nof p4 and then they have to add their platform to the logic added by\nthis patch.  I think jgit is also the same; silent success when JGIT\nprerequisite is not met.  But if they are motivated enough to add\ntests, they will eventually notice when the tests they wanted to run\nwere not running, so it is a reasonably low risk.  If somebody wants\nto drop testing jgit on a platform, we may still install jgit even\nthough we do not run tests that require jgit, which may take longer\nfor us to notice, but the result is just as bad at most as the state\nwithout this change, so overall I think it makes sense.\n\nAny volunteers to offer a second pair of eyes?\n\nThanks.\n\n\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2403%2FHaraldNordgren%2Fci-scope-optional-tool-warnings-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2403/HaraldNordgren/ci-scope-optional-tool-warnings-v1\n> Pull-Request: https://github.com/git/git/pull/2403\n>\n>  ci/install-dependencies.sh | 54 ++++++++++++++++++++++----------------\n>  1 file changed, 31 insertions(+), 23 deletions(-)\n>\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index 2f61fbb07c..a68cec64b4 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -171,30 +171,38 @@ Documentation)\n>  \t;;\n>  esac\n>  \n> -if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n> -then\n> -\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> -\tp4d -V\n> -\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> -\tp4 -V\n> -else\n> -\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n> -fi\n> +case \"$distro\" in\n> +ubuntu-*|macos-*)\n> +\tif type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n> +\tthen\n> +\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> +\t\tp4d -V\n> +\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> +\t\tp4 -V\n> +\telse\n> +\t\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n> +\tfi\n> +\t;;\n> +esac\n>  \n> -if type git-lfs >/dev/null 2>&1\n> -then\n> -\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n> -\tgit-lfs version\n> -else\n> -\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n> -fi\n> +case \"$distro\" in\n> +ubuntu-*)\n> +\tif type git-lfs >/dev/null 2>&1\n> +\tthen\n> +\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n> +\t\tgit-lfs version\n> +\telse\n> +\t\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n> +\tfi\n>  \n> -if type jgit >/dev/null 2>&1\n> -then\n> -\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n> -\tjgit version\n> -else\n> -\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n> -fi\n> +\tif type jgit >/dev/null 2>&1\n> +\tthen\n> +\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n> +\t\tjgit version\n> +\telse\n> +\t\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n> +\tfi\n> +\t;;\n> +esac\n>  \n>  end_group \"Install dependencies\"\n>\n> base-commit: 47ce80527c56f462cb97db4ca8125342204d3783\n"},{"id":"553456","messageId":"arpeDzeXlnZRwj30@pks.im","threadId":"66317","inReplyTo":"pull.2403.git.git.1789223882471.gitgitgadget@gmail.com","subject":"Re: [PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-09-28T12:31:11Z","receivedAt":"2026-09-28T12:31:17Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Sep 12, 2026 at 02:38:02PM +0000, Harald Nordgren via GitGitGadget wrote:\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index 2f61fbb07c..a68cec64b4 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -171,30 +171,38 @@ Documentation)\n>  \t;;\n>  esac\n>  \n> -if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n> -then\n> -\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> -\tp4d -V\n> -\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> -\tp4 -V\n> -else\n> -\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n> -fi\n> +case \"$distro\" in\n> +ubuntu-*|macos-*)\n> +\tif type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n> +\tthen\n> +\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> +\t\tp4d -V\n> +\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> +\t\tp4 -V\n> +\telse\n> +\t\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n> +\tfi\n> +\t;;\n> +esac\n>  \n> -if type git-lfs >/dev/null 2>&1\n> -then\n> -\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n> -\tgit-lfs version\n> -else\n> -\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n> -fi\n> +case \"$distro\" in\n> +ubuntu-*)\n> +\tif type git-lfs >/dev/null 2>&1\n> +\tthen\n> +\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n> +\t\tgit-lfs version\n> +\telse\n> +\t\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n> +\tfi\n>  \n> -if type jgit >/dev/null 2>&1\n> -then\n> -\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n> -\tjgit version\n> -else\n> -\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n> -fi\n> +\tif type jgit >/dev/null 2>&1\n> +\tthen\n> +\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n> +\t\tjgit version\n> +\telse\n> +\t\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n> +\tfi\n> +\t;;\n> +esac\n\nI wonder whether it makes sense to have these warnings in the first\nplace.\n\nPart of the reason why we have these checks is that we allow the\ninstallation of these tools to fail, and if so we know to gracefully\ncontinue anyway. Tests will be skipped, and the pipeline will be green\nin such a case. But is that even a safe thing to do? I strongly doubt\nthat we'd start to notice such failures anytime soon, so it very much\ngives us a false sense of confidence.\n\nSo I'd suggest that instead of warning, we should make the whole build\nfail outright if we fail to install any of those tools. And once we do,\nthese warnings here become quite useless, because we know that the build\nwould fail on platforms where we expect the tools to be present. And on\nplatforms where we don't, the warning is pointless anyway.\n\nThanks!\n\nPatrick\n"},{"id":"553504","messageId":"CAHwyqnXJqABaN1JvfF7R0P9FbK1ptt66kaO98=sJDw-p3x=nXg@mail.gmail.com","threadId":"66317","inReplyTo":"arpeDzeXlnZRwj30@pks.im","subject":"Re: [PATCH] ci: only warn about perforce/git-lfs/JGit on platforms that need them","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-09-28T16:13:00Z","receivedAt":"2026-09-28T16:13:39Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"> I wonder whether it makes sense to have these warnings in the first\n> place.\n>\n> Part of the reason why we have these checks is that we allow the\n> installation of these tools to fail, and if so we know to gracefully\n> continue anyway. Tests will be skipped, and the pipeline will be green\n> in such a case. But is that even a safe thing to do? I strongly doubt\n> that we'd start to notice such failures anytime soon, so it very much\n> gives us a false sense of confidence.\n>\n> So I'd suggest that instead of warning, we should make the whole build\n> fail outright if we fail to install any of those tools. And once we do,\n> these warnings here become quite useless, because we know that the build\n> would fail on platforms where we expect the tools to be present. And on\n> platforms where we don't, the warning is pointless anyway.\n\nFine by me!\n\n\nHarald\n"},{"id":"556078","messageId":"pull.2403.v2.git.git.1792774249888.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.git.git.1789223882471.gitgitgadget@gmail.com","subject":"[PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-23T16:50:49Z","receivedAt":"2026-10-23T16:50:49Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"From: Harald Nordgren <haraldnordgren@gmail.com>\n\nA failed install of perforce, git-lfs, or JGit was silently\ntolerated. The corresponding tests would just skip and the build\nstayed green, so a broken download could go unnoticed indefinitely.\n\nFail the build immediately instead on the platforms that install\nthese tools. The presence checks and warnings at the end of the\nscript are gone too, since we already know by then that everything\ninstalled or the build wouldn't have gotten this far.\n\nSigned-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n---\n    ci: fail the build if perforce, git-lfs or JGit fail to install\n    \n    Fail the build if perforce, git-lfs or JGit fail to install on the\n    platforms that install them.\n    \n    Changes in v2:\n    \n     * Perforce, git-lfs, and JGit install failures now fail the build\n       instead of being silently swallowed. Removed the presence checks and\n       warnings at the end of the script, dead code once install failure is\n       fatal.\n     * Version output (p4d -V, git-lfs version, jgit version) moved inline\n       right after each successful install.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2403%2FHaraldNordgren%2Fci-scope-optional-tool-warnings-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2403/HaraldNordgren/ci-scope-optional-tool-warnings-v2\nPull-Request: https://github.com/git/git/pull/2403\n\nRange-diff vs v1:\n\n 1:  3ce51dc322 ! 1:  dde1b38567 ci: only warn about perforce/git-lfs/JGit on platforms that need them\n     @@ Metadata\n      Author: Harald Nordgren <haraldnordgren@gmail.com>\n      \n       ## Commit message ##\n     -    ci: only warn about perforce/git-lfs/JGit on platforms that need them\n     +    ci: fail the build if perforce, git-lfs, or JGit fail to install\n      \n     -    perforce, git-lfs, and JGit test git's own interop code, not anything\n     -    platform-specific, so installing them once on ubuntu-* (all three)\n     -    and macos-* (perforce) is enough coverage. debian, i386/ubuntu,\n     -    alpine, fedora and almalinux never install them, yet the presence\n     -    check at the end of the script warned on all of them anyway.\n     +    A failed install of perforce, git-lfs, or JGit was silently\n     +    tolerated. The corresponding tests would just skip and the build\n     +    stayed green, so a broken download could go unnoticed indefinitely.\n      \n     -    Scope each check to the platforms that attempt the install, so a\n     -    warning means one actually failed.\n     +    Fail the build immediately instead on the platforms that install\n     +    these tools. The presence checks and warnings at the end of the\n     +    script are gone too, since we already know by then that everything\n     +    installed or the build wouldn't have gotten this far.\n      \n          Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n      \n       ## ci/install-dependencies.sh ##\n     +@@ ci/install-dependencies.sh: ubuntu-*|i386/ubuntu-*|debian-*)\n     + \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n     + \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n     + \t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n     +-\t\t\trm -f \"$CUSTOM_PATH/p4\"\n     +-\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n     ++\t\t\techo >&2 \"error: could not install perforce\"\n     ++\t\t\texit 1\n     + \t\t}\n     ++\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n     ++\t\tp4d -V\n     ++\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n     ++\t\tp4 -V\n     + \n     + \t\twget --quiet \\\n     + \t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n     + \t\ttar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n     + \t\t\t-C \"$CUSTOM_PATH\" --strip-components=1 \\\n     + \t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n     +-\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n     +-\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n     ++\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n     ++\t\t\techo >&2 \"error: could not install git-lfs\"\n     ++\t\t\texit 1\n     ++\t\t}\n     ++\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n     ++\t\tgit-lfs version\n     + \n     + \t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n     +-\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n     +-\t\trm -f \"$CUSTOM_PATH/jgit\"\n     ++\t\tchmod a+x \"$CUSTOM_PATH/jgit\" || {\n     ++\t\t\techo >&2 \"error: could not install JGit\"\n     ++\t\t\texit 1\n     ++\t\t}\n     ++\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n     ++\t\tjgit version\n     + \t\t;;\n     + \tesac\n     + \t;;\n     +@@ ci/install-dependencies.sh: macos-*)\n     + \n     + \tmkdir -p \"$CUSTOM_PATH\"\n     + \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n     +-\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n     ++\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n     ++\t\techo >&2 \"error: could not install perforce\"\n     ++\t\texit 1\n     ++\t}\n     + \tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n     + \trm helix-core-server.tgz\n     ++\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n     ++\tp4d -V\n     ++\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n     ++\tp4 -V\n     + \n     + \tcase \"$jobname\" in\n     + \tosx-meson)\n      @@ ci/install-dependencies.sh: Documentation)\n       \t;;\n       esac\n     @@ ci/install-dependencies.sh: Documentation)\n      -else\n      -\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n      -fi\n     -+case \"$distro\" in\n     -+ubuntu-*|macos-*)\n     -+\tif type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n     -+\tthen\n     -+\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n     -+\t\tp4d -V\n     -+\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n     -+\t\tp4 -V\n     -+\telse\n     -+\t\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n     -+\tfi\n     -+\t;;\n     -+esac\n     - \n     +-\n      -if type git-lfs >/dev/null 2>&1\n      -then\n      -\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n     @@ ci/install-dependencies.sh: Documentation)\n      -else\n      -\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n      -fi\n     -+case \"$distro\" in\n     -+ubuntu-*)\n     -+\tif type git-lfs >/dev/null 2>&1\n     -+\tthen\n     -+\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n     -+\t\tgit-lfs version\n     -+\telse\n     -+\t\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n     -+\tfi\n     - \n     +-\n      -if type jgit >/dev/null 2>&1\n      -then\n      -\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n     @@ ci/install-dependencies.sh: Documentation)\n      -else\n      -\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n      -fi\n     -+\tif type jgit >/dev/null 2>&1\n     -+\tthen\n     -+\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n     -+\t\tjgit version\n     -+\telse\n     -+\t\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n     -+\tfi\n     -+\t;;\n     -+esac\n     - \n     +-\n       end_group \"Install dependencies\"\n\n\n ci/install-dependencies.sh | 59 +++++++++++++++++---------------------\n 1 file changed, 26 insertions(+), 33 deletions(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex d57dce5663..dad35db78b 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -95,21 +95,33 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n \t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n-\t\t\trm -f \"$CUSTOM_PATH/p4\"\n-\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n+\t\t\techo >&2 \"error: could not install perforce\"\n+\t\t\texit 1\n \t\t}\n+\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\t\tp4d -V\n+\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\t\tp4 -V\n \n \t\twget --quiet \\\n \t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n \t\ttar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n \t\t\t-C \"$CUSTOM_PATH\" --strip-components=1 \\\n \t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n-\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n-\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n+\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n+\t\t\techo >&2 \"error: could not install git-lfs\"\n+\t\t\texit 1\n+\t\t}\n+\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n+\t\tgit-lfs version\n \n \t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n-\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n-\t\trm -f \"$CUSTOM_PATH/jgit\"\n+\t\tchmod a+x \"$CUSTOM_PATH/jgit\" || {\n+\t\t\techo >&2 \"error: could not install JGit\"\n+\t\t\texit 1\n+\t\t}\n+\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n+\t\tjgit version\n \t\t;;\n \tesac\n \t;;\n@@ -121,9 +133,16 @@ macos-*)\n \n \tmkdir -p \"$CUSTOM_PATH\"\n \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n-\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n+\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n+\t\techo >&2 \"error: could not install perforce\"\n+\t\texit 1\n+\t}\n \tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n \trm helix-core-server.tgz\n+\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\tp4d -V\n+\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\tp4 -V\n \n \tcase \"$jobname\" in\n \tosx-meson)\n@@ -171,30 +190,4 @@ Documentation)\n \t;;\n esac\n \n-if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n-\tp4d -V\n-\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n-\tp4 -V\n-else\n-\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n-fi\n-\n-if type git-lfs >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n-\tgit-lfs version\n-else\n-\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n-fi\n-\n-if type jgit >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n-\tjgit version\n-else\n-\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n-fi\n-\n end_group \"Install dependencies\"\n\nbase-commit: 7e34d8174dcda3435d1404c9a30bef46afe6c13e\n-- \ngitgitgadget\n\n"},{"id":"556116","messageId":"xmqqa4o43x6n.fsf@gitster.g","threadId":"66317","inReplyTo":"pull.2403.v2.git.git.1792774249888.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-23T21:48:48Z","receivedAt":"2026-10-23T21:48:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Harald Nordgren via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Harald Nordgren <haraldnordgren@gmail.com>\n>\n> A failed install of perforce, git-lfs, or JGit was silently\n> tolerated. The corresponding tests would just skip and the build\n> stayed green, so a broken download could go unnoticed indefinitely.\n>\n> Fail the build immediately instead on the platforms that install\n> these tools. The presence checks and warnings at the end of the\n> script are gone too, since we already know by then that everything\n> installed or the build wouldn't have gotten this far.\n>\n> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n> ---\n> ...\n>  ci/install-dependencies.sh | 59 +++++++++++++++++---------------------\n>  1 file changed, 26 insertions(+), 33 deletions(-)\n>\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index d57dce5663..dad35db78b 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -95,21 +95,33 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n>  \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n>  \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n>  \t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n> -\t\t\trm -f \"$CUSTOM_PATH/p4\"\n> -\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n> +\t\t\techo >&2 \"error: could not install perforce\"\n> +\t\t\texit 1\n>  \t\t}\n\nWe used to attempt cleaning after ourselves before giving up (and\ncontinuing), but now we explicitly die and there is no need to\nremove the half-installed stuff, which makes sense.  The same\ncomment for lfs and jgit (omitted from quotes).\n\n> @@ -121,9 +133,16 @@ macos-*)\n>  \n>  \tmkdir -p \"$CUSTOM_PATH\"\n>  \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n> -\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> +\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n> +\t\techo >&2 \"error: could not install perforce\"\n> +\t\texit 1\n> +\t}\n>  \tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n>  \trm helix-core-server.tgz\n\nThe earlier one tried to make them executable, and failed when it\ncannot. I wonder you want to move \"|| { ... fail ... }\" below the\nxattr line for consistency, but the command line says \"we do not\ncare if we cannot remove the attribute and will keep going\", so it\ncannot be done without dropping \"|| true\" there.  Hmm...\n\n> +\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> +\tp4d -V\n> +\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> +\tp4 -V\n>  \n>  \tcase \"$jobname\" in\n>  \tosx-meson)\n> @@ -171,30 +190,4 @@ Documentation)\n>  \t;;\n>  esac\n>  \n> -if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n> -then\n> ...\n> -\tjgit version\n> -else\n> -\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n> -fi\n> -\n\nAnd it is very nice to see these all go, as we have done the\nreporting all very close to where they are installed.\n\n>  end_group \"Install dependencies\"\n>\n> base-commit: 7e34d8174dcda3435d1404c9a30bef46afe6c13e\n\n"},{"id":"556125","messageId":"CAHwyqnUmEx5ykHD03QTXeHwS8MiUnv9UEru0FBM5ixw-KDV4YA@mail.gmail.com","threadId":"66317","inReplyTo":"xmqqa4o43x6n.fsf@gitster.g","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-23T22:59:50Z","receivedAt":"2026-10-23T22:59:50Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"I interpret this as needing no further action now. Is that correct?\n\nThanks for looking at this!\n\n\nHarald\n\n"},{"id":"556126","messageId":"xmqqld7o2f18.fsf@gitster.g","threadId":"66317","inReplyTo":"CAHwyqnUmEx5ykHD03QTXeHwS8MiUnv9UEru0FBM5ixw-KDV4YA@mail.gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-23T23:06:11Z","receivedAt":"2026-10-23T23:06:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Harald Nordgren <haraldnordgren@gmail.com> writes:\n\n> I interpret this as needing no further action now. Is that correct?\n\nNot necessarily.  It merely means that I just didn't find anything\nwrong within the time I could allocate for this topic.  Somebody\nelse may want to give a real positive review to move it forward.\n\n\n"},{"id":"556253","messageId":"at79nEHLDrcoCgn_@pks.im","threadId":"66317","inReplyTo":"pull.2403.v2.git.git.1792774249888.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-26T07:13:32Z","receivedAt":"2026-10-26T07:13:32Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Fri, Oct 23, 2026 at 04:50:49PM +0000, Harald Nordgren via GitGitGadget wrote:\n>     Changes in v2:\n>     \n>      * Perforce, git-lfs, and JGit install failures now fail the build\n>        instead of being silently swallowed. Removed the presence checks and\n>        warnings at the end of the script, dead code once install failure is\n>        fatal.\n\nThanks for adapting!\n\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index d57dce5663..dad35db78b 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -95,21 +95,33 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n>  \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n>  \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n>  \t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n> -\t\t\trm -f \"$CUSTOM_PATH/p4\"\n> -\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n> +\t\t\techo >&2 \"error: could not install perforce\"\n> +\t\t\texit 1\n>  \t\t}\n> +\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> +\t\tp4d -V\n> +\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> +\t\tp4 -V\n\nOkay. I was wondering whether we'd even see these binaries or whether\nwe'd have to `\"${CUSTOM_PATH}\"/p4d -V` instead. But `$CUSTOM_PATH` gets\nset up in \"ci/lib.sh\" already, so there's no need for that.\n\n>  \t\twget --quiet \\\n>  \t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n>  \t\ttar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n>  \t\t\t-C \"$CUSTOM_PATH\" --strip-components=1 \\\n>  \t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n> -\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n> -\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n> +\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n> +\t\t\techo >&2 \"error: could not install git-lfs\"\n> +\t\t\texit 1\n> +\t\t}\n\nThis could all be a bit less convoluted if we had `set -e` in\n\"ci/lib.sh\". But that certainly is outside the scope of this patch\nseries, so meanwhile this looks good to me.\n\n> @@ -121,9 +133,16 @@ macos-*)\n>  \n>  \tmkdir -p \"$CUSTOM_PATH\"\n>  \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n> -\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> +\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n> +\t\techo >&2 \"error: could not install perforce\"\n> +\t\texit 1\n> +\t}\n>  \tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n\nThis line is a bit curious, it makes me wonder whether we want to\ntighten it as well now. Any reason why we wouldn't?\n\n>  \trm helix-core-server.tgz\n\nNit: this is inconsistent with git-lfs, where we also have the call to\nrm as part of the condition chain.\n\nThanks!\n\nPatrick\n\n"},{"id":"556263","messageId":"CAHwyqnVVCp9ovsHDtc0pHYrFvpmdJq74gyx9yf3+ZWkL+d=CVA@mail.gmail.com","threadId":"66317","inReplyTo":"at79nEHLDrcoCgn_@pks.im","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T07:38:10Z","receivedAt":"2026-10-26T07:38:10Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"> >               wget --quiet \\\n> >                    \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n> >               tar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n> >                       -C \"$CUSTOM_PATH\" --strip-components=1 \\\n> >                       \"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n> > -             rm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n> > -             rm -f \"$CUSTOM_PATH/git-lfs\"\n> > +             rm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n> > +                     echo >&2 \"error: could not install git-lfs\"\n> > +                     exit 1\n> > +             }\n>\n> This could all be a bit less convoluted if we had `set -e` in\n> \"ci/lib.sh\". But that certainly is outside the scope of this patch\n> series, so meanwhile this looks good to me.\n\nYeah, `set -e` is a gem of a command. Would be good to do later!\n\n> > @@ -121,9 +133,16 @@ macos-*)\n> >\n> >       mkdir -p \"$CUSTOM_PATH\"\n> >       wget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n> > -     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> > +     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n> > +             echo >&2 \"error: could not install perforce\"\n> > +             exit 1\n> > +     }\n> >       sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n>\n> This line is a bit curious, it makes me wonder whether we want to\n> tighten it as well now. Any reason why we wouldn't?\n\nI asked Claud about it and it said this, does it make sense?\n\n'wget/curl never set com.apple.quarantine in the first place (only\nSafari/Finder/AirDrop do, via the LaunchServices quarantine API), so\nxattr -d on these files always fails with \"No such xattr.\" Tightening\nit to fatal would break every macOS build, every time.'\n\n> >       rm helix-core-server.tgz\n>\n> Nit: this is inconsistent with git-lfs, where we also have the call to\n> rm as part of the condition chain.\n\nGood point!\n\n\n\nHarald\n\n"},{"id":"556264","messageId":"CAHwyqnVGpc5ro+TksGGv4sp_JT-_ntuQjuXfVPSaeW+BYu2Pbw@mail.gmail.com","threadId":"66317","inReplyTo":"CAHwyqnVVCp9ovsHDtc0pHYrFvpmdJq74gyx9yf3+ZWkL+d=CVA@mail.gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T07:41:45Z","receivedAt":"2026-10-26T07:41:45Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"> > >               wget --quiet \\\n> > >                    \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n> > >               tar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n> > >                       -C \"$CUSTOM_PATH\" --strip-components=1 \\\n> > >                       \"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n> > > -             rm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n> > > -             rm -f \"$CUSTOM_PATH/git-lfs\"\n> > > +             rm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n> > > +                     echo >&2 \"error: could not install git-lfs\"\n> > > +                     exit 1\n> > > +             }\n> >\n> > This could all be a bit less convoluted if we had `set -e` in\n> > \"ci/lib.sh\". But that certainly is outside the scope of this patch\n> > series, so meanwhile this looks good to me.\n>\n> Yeah, `set -e` is a gem of a command. Would be good to do later!\n\nBut wait, we already have it in \"ci/lib.sh\"!\n\n\nHarald\n\n"},{"id":"556268","messageId":"at8KIQPtBHXyLPyY@pks.im","threadId":"66317","inReplyTo":"CAHwyqnVVCp9ovsHDtc0pHYrFvpmdJq74gyx9yf3+ZWkL+d=CVA@mail.gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-26T08:06:57Z","receivedAt":"2026-10-26T08:06:57Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 26, 2026 at 09:38:10AM +0200, Harald Nordgren wrote:\n> > > @@ -121,9 +133,16 @@ macos-*)\n> > >\n> > >       mkdir -p \"$CUSTOM_PATH\"\n> > >       wget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n> > > -     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> > > +     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n> > > +             echo >&2 \"error: could not install perforce\"\n> > > +             exit 1\n> > > +     }\n> > >       sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n> >\n> > This line is a bit curious, it makes me wonder whether we want to\n> > tighten it as well now. Any reason why we wouldn't?\n> \n> I asked Claud about it and it said this, does it make sense?\n> \n> 'wget/curl never set com.apple.quarantine in the first place (only\n> Safari/Finder/AirDrop do, via the LaunchServices quarantine API), so\n> xattr -d on these files always fails with \"No such xattr.\" Tightening\n> it to fatal would break every macOS build, every time.'\n\nWell, if so we should be able to remove it without any detriment, right?\nMaybe that could be part of a preparatory patch.\n\nPatrick\n\n"},{"id":"556269","messageId":"at8KJi0eMEpN1NoO@pks.im","threadId":"66317","inReplyTo":"CAHwyqnVGpc5ro+TksGGv4sp_JT-_ntuQjuXfVPSaeW+BYu2Pbw@mail.gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-26T08:07:02Z","receivedAt":"2026-10-26T08:07:02Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 26, 2026 at 09:41:45AM +0200, Harald Nordgren wrote:\n> > > >               wget --quiet \\\n> > > >                    \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n> > > >               tar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n> > > >                       -C \"$CUSTOM_PATH\" --strip-components=1 \\\n> > > >                       \"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n> > > > -             rm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n> > > > -             rm -f \"$CUSTOM_PATH/git-lfs\"\n> > > > +             rm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n> > > > +                     echo >&2 \"error: could not install git-lfs\"\n> > > > +                     exit 1\n> > > > +             }\n> > >\n> > > This could all be a bit less convoluted if we had `set -e` in\n> > > \"ci/lib.sh\". But that certainly is outside the scope of this patch\n> > > series, so meanwhile this looks good to me.\n> >\n> > Yeah, `set -e` is a gem of a command. Would be good to do later!\n> \n> But wait, we already have it in \"ci/lib.sh\"!\n\nOh, I missed that!\n\nThe question then becomes whether the error message is worth it. In case\nwe see traces (`set -x`) I think it's somewhat pointless as you'd\ntrivially see the last failing command anyway, so you'd know why it has\nfailed.\n\nAnyway, this is all a bit of a tangent, I don't think there's a strong\nreason that this really must change.\n\nPatrick\n\n"},{"id":"556270","messageId":"CAHwyqnW=Vj-f6oMyKoGCkJp04Jz+qADoWgTYEv_VY8fWZKmRyg@mail.gmail.com","threadId":"66317","inReplyTo":"at8KJi0eMEpN1NoO@pks.im","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T08:08:42Z","receivedAt":"2026-10-26T08:08:42Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"> > > > This could all be a bit less convoluted if we had `set -e` in\n> > > > \"ci/lib.sh\". But that certainly is outside the scope of this patch\n> > > > series, so meanwhile this looks good to me.\n> > >\n> > > Yeah, `set -e` is a gem of a command. Would be good to do later!\n> >\n> > But wait, we already have it in \"ci/lib.sh\"!\n>\n> Oh, I missed that!\n>\n> The question then becomes whether the error message is worth it. In case\n> we see traces (`set -x`) I think it's somewhat pointless as you'd\n> trivially see the last failing command anyway, so you'd know why it has\n> failed.\n\nYes, probably.\n\n> Anyway, this is all a bit of a tangent, I don't think there's a strong\n> reason that this really must change.\n\nI'll take a look at what I can do without ballooning this topic.\n\n\nHarald\n\n"},{"id":"556272","messageId":"CAHwyqnUwSv4Pa1GT3rikOcho2MVYA7sRV7RpP_KXcSa-2dWrWQ@mail.gmail.com","threadId":"66317","inReplyTo":"at8KIQPtBHXyLPyY@pks.im","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T08:13:26Z","receivedAt":"2026-10-26T08:13:26Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"On Mon, Oct 26, 2026 at 10:07 AM Patrick Steinhardt <ps@pks.im> wrote:\n>\n> On Mon, Oct 26, 2026 at 09:38:10AM +0200, Harald Nordgren wrote:\n> > > > @@ -121,9 +133,16 @@ macos-*)\n> > > >\n> > > >       mkdir -p \"$CUSTOM_PATH\"\n> > > >       wget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n> > > > -     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> > > > +     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n> > > > +             echo >&2 \"error: could not install perforce\"\n> > > > +             exit 1\n> > > > +     }\n> > > >       sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n> > >\n> > > This line is a bit curious, it makes me wonder whether we want to\n> > > tighten it as well now. Any reason why we wouldn't?\n> >\n> > I asked Claud about it and it said this, does it make sense?\n> >\n> > 'wget/curl never set com.apple.quarantine in the first place (only\n> > Safari/Finder/AirDrop do, via the LaunchServices quarantine API), so\n> > xattr -d on these files always fails with \"No such xattr.\" Tightening\n> > it to fatal would break every macOS build, every time.'\n>\n> Well, if so we should be able to remove it without any detriment, right?\n> Maybe that could be part of a preparatory patch.\n\nBest way to find out is just to do it, I guess. I can include it in v3\nand then you can trigger a build on GitLab with it? I'll let GitHub CI\npass before pushing anything out.\n\n\nHarald\n\n"},{"id":"556285","messageId":"at8WTDeuv0s3iWI6@pks.im","threadId":"66317","inReplyTo":"CAHwyqnUwSv4Pa1GT3rikOcho2MVYA7sRV7RpP_KXcSa-2dWrWQ@mail.gmail.com","subject":"Re: [PATCH v2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-26T08:58:52Z","receivedAt":"2026-10-26T08:58:52Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 26, 2026 at 10:13:26AM +0200, Harald Nordgren wrote:\n> On Mon, Oct 26, 2026 at 10:07 AM Patrick Steinhardt <ps@pks.im> wrote:\n> >\n> > On Mon, Oct 26, 2026 at 09:38:10AM +0200, Harald Nordgren wrote:\n> > > > > @@ -121,9 +133,16 @@ macos-*)\n> > > > >\n> > > > >       mkdir -p \"$CUSTOM_PATH\"\n> > > > >       wget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n> > > > > -     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n> > > > > +     tar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n> > > > > +             echo >&2 \"error: could not install perforce\"\n> > > > > +             exit 1\n> > > > > +     }\n> > > > >       sudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n> > > >\n> > > > This line is a bit curious, it makes me wonder whether we want to\n> > > > tighten it as well now. Any reason why we wouldn't?\n> > >\n> > > I asked Claud about it and it said this, does it make sense?\n> > >\n> > > 'wget/curl never set com.apple.quarantine in the first place (only\n> > > Safari/Finder/AirDrop do, via the LaunchServices quarantine API), so\n> > > xattr -d on these files always fails with \"No such xattr.\" Tightening\n> > > it to fatal would break every macOS build, every time.'\n> >\n> > Well, if so we should be able to remove it without any detriment, right?\n> > Maybe that could be part of a preparatory patch.\n> \n> Best way to find out is just to do it, I guess. I can include it in v3\n> and then you can trigger a build on GitLab with it? I'll let GitHub CI\n> pass before pushing anything out.\n\nSounds good, thanks.\n\nPatrick\n\n"},{"id":"556296","messageId":"pull.2403.v3.git.git.1793008465.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.git.git.1789223882471.gitgitgadget@gmail.com","subject":"[PATCH v3 0/2] ci: fail the build if perforce, git-lfs or JGit fail to install","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-26T09:54:23Z","receivedAt":"2026-10-26T09:54:23Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"Fail the build when perforce, git-lfs, or JGit fail to install, and drop the\nwarnings that used to fire on every platform regardless of whether it even\nattempted the install.\n\nChanges in v3:\n\n * New prep commit drops the xattr -d com.apple.quarantine call for the\n   macOS perforce binaries, it's been a silent no-op since perforce's\n   install moved off Homebrew in 2022, confirmed wget downloads never carry\n   that attribute.\n * Drops the explicit echo \"error: ...\" / exit 1 blocks for perforce,\n   git-lfs, and JGit, relying on set -e (already active via ci/lib.sh) to\n   abort on the first failed install, matching how every other install step\n   in this file already works.\n\nChanges in v2:\n\n * Perforce, git-lfs, and JGit install failures now fail the build instead\n   of being silently swallowed. Removed the presence checks and warnings at\n   the end of the script, dead code once install failure is fatal.\n * Version output (p4d -V, git-lfs version, jgit version) moved inline right\n   after each successful install.\n\nHarald Nordgren (2):\n  ci: drop quarantine removal for macos perforce binaries\n  ci: fail the build if perforce, git-lfs, or JGit fail to install\n\n ci/install-dependencies.sh | 50 ++++++++++++--------------------------\n 1 file changed, 15 insertions(+), 35 deletions(-)\n\n\nbase-commit: 7e34d8174dcda3435d1404c9a30bef46afe6c13e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2403%2FHaraldNordgren%2Fci-scope-optional-tool-warnings-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2403/HaraldNordgren/ci-scope-optional-tool-warnings-v3\nPull-Request: https://github.com/git/git/pull/2403\n\nRange-diff vs v2:\n\n -:  ---------- > 1:  e85ce85d92 ci: drop quarantine removal for macos perforce binaries\n 1:  dde1b38567 ! 2:  a57cfbb2a5 ci: fail the build if perforce, git-lfs, or JGit fail to install\n     @@ Commit message\n      \n       ## ci/install-dependencies.sh ##\n      @@ ci/install-dependencies.sh: ubuntu-*|i386/ubuntu-*|debian-*)\n     + \t\twget --quiet --directory-prefix=\"$CUSTOM_PATH\" \\\n       \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n       \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n     - \t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n     +-\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n      -\t\t\trm -f \"$CUSTOM_PATH/p4\"\n      -\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n     -+\t\t\techo >&2 \"error: could not install perforce\"\n     -+\t\t\texit 1\n     - \t\t}\n     +-\t\t}\n     ++\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\"\n      +\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n      +\t\tp4d -V\n      +\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n     @@ ci/install-dependencies.sh: ubuntu-*|i386/ubuntu-*|debian-*)\n       \t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n      -\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n      -\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n     -+\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" || {\n     -+\t\t\techo >&2 \"error: could not install git-lfs\"\n     -+\t\t\texit 1\n     -+\t\t}\n     ++\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\"\n      +\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n      +\t\tgit-lfs version\n       \n       \t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n      -\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n      -\t\trm -f \"$CUSTOM_PATH/jgit\"\n     -+\t\tchmod a+x \"$CUSTOM_PATH/jgit\" || {\n     -+\t\t\techo >&2 \"error: could not install JGit\"\n     -+\t\t\texit 1\n     -+\t\t}\n     ++\t\tchmod a+x \"$CUSTOM_PATH/jgit\"\n      +\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n      +\t\tjgit version\n       \t\t;;\n       \tesac\n       \t;;\n      @@ ci/install-dependencies.sh: macos-*)\n     - \n     - \tmkdir -p \"$CUSTOM_PATH\"\n       \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n     --\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n     -+\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d || {\n     -+\t\techo >&2 \"error: could not install perforce\"\n     -+\t\texit 1\n     -+\t}\n     - \tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n     + \ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n       \trm helix-core-server.tgz\n      +\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n      +\tp4d -V\n\n-- \ngitgitgadget\n\n"},{"id":"556297","messageId":"e85ce85d921f5c847c4a370a5c56c98f2f20cee2.1793008465.git.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.v3.git.git.1793008465.gitgitgadget@gmail.com","subject":"[PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-26T09:54:24Z","receivedAt":"2026-10-26T09:54:24Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"From: Harald Nordgren <haraldnordgren@gmail.com>\n\nA file downloaded with wget never gets com.apple.quarantine set,\nonly Safari, Finder, and AirDrop apply that attribute through the\nLaunchServices quarantine API.\n\n5ed9fc3fc8 (ci: prevent `perforce` from being quarantined,\n2020-02-27) added this to stop p4d -V from hanging on a GUI\nconfirmation dialog that never comes on a CI box, back when perforce\nwas installed via Homebrew's --no-quarantine cask flag. When\n49af448197 (ci: reintroduce prevention from perforce being\nquarantined in macOS, 2022-05-12) replaced that with a plain wget and\ntar download, it kept an xattr -d call as a precaution while noting\nthat call already does nothing on GitHub Actions. It has been a\nsilent no-op ever since.\n\nSigned-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n---\n ci/install-dependencies.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex d57dce5663..203e8401cf 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -122,7 +122,6 @@ macos-*)\n \tmkdir -p \"$CUSTOM_PATH\"\n \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n \ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n-\tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n \trm helix-core-server.tgz\n \n \tcase \"$jobname\" in\n-- \ngitgitgadget\n\n\n"},{"id":"556298","messageId":"a57cfbb2a5c0f34e44595c3b688b18c760258685.1793008465.git.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.v3.git.git.1793008465.gitgitgadget@gmail.com","subject":"[PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-26T09:54:25Z","receivedAt":"2026-10-26T09:54:25Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"From: Harald Nordgren <haraldnordgren@gmail.com>\n\nA failed install of perforce, git-lfs, or JGit was silently\ntolerated. The corresponding tests would just skip and the build\nstayed green, so a broken download could go unnoticed indefinitely.\n\nFail the build immediately instead on the platforms that install\nthese tools. The presence checks and warnings at the end of the\nscript are gone too, since we already know by then that everything\ninstalled or the build wouldn't have gotten this far.\n\nSigned-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n---\n ci/install-dependencies.sh | 49 ++++++++++++--------------------------\n 1 file changed, 15 insertions(+), 34 deletions(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex 203e8401cf..7c3c6ad434 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -94,22 +94,25 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n \t\twget --quiet --directory-prefix=\"$CUSTOM_PATH\" \\\n \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n-\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n-\t\t\trm -f \"$CUSTOM_PATH/p4\"\n-\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n-\t\t}\n+\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\"\n+\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\t\tp4d -V\n+\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\t\tp4 -V\n \n \t\twget --quiet \\\n \t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n \t\ttar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n \t\t\t-C \"$CUSTOM_PATH\" --strip-components=1 \\\n \t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n-\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n-\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n+\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\"\n+\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n+\t\tgit-lfs version\n \n \t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n-\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n-\t\trm -f \"$CUSTOM_PATH/jgit\"\n+\t\tchmod a+x \"$CUSTOM_PATH/jgit\"\n+\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n+\t\tjgit version\n \t\t;;\n \tesac\n \t;;\n@@ -123,6 +126,10 @@ macos-*)\n \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n \ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n \trm helix-core-server.tgz\n+\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\tp4d -V\n+\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\tp4 -V\n \n \tcase \"$jobname\" in\n \tosx-meson)\n@@ -170,30 +177,4 @@ Documentation)\n \t;;\n esac\n \n-if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n-\tp4d -V\n-\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n-\tp4 -V\n-else\n-\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n-fi\n-\n-if type git-lfs >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n-\tgit-lfs version\n-else\n-\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n-fi\n-\n-if type jgit >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n-\tjgit version\n-else\n-\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n-fi\n-\n end_group \"Install dependencies\"\n-- \ngitgitgadget\n\n"},{"id":"556312","messageId":"at80okuHpoUjUYpQ@pks.im","threadId":"66317","inReplyTo":"a57cfbb2a5c0f34e44595c3b688b18c760258685.1793008465.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-26T11:08:18Z","receivedAt":"2026-10-26T11:08:18Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 26, 2026 at 09:54:25AM +0000, Harald Nordgren via GitGitGadget wrote:\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index 203e8401cf..7c3c6ad434 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -94,22 +94,25 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n>  \t\twget --quiet --directory-prefix=\"$CUSTOM_PATH\" \\\n>  \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n>  \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n> -\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n> -\t\t\trm -f \"$CUSTOM_PATH/p4\"\n> -\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n> -\t\t}\n> +\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\"\n> +\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> +\t\tp4d -V\n> +\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> +\t\tp4 -V\n\nIsn't the && chain completely useless now, both here and in the other\ncases? We let `set -e` do its thing, but we don't have any error\nhandling for the whole block anymore after we dropped the error message.\n\nPatrick\n\n"},{"id":"556313","messageId":"at80qOfTn5_YUY_f@pks.im","threadId":"66317","inReplyTo":"e85ce85d921f5c847c4a370a5c56c98f2f20cee2.1793008465.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-26T11:08:24Z","receivedAt":"2026-10-26T11:08:24Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 26, 2026 at 09:54:24AM +0000, Harald Nordgren via GitGitGadget wrote:\n> From: Harald Nordgren <haraldnordgren@gmail.com>\n> \n> A file downloaded with wget never gets com.apple.quarantine set,\n> only Safari, Finder, and AirDrop apply that attribute through the\n> LaunchServices quarantine API.\n\nThis is the explanation why we can remove the flag, but we haven't even\ntalked about the observation or what we want to do.\n\n> 5ed9fc3fc8 (ci: prevent `perforce` from being quarantined,\n> 2020-02-27) added this to stop p4d -V from hanging on a GUI\n\nNit: you start talking about \"this\" without even saying what \"this\" is.\n\n> confirmation dialog that never comes on a CI box, back when perforce\n> was installed via Homebrew's --no-quarantine cask flag. When\n> 49af448197 (ci: reintroduce prevention from perforce being\n> quarantined in macOS, 2022-05-12) replaced that with a plain wget and\n> tar download, it kept an xattr -d call as a precaution while noting\n> that call already does nothing on GitHub Actions. It has been a\n> silent no-op ever since.\n\nSo the question is what this does on GitLab CI. [1] will answer that\nquestion once the pipeline has succeeded.\n\nPatrick\n\n[1]: https://gitlab.com/gitlab-org/git/-/merge_requests/714\n\n"},{"id":"556328","messageId":"CAHwyqnXk=Q=M6mZtF9QW4mjtuVtKt2zjqnMm85OeYPEVf1aBsQ@mail.gmail.com","threadId":"66317","inReplyTo":"at80okuHpoUjUYpQ@pks.im","subject":"Re: [PATCH v3 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T12:17:36Z","receivedAt":"2026-10-26T12:17:36Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"On Mon, Oct 26, 2026 at 1:08 PM Patrick Steinhardt <ps@pks.im> wrote:\n>\n> On Mon, Oct 26, 2026 at 09:54:25AM +0000, Harald Nordgren via GitGitGadget wrote:\n> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> > index 203e8401cf..7c3c6ad434 100755\n> > --- a/ci/install-dependencies.sh\n> > +++ b/ci/install-dependencies.sh\n> > @@ -94,22 +94,25 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n> >               wget --quiet --directory-prefix=\"$CUSTOM_PATH\" \\\n> >                       \"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n> >                       \"$P4WHENCE/bin.linux26x86_64/p4\" &&\n> > -             chmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n> > -                     rm -f \"$CUSTOM_PATH/p4\"\n> > -                     rm -f \"$CUSTOM_PATH/p4d\"\n> > -             }\n> > +             chmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\"\n> > +             echo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n> > +             p4d -V\n> > +             echo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n> > +             p4 -V\n>\n> Isn't the && chain completely useless now, both here and in the other\n> cases? We let `set -e` do its thing, but we don't have any error\n> handling for the whole block anymore after we dropped the error message.\n\nThat's true! It would open up a lot of simplifications on the regular\ngit tests if we could drop '&&' there too :)\n\n\nHarald\n\n"},{"id":"556329","messageId":"CAHwyqnXC3UZStYB+hscXe9fXFqpicDD-SCMfKwxSk-agdw-pFw@mail.gmail.com","threadId":"66317","inReplyTo":"at80qOfTn5_YUY_f@pks.im","subject":"Re: [PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T12:18:19Z","receivedAt":"2026-10-26T12:18:19Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"> So the question is what this does on GitLab CI. [1] will answer that\n> question once the pipeline has succeeded.\n>\n> Patrick\n>\n> [1]: https://gitlab.com/gitlab-org/git/-/merge_requests/714\n\nSeems GitLab CI passed.\n\n\nHarald\n\n"},{"id":"556339","messageId":"CAHwyqnX2MdcKBLL5Z9Xb9XznKCkOLfztk5bM-OdkJuaOBF0LMQ@mail.gmail.com","threadId":"66317","inReplyTo":"at80qOfTn5_YUY_f@pks.im","subject":"Re: [PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries","fromName":"Harald Nordgren","fromEmail":"haraldnordgren@gmail.com","sentAt":"2026-10-26T12:49:00Z","receivedAt":"2026-10-26T12:49:00Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"> > A file downloaded with wget never gets com.apple.quarantine set,\n> > only Safari, Finder, and AirDrop apply that attribute through the\n> > LaunchServices quarantine API.\n>\n> This is the explanation why we can remove the flag, but we haven't even\n> talked about the observation or what we want to do.\n\nI'll take a look at that.\n\n> > 5ed9fc3fc8 (ci: prevent `perforce` from being quarantined,\n> > 2020-02-27) added this to stop p4d -V from hanging on a GUI\n>\n> Nit: you start talking about \"this\" without even saying what \"this\" is.\n\nOk.\n\n\nHarald\n\n"},{"id":"556371","messageId":"xmqqse1ss8q3.fsf@gitster.g","threadId":"66317","inReplyTo":"CAHwyqnX2MdcKBLL5Z9Xb9XznKCkOLfztk5bM-OdkJuaOBF0LMQ@mail.gmail.com","subject":"Re: [PATCH v3 1/2] ci: drop quarantine removal for macos perforce binaries","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-10-26T16:54:44Z","receivedAt":"2026-10-26T16:54:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Harald Nordgren <haraldnordgren@gmail.com> writes:\n\n>> > A file downloaded with wget never gets com.apple.quarantine set,\n>> > only Safari, Finder, and AirDrop apply that attribute through the\n>> > LaunchServices quarantine API.\n>>\n>> This is the explanation why we can remove the flag, but we haven't even\n>> talked about the observation or what we want to do.\n>\n> I'll take a look at that.\n>\n>> > 5ed9fc3fc8 (ci: prevent `perforce` from being quarantined,\n>> > 2020-02-27) added this to stop p4d -V from hanging on a GUI\n>>\n>> Nit: you start talking about \"this\" without even saying what \"this\" is.\n>\n> Ok.\n\nWill look forward to seeing this step updated.  Nevertheless, thanks\nfor finding why we can remove this line and making it into a\nseparate commit.\n\n\n"},{"id":"556452","messageId":"pull.2403.v4.git.git.1793089936.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.git.git.1789223882471.gitgitgadget@gmail.com","subject":"[PATCH v4 0/2] ci: fail the build if perforce, git-lfs or JGit fail to install","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-27T08:32:14Z","receivedAt":"2026-10-27T08:32:14Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"Fail the build when perforce, git-lfs, or JGit fail to install, and drop the\nwarnings that used to fire on every platform regardless of whether it even\nattempted the install.\n\nChanges in v4:\n\n * Drops the && chaining between the wget/tar/chmod install steps for\n   perforce, git-lfs, and JGit, since under set -e a failing command inside\n   an && chain is exempt from aborting the script unless it's the last one\n   in the chain, so the chain was silently letting an earlier failure fall\n   through instead of stopping the build.\n * Reworded the quarantine-removal commit to lead with the observation (the\n   call does nothing and can go) before the history, fixed a dangling \"this\"\n   reference, and added that the same holds on GitLab CI's macOS runners,\n   not just GitHub Actions.\n\nChanges in v3:\n\n * New prep commit drops the xattr -d com.apple.quarantine call for the\n   macOS perforce binaries, it's been a silent no-op since perforce's\n   install moved off Homebrew in 2022, confirmed wget downloads never carry\n   that attribute.\n * Drops the explicit echo \"error: ...\" / exit 1 blocks for perforce,\n   git-lfs, and JGit, relying on set -e (already active via ci/lib.sh) to\n   abort on the first failed install, matching how every other install step\n   in this file already works.\n\nChanges in v2:\n\n * Perforce, git-lfs, and JGit install failures now fail the build instead\n   of being silently swallowed. Removed the presence checks and warnings at\n   the end of the script, dead code once install failure is fatal.\n * Version output (p4d -V, git-lfs version, jgit version) moved inline right\n   after each successful install.\n\nHarald Nordgren (2):\n  ci: drop quarantine removal for macos perforce binaries\n  ci: fail the build if perforce, git-lfs, or JGit fail to install\n\n ci/install-dependencies.sh | 64 +++++++++++++-------------------------\n 1 file changed, 22 insertions(+), 42 deletions(-)\n\n\nbase-commit: 7e34d8174dcda3435d1404c9a30bef46afe6c13e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2403%2FHaraldNordgren%2Fci-scope-optional-tool-warnings-v4\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2403/HaraldNordgren/ci-scope-optional-tool-warnings-v4\nPull-Request: https://github.com/git/git/pull/2403\n\nRange-diff vs v3:\n\n 1:  e85ce85d92 ! 1:  c1ee3fcb7d ci: drop quarantine removal for macos perforce binaries\n     @@ Metadata\n       ## Commit message ##\n          ci: drop quarantine removal for macos perforce binaries\n      \n     -    A file downloaded with wget never gets com.apple.quarantine set,\n     -    only Safari, Finder, and AirDrop apply that attribute through the\n     -    LaunchServices quarantine API.\n     +    The xattr -d call that strips com.apple.quarantine from the macOS\n     +    perforce binaries has been doing nothing for years, and can simply\n     +    go.\n      \n          5ed9fc3fc8 (ci: prevent `perforce` from being quarantined,\n     -    2020-02-27) added this to stop p4d -V from hanging on a GUI\n     +    2020-02-27) added that call to stop p4d -V from hanging on a GUI\n          confirmation dialog that never comes on a CI box, back when perforce\n          was installed via Homebrew's --no-quarantine cask flag. When\n          49af448197 (ci: reintroduce prevention from perforce being\n     -    quarantined in macOS, 2022-05-12) replaced that with a plain wget and\n     -    tar download, it kept an xattr -d call as a precaution while noting\n     -    that call already does nothing on GitHub Actions. It has been a\n     -    silent no-op ever since.\n     +    quarantined in macOS, 2022-05-12) replaced that with a plain wget\n     +    and tar download, it kept the xattr -d call as a precaution, while\n     +    noting that it already does nothing on GitHub Actions.\n     +\n     +    A file downloaded with wget never gets com.apple.quarantine set in\n     +    the first place, only Safari, Finder, and AirDrop apply that\n     +    attribute through the LaunchServices quarantine API. The same holds\n     +    on GitLab CI's macOS runners, so the call has been a silent no-op\n     +    everywhere since 2022.\n      \n          Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n      \n 2:  a57cfbb2a5 ! 2:  c6dda879aa ci: fail the build if perforce, git-lfs, or JGit fail to install\n     @@ Commit message\n      \n       ## ci/install-dependencies.sh ##\n      @@ ci/install-dependencies.sh: ubuntu-*|i386/ubuntu-*|debian-*)\n     + \n       \t\twget --quiet --directory-prefix=\"$CUSTOM_PATH\" \\\n       \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n     - \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n     +-\t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n      -\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n      -\t\t\trm -f \"$CUSTOM_PATH/p4\"\n      -\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n      -\t\t}\n     ++\t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\"\n      +\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\"\n      +\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n      +\t\tp4d -V\n     @@ ci/install-dependencies.sh: ubuntu-*|i386/ubuntu-*|debian-*)\n      +\t\tp4 -V\n       \n       \t\twget --quiet \\\n     - \t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n     +-\t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n     ++\t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\"\n       \t\ttar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n       \t\t\t-C \"$CUSTOM_PATH\" --strip-components=1 \\\n     - \t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n     +-\t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n      -\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n      -\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n     +-\n     +-\t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n     +-\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n     +-\t\trm -f \"$CUSTOM_PATH/jgit\"\n     ++\t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\"\n      +\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\"\n      +\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n      +\t\tgit-lfs version\n     - \n     - \t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n     --\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n     --\t\trm -f \"$CUSTOM_PATH/jgit\"\n     ++\n     ++\t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\"\n      +\t\tchmod a+x \"$CUSTOM_PATH/jgit\"\n      +\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n      +\t\tjgit version\n     @@ ci/install-dependencies.sh: ubuntu-*|i386/ubuntu-*|debian-*)\n       \tesac\n       \t;;\n      @@ ci/install-dependencies.sh: macos-*)\n     - \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n     - \ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n     + \tbrew link --force gettext\n     + \n     + \tmkdir -p \"$CUSTOM_PATH\"\n     +-\twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n     +-\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n     ++\twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\"\n     ++\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d\n       \trm helix-core-server.tgz\n      +\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n      +\tp4d -V\n\n-- \ngitgitgadget\n\n"},{"id":"556453","messageId":"c1ee3fcb7dbba1e1ae599d30a2144fcd498d8932.1793089936.git.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.v4.git.git.1793089936.gitgitgadget@gmail.com","subject":"[PATCH v4 1/2] ci: drop quarantine removal for macos perforce binaries","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-27T08:32:15Z","receivedAt":"2026-10-27T08:32:15Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"From: Harald Nordgren <haraldnordgren@gmail.com>\n\nThe xattr -d call that strips com.apple.quarantine from the macOS\nperforce binaries has been doing nothing for years, and can simply\ngo.\n\n5ed9fc3fc8 (ci: prevent `perforce` from being quarantined,\n2020-02-27) added that call to stop p4d -V from hanging on a GUI\nconfirmation dialog that never comes on a CI box, back when perforce\nwas installed via Homebrew's --no-quarantine cask flag. When\n49af448197 (ci: reintroduce prevention from perforce being\nquarantined in macOS, 2022-05-12) replaced that with a plain wget\nand tar download, it kept the xattr -d call as a precaution, while\nnoting that it already does nothing on GitHub Actions.\n\nA file downloaded with wget never gets com.apple.quarantine set in\nthe first place, only Safari, Finder, and AirDrop apply that\nattribute through the LaunchServices quarantine API. The same holds\non GitLab CI's macOS runners, so the call has been a silent no-op\neverywhere since 2022.\n\nSigned-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n---\n ci/install-dependencies.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex d57dce5663..203e8401cf 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -122,7 +122,6 @@ macos-*)\n \tmkdir -p \"$CUSTOM_PATH\"\n \twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n \ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n-\tsudo xattr -d com.apple.quarantine \"$CUSTOM_PATH/p4\" \"$CUSTOM_PATH/p4d\" 2>/dev/null || true\n \trm helix-core-server.tgz\n \n \tcase \"$jobname\" in\n-- \ngitgitgadget\n\n\n"},{"id":"556454","messageId":"c6dda879aadf5255bf4601f4a96d91e22e72316e.1793089936.git.gitgitgadget@gmail.com","threadId":"66317","inReplyTo":"pull.2403.v4.git.git.1793089936.gitgitgadget@gmail.com","subject":"[PATCH v4 2/2] ci: fail the build if perforce, git-lfs, or JGit fail to install","fromName":"Harald Nordgren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-10-27T08:32:16Z","receivedAt":"2026-10-27T08:32:16Z","isPatch":true,"sender":{"key":"haraldnordgren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9569897?v=4"},"body":"From: Harald Nordgren <haraldnordgren@gmail.com>\n\nA failed install of perforce, git-lfs, or JGit was silently\ntolerated. The corresponding tests would just skip and the build\nstayed green, so a broken download could go unnoticed indefinitely.\n\nFail the build immediately instead on the platforms that install\nthese tools. The presence checks and warnings at the end of the\nscript are gone too, since we already know by then that everything\ninstalled or the build wouldn't have gotten this far.\n\nSigned-off-by: Harald Nordgren <haraldnordgren@gmail.com>\n---\n ci/install-dependencies.sh | 63 +++++++++++++-------------------------\n 1 file changed, 22 insertions(+), 41 deletions(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex 203e8401cf..d35c64102e 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -93,23 +93,26 @@ ubuntu-*|i386/ubuntu-*|debian-*)\n \n \t\twget --quiet --directory-prefix=\"$CUSTOM_PATH\" \\\n \t\t\t\"$P4WHENCE/bin.linux26x86_64/p4d\" \\\n-\t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\" &&\n-\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\" || {\n-\t\t\trm -f \"$CUSTOM_PATH/p4\"\n-\t\t\trm -f \"$CUSTOM_PATH/p4d\"\n-\t\t}\n+\t\t\t\"$P4WHENCE/bin.linux26x86_64/p4\"\n+\t\tchmod a+x \"$CUSTOM_PATH/p4d\" \"$CUSTOM_PATH/p4\"\n+\t\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\t\tp4d -V\n+\t\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\t\tp4 -V\n \n \t\twget --quiet \\\n-\t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" &&\n+\t\t     \"$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\"\n \t\ttar -xzf \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" \\\n \t\t\t-C \"$CUSTOM_PATH\" --strip-components=1 \\\n-\t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\" &&\n-\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\" ||\n-\t\trm -f \"$CUSTOM_PATH/git-lfs\"\n-\n-\t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\" &&\n-\t\tchmod a+x \"$CUSTOM_PATH/jgit\" ||\n-\t\trm -f \"$CUSTOM_PATH/jgit\"\n+\t\t\t\"git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs\"\n+\t\trm \"git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz\"\n+\t\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n+\t\tgit-lfs version\n+\n+\t\twget --quiet \"$JGITWHENCE\" --output-document=\"$CUSTOM_PATH/jgit\"\n+\t\tchmod a+x \"$CUSTOM_PATH/jgit\"\n+\t\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n+\t\tjgit version\n \t\t;;\n \tesac\n \t;;\n@@ -120,9 +123,13 @@ macos-*)\n \tbrew link --force gettext\n \n \tmkdir -p \"$CUSTOM_PATH\"\n-\twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\" &&\n-\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d &&\n+\twget -q \"$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz\"\n+\ttar -xf helix-core-server.tgz -C \"$CUSTOM_PATH\" p4 p4d\n \trm helix-core-server.tgz\n+\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n+\tp4d -V\n+\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n+\tp4 -V\n \n \tcase \"$jobname\" in\n \tosx-meson)\n@@ -170,30 +177,4 @@ Documentation)\n \t;;\n esac\n \n-if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Perforce Server Version$(tput sgr0)\"\n-\tp4d -V\n-\techo \"$(tput setaf 6)Perforce Client Version$(tput sgr0)\"\n-\tp4 -V\n-else\n-\techo >&2 \"::warning:: perforce wasn't installed, see above for clues why\"\n-fi\n-\n-if type git-lfs >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)Git-LFS Version$(tput sgr0)\"\n-\tgit-lfs version\n-else\n-\techo >&2 \"::warning:: git-lfs wasn't installed, see above for clues why\"\n-fi\n-\n-if type jgit >/dev/null 2>&1\n-then\n-\techo \"$(tput setaf 6)JGit Version$(tput sgr0)\"\n-\tjgit version\n-else\n-\techo >&2 \"::warning:: JGit wasn't installed, see above for clues why\"\n-fi\n-\n end_group \"Install dependencies\"\n-- \ngitgitgadget\n\n"},{"id":"556461","messageId":"auCAsdCsZyPPqWpc@pks.im","threadId":"66317","inReplyTo":"pull.2403.v4.git.git.1793089936.gitgitgadget@gmail.com","subject":"Re: [PATCH v4 0/2] ci: fail the build if perforce, git-lfs or JGit fail to install","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-10-27T10:45:14Z","receivedAt":"2026-10-27T10:45:14Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Oct 27, 2026 at 08:32:14AM +0000, Harald Nordgren via GitGitGadget wrote:\n> Fail the build when perforce, git-lfs, or JGit fail to install, and drop the\n> warnings that used to fire on every platform regardless of whether it even\n> attempted the install.\n> \n> Changes in v4:\n> \n>  * Drops the && chaining between the wget/tar/chmod install steps for\n>    perforce, git-lfs, and JGit, since under set -e a failing command inside\n>    an && chain is exempt from aborting the script unless it's the last one\n>    in the chain, so the chain was silently letting an earlier failure fall\n>    through instead of stopping the build.\n>  * Reworded the quarantine-removal commit to lead with the observation (the\n>    call does nothing and can go) before the history, fixed a dangling \"this\"\n>    reference, and added that the same holds on GitLab CI's macOS runners,\n>    not just GitHub Actions.\n\nThanks, this version looks good to me.\n\nPatrick\n\n"}]}