{"thread":{"id":"66282","subject":"[PATCH] doc: Make asciidoc bullet items separate","startedAt":"2026-09-07T07:17:43Z","lastAt":"2026-09-10T16:38:22Z","messageCount":7,"participants":["Brigham Campbell","Patrick Steinhardt","Kristoffer Haugsbakk","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"552094","messageId":"20260907-maintenance-doc-bullet-fix-v1-1-dc08dbe61a82@brighamcampbell.com","threadId":"66282","inReplyTo":null,"subject":"[PATCH] doc: Make asciidoc bullet items separate","fromName":"Brigham Campbell","fromEmail":"me@brighamcampbell.com","sentAt":"2026-09-07T07:15:57Z","receivedAt":"2026-09-07T07:17:43Z","isPatch":true,"body":"Fix conjoined bullet items in maintenance asciidoc file.\n\nSigned-off-by: Brigham Campbell \n---\n Documentation/config/maintenance.adoc | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/config/maintenance.adoc b/Documentation/config/maintenance.adoc\nindex da8be9f812..c778ab09ac 100644\n--- a/Documentation/config/maintenance.adoc\n+++ b/Documentation/config/maintenance.adoc\n@@ -41,6 +41,7 @@ The possible strategies are:\n This repacking strategy is a full replacement for the `gc` strategy and is\n recommended for large repositories. This is the default strategy for manual\n maintenance.\n++\n * `incremental`: This setting optimizes for performing small maintenance\n activities that do not delete any data. This does not schedule the `gc`\n task, but runs the `prefetch` and `commit-graph` tasks hourly, the\n\n---\nbase-commit: 3cb9185f65410273787f74333cc027d2ea5daada\nchange-id: 20260907-maintenance-doc-bullet-fix-d351253f8a91\n\nThanks!\n-- \nBrigham Campbell\nhttps://brighamcampbell.com\n\n"},{"id":"552115","messageId":"ap55z8P8i2hqddAL@pks.im","threadId":"66282","inReplyTo":"20260907-maintenance-doc-bullet-fix-v1-1-dc08dbe61a82@brighamcampbell.com","subject":"Re: [PATCH] doc: Make asciidoc bullet items separate","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-09-07T08:46:07Z","receivedAt":"2026-09-07T08:46:14Z","isPatch":true,"body":"On Mon, Sep 07, 2026 at 01:15:57AM -0600, Brigham Campbell wrote:\n> Fix conjoined bullet items in maintenance asciidoc file.\n\nNot, probably not worth a reroll: it would have been nice to point out\nthat this is in git-config(1). E.g. something like this:\n\n doc: fix conjoined maintenance strategies in git-config(1)\n\n Fix conjoined bullet items for the maintennace strategies in\n git-config(1).\n\n> diff --git a/Documentation/config/maintenance.adoc b/Documentation/config/maintenance.adoc\n> index da8be9f812..c778ab09ac 100644\n> --- a/Documentation/config/maintenance.adoc\n> +++ b/Documentation/config/maintenance.adoc\n> @@ -41,6 +41,7 @@ The possible strategies are:\n> This repacking strategy is a full replacement for the `gc` strategy and is\n> recommended for large repositories. This is the default strategy for manual\n> maintenance.\n> ++\n> * `incremental`: This setting optimizes for performing small maintenance\n> activities that do not delete any data. This does not schedule the `gc`\n> task, but runs the `prefetch` and `commit-graph` tasks hourly, the\n\nAh, indeed. I can confirm that this is misrendered when looking at\ngit-config(1), and with your patch it indeed renders correctly. Thanks\nfor this simple and obvious fix!\n\nPatrick\n"},{"id":"552121","messageId":"9f455224-f156-493f-a21c-27a8922f3360@app.fastmail.com","threadId":"66282","inReplyTo":"20260907-maintenance-doc-bullet-fix-v1-1-dc08dbe61a82@brighamcampbell.com","subject":"Re: [PATCH] doc: Make asciidoc bullet items separate","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2026-09-07T10:18:48Z","receivedAt":"2026-09-07T10:19:12Z","isPatch":true,"body":"On Mon, Sep 7, 2026, at 09:15, Brigham Campbell wrote:\n> Fix conjoined bullet items in maintenance asciidoc file.\n>\n> Signed-off-by: Brigham Campbell \n> ---\n> Documentation/config/maintenance.adoc | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/Documentation/config/maintenance.adoc\n> b/Documentation/config/maintenance.adoc\n> index da8be9f812..c778ab09ac 100644\n> --- a/Documentation/config/maintenance.adoc\n> +++ b/Documentation/config/maintenance.adoc\n> @@ -41,6 +41,7 @@ The possible strategies are:\n> This repacking strategy is a full replacement for the `gc` strategy\n> and is\n> recommended for large repositories. This is the default strategy for\n> manual\n> maintenance.\n> ++\n> * `incremental`: This setting optimizes for performing small\n> maintenance\n> activities that do not delete any data. This does not schedule the\n> `gc`\n> task, but runs the `prefetch` and `commit-graph` tasks hourly, the\n>\n> ---\n> base-commit: 3cb9185f65410273787f74333cc027d2ea5daada\n> change-id: 20260907-maintenance-doc-bullet-fix-d351253f8a91\n\nI wonder if this gives different results for asciidoc and asciidoctor.\n\n• asciidoctor: seems that the bullet list is correct with or without\n this change (no change)\n• asciidoc: needs this change\n\nNote that I’ve made enough asciidoc/tor mistakes so I’m not that\nreliable of a witness.\n\nI also idly wonder why git-scm renders this bullet list as it ought\nto. This hunk has not been modified for a while. The second paragraph\nwhich ostensibly made it conjoined was d9bccf2e (builtin/maintenance:\nintroduce \"geometric\" strategy, 2025-10-24).\n\nhttps://git-scm.com/docs/git-config\n"},{"id":"552152","messageId":"DL991DWRB590.NECVWISEVRKG@brighamcampbell.com","threadId":"66282","inReplyTo":"ap55z8P8i2hqddAL@pks.im","subject":"Re: [PATCH] doc: Make asciidoc bullet items separate","fromName":"Brigham Campbell","fromEmail":"me@brighamcampbell.com","sentAt":"2026-09-07T17:10:15Z","receivedAt":"2026-09-07T17:10:17Z","isPatch":true,"body":"On Mon Sep 7, 2026 at 2:46 AM MDT, Patrick Steinhardt wrote:\n> Not, probably not worth a reroll: it would have been nice to point out\n> that this is in git-config(1). E.g. something like this:\n>\n> doc: fix conjoined maintenance strategies in git-config(1)\n>\n> Fix conjoined bullet items for the maintennace\n\nmaintennace -> maintenance\n\n> strategies in\n> git-config(1).\n\nI'll mention git-config(1) in v2 if maintainers request a new revision\n(though I agree that a patch this simple probably doesn't need a\nreroll). Otherwise, I invite the committer to make editorial changes to\nthe commit message as they see fit.\n\n>> diff --git a/Documentation/config/maintenance.adoc b/Documentation/config/maintenance.adoc\n>> index da8be9f812..c778ab09ac 100644\n>> --- a/Documentation/config/maintenance.adoc\n>> +++ b/Documentation/config/maintenance.adoc\n>> @@ -41,6 +41,7 @@ The possible strategies are:\n>> This repacking strategy is a full replacement for the `gc` strategy and is\n>> recommended for large repositories. This is the default strategy for manual\n>> maintenance.\n>> ++\n>> * `incremental`: This setting optimizes for performing small maintenance\n>> activities that do not delete any data. This does not schedule the `gc`\n>> task, but runs the `prefetch` and `commit-graph` tasks hourly, the\n>\n> Ah, indeed. I can confirm that this is misrendered when looking at\n> git-config(1), and with your patch it indeed renders correctly. Thanks\n> for this simple and obvious fix!\n\nThanks for the review! It's a minor change, but this is my first patch\nto the git project, so I appreciate your time and expertise.\n\nCheers!\n-- \nBrigham Campbell\nhttps://brighamcampbell.com\n\n"},{"id":"552413","messageId":"20260910-maintenance-doc-bullet-fix-v2-1-3ed1c75e24b2@brighamcampbell.com","threadId":"66282","inReplyTo":"20260907-maintenance-doc-bullet-fix-v1-1-dc08dbe61a82@brighamcampbell.com","subject":"[PATCH v2] doc: fix conjoined maintenance strategies in git-config(1)","fromName":"Brigham Campbell","fromEmail":"me@brighamcampbell.com","sentAt":"2026-09-10T06:52:31Z","receivedAt":"2026-09-10T06:53:26Z","isPatch":true,"body":"Fix conjoined bullet items for the maintenance strategies in\ngit-config(1). Reportedly, asciidoctor renders this document correctly\nboth before and after this patch. asciidoc renders it correctly only\n_after_ this patch.\n\nSigned-off-by: Brigham Campbell \n---\nI wouldn't normally spin a v2 this quickly, but Jun specifically asked\nfor v2 on a thread on the \"what's cooking\" news.\n\nPatrick, Kristoffer, if this revision is to your liking, I'd appreciate\nan Acked-by from either of you. If not, please let me know what to\nchange for v3.\n\nChanges in v2:\n- Tweak commit message wording\n- Link to v1: https://patch.msgid.link/20260907-maintenance-doc-bullet-fix-v1-1-dc08dbe61a82@brighamcampbell.com\n\nCc: git@vger.kernel.org\nTo: Taylor Blau \nTo: Junio C Hamano \nTo: Patrick Steinhardt \nTo: Kristoffer Haugsbakk \n---\n Documentation/config/maintenance.adoc | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/config/maintenance.adoc b/Documentation/config/maintenance.adoc\nindex da8be9f812..c778ab09ac 100644\n--- a/Documentation/config/maintenance.adoc\n+++ b/Documentation/config/maintenance.adoc\n@@ -41,6 +41,7 @@ The possible strategies are:\n This repacking strategy is a full replacement for the `gc` strategy and is\n recommended for large repositories. This is the default strategy for manual\n maintenance.\n++\n * `incremental`: This setting optimizes for performing small maintenance\n activities that do not delete any data. This does not schedule the `gc`\n task, but runs the `prefetch` and `commit-graph` tasks hourly, the\n\n---\nbase-commit: 3cb9185f65410273787f74333cc027d2ea5daada\nchange-id: 20260907-maintenance-doc-bullet-fix-d351253f8a91\n\nThanks!\n-- \nBrigham Campbell\nhttps://brighamcampbell.com\n\n"},{"id":"552418","messageId":"aqJntwrjC4ImuSyW@pks.im","threadId":"66282","inReplyTo":"20260910-maintenance-doc-bullet-fix-v2-1-3ed1c75e24b2@brighamcampbell.com","subject":"Re: [PATCH v2] doc: fix conjoined maintenance strategies in git-config(1)","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-09-10T08:17:59Z","receivedAt":"2026-09-10T08:18:06Z","isPatch":true,"body":"On Thu, Sep 10, 2026 at 12:52:31AM -0600, Brigham Campbell wrote:\n> Fix conjoined bullet items for the maintenance strategies in\n> git-config(1). Reportedly, asciidoctor renders this document correctly\n> both before and after this patch. asciidoc renders it correctly only\n> _after_ this patch.\n> \n> Signed-off-by: Brigham Campbell \n> ---\n> I wouldn't normally spin a v2 this quickly, but Jun specifically asked\n> for v2 on a thread on the \"what's cooking\" news.\n\nThe pacing is totally fine, it's been multiple days since your v1.\n\n> Patrick, Kristoffer, if this revision is to your liking, I'd appreciate\n> an Acked-by from either of you. If not, please let me know what to\n> change for v3.\n\nThis version looks good to me, thanks!\n\nPatrick\n"},{"id":"552468","messageId":"20260910163820.GE251185@coredump.intra.peff.net","threadId":"66282","inReplyTo":"9f455224-f156-493f-a21c-27a8922f3360@app.fastmail.com","subject":"Re: [PATCH] doc: Make asciidoc bullet items separate","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2026-09-10T16:38:20Z","receivedAt":"2026-09-10T16:38:22Z","isPatch":true,"body":"On Mon, Sep 07, 2026 at 12:18:48PM +0200, Kristoffer Haugsbakk wrote:\n\n> I wonder if this gives different results for asciidoc and asciidoctor.\n> \n> • asciidoctor: seems that the bullet list is correct with or without\n> this change (no change)\n> • asciidoc: needs this change\n\nYeah, I think we've run into this sort of parsing subtlety between the\ntwo before.\n\nI imagine this is how you did it, but for the original author and\nanybody else working on documentation, it is often useful to do:\n\n cd Documentation\n ./doc-diff HEAD^ HEAD\n ./doc-diff --asciidoctor HEAD^ HEAD\n\nto see how your changes work in both systems. You can also do:\n\n ./doc-diff --from-asciidoctor --to-asciidoc HEAD HEAD\n\nto see how the two renderers differ currently, but there's quite a lot\nof noise (differing wrapping, indentation, use of quotes, etc). All of\nthose may be candidates for examination and fixing, but it is a lot of\nnoise if you are looking at your one area. ;)\n\n> I also idly wonder why git-scm renders this bullet list as it ought\n> to. This hunk has not been modified for a while. The second paragraph\n> which ostensibly made it conjoined was d9bccf2e (builtin/maintenance:\n> introduce \"geometric\" strategy, 2025-10-24).\n\nIt uses asciidoctor. :)\n\n-Peff\n"}]}