{"thread":{"id":"66237","subject":"[PATCH] typofix: fix spelling mistakes in comments and test description","startedAt":"2026-08-30T13:42:40Z","lastAt":"2026-08-31T17:56:58Z","messageCount":4,"participants":["Hardik Kumar","Michael Montalbo","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"551472","messageId":"20260830-typo-v1-1-d397c8dfb301@gmail.com","threadId":"66237","inReplyTo":null,"subject":"[PATCH] typofix: fix spelling mistakes in comments and test description","fromName":"Hardik Kumar","fromEmail":"hardikxk@gmail.com","sentAt":"2026-08-30T13:42:35Z","receivedAt":"2026-08-30T13:42:40Z","isPatch":true,"body":"Fix spelling errors in the following places:\n\nversioncmp.c:           \"fractionnal\" -> \"fractional\"\ngit-gui/git-gui.sh:     \"occurence\"   -> \"occurrence\"\nt/t0022-crlf-rename.sh: \"similiarity\" -> \"similarity\"\n\nSigned-off-by: Hardik Kumar <hardikxk@gmail.com>\n---\n git-gui/git-gui.sh     | 2 +-\n t/t0022-crlf-rename.sh | 2 +-\n versioncmp.c           | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 15dd2b3a84..cc8a05517a 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -109,7 +109,7 @@ foreach p [split $env(PATH) $_path_sep] {\n \tif {[file pathtype $p] ne {absolute}} {\n \t\tcontinue\n \t}\n-\t# Keep only the first occurence of any duplicates.\n+\t# Keep only the first occurrence of any duplicates.\n \tset norm_p [file normalize $p]\n \tdict set _path_seen $norm_p 1\n }\ndiff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh\nindex 9bd863a970..328c6e5903 100755\n--- a/t/t0022-crlf-rename.sh\n+++ b/t/t0022-crlf-rename.sh\n@@ -1,6 +1,6 @@\n #!/bin/sh\n \n-test_description='ignore CR in CRLF sequence while computing similiarity'\n+test_description='ignore CR in CRLF sequence while computing similarity'\n \n . ./test-lib.sh\n \ndiff --git a/versioncmp.c b/versioncmp.c\nindex 3a81b17bc1..f1e451755a 100644\n--- a/versioncmp.c\n+++ b/versioncmp.c\n@@ -15,7 +15,7 @@\n \n /*\n  * states: S_N: normal, S_I: comparing integral part, S_F: comparing\n- * fractionnal parts, S_Z: idem but with leading Zeroes only\n+ * fractional parts, S_Z: idem but with leading Zeroes only\n  */\n #define  S_N    0x0\n #define  S_I    0x3\n\n---\nbase-commit: c73e85354c275c9d409b26445089bc16940fc527\nchange-id: 20260830-typo-fea59ea5a02a\n\n"},{"id":"551474","messageId":"CAC2QwmK1CR9177=eD_rqGrCULPkXTDDcQn=NHqoGGBzdeYEYCQ@mail.gmail.com","threadId":"66237","inReplyTo":"20260830-typo-v1-1-d397c8dfb301@gmail.com","subject":"Re: [PATCH] typofix: fix spelling mistakes in comments and test description","fromName":"Michael Montalbo","fromEmail":"mmontalbo@gmail.com","sentAt":"2026-08-30T16:23:21Z","receivedAt":"2026-08-30T16:23:33Z","isPatch":true,"body":"On Sun, Aug 30, 2026 at 6:42 AM Hardik Kumar <hardikxk@gmail.com> wrote:\n>\n> Fix spelling errors in the following places:\n>\n> versioncmp.c:           \"fractionnal\" -> \"fractional\"\n> git-gui/git-gui.sh:     \"occurence\"   -> \"occurrence\"\n> t/t0022-crlf-rename.sh: \"similiarity\" -> \"similarity\"\n>\n> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>\n\nThese changes LGTM.\n"},{"id":"551586","messageId":"xmqqzey2w5l5.fsf@gitster.g","threadId":"66237","inReplyTo":"20260830-typo-v1-1-d397c8dfb301@gmail.com","subject":"Re: [PATCH] typofix: fix spelling mistakes in comments and test description","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-08-31T17:41:10Z","receivedAt":"2026-08-31T17:41:13Z","isPatch":true,"body":"Hardik Kumar <hardikxk@gmail.com> writes:\n\n> Fix spelling errors in the following places:\n>\n> versioncmp.c:           \"fractionnal\" -> \"fractional\"\n> git-gui/git-gui.sh:     \"occurence\"   -> \"occurrence\"\n> t/t0022-crlf-rename.sh: \"similiarity\" -> \"similarity\"\n\ngit-gui comes from a separate project and a different rule applies\nto patches in that area.  See Documentation/SubmittingPatches for\ndetails, but the consequences to the rule are:\n\n - Any patch to git-gui (or gitk) would not be a patch against a path\n   inside git-gui/ (or gitk-git/) directory.\n\n - A patch message to git-gui (or gitk) would not contain any\n   patches to other parts of the system.\n\n"},{"id":"551587","messageId":"DL3BN8L6HK8O.T44IZ297KCF3@gmail.com","threadId":"66237","inReplyTo":"xmqqzey2w5l5.fsf@gitster.g","subject":"Re: [PATCH] typofix: fix spelling mistakes in comments and test description","fromName":"Hardik Kumar","fromEmail":"hardikxk@gmail.com","sentAt":"2026-08-31T17:56:50Z","receivedAt":"2026-08-31T17:56:58Z","isPatch":true,"body":"On Mon Aug 31, 2026 at 11:11 PM IST, Junio C Hamano wrote:\n> Hardik Kumar <hardikxk@gmail.com> writes:\n>\n>> Fix spelling errors in the following places:\n>>\n>> versioncmp.c:           \"fractionnal\" -> \"fractional\"\n>> git-gui/git-gui.sh:     \"occurence\"   -> \"occurrence\"\n>> t/t0022-crlf-rename.sh: \"similiarity\" -> \"similarity\"\n>\n> git-gui comes from a separate project and a different rule applies\n> to patches in that area.  See Documentation/SubmittingPatches for\n> details, but the consequences to the rule are:\n>\n>  - Any patch to git-gui (or gitk) would not be a patch against a path\n>    inside git-gui/ (or gitk-git/) directory.\n>\n>  - A patch message to git-gui (or gitk) would not contain any\n>    patches to other parts of the system.\n\nThank you I had skipped over that.\n\nI had sent another patch with the \"versioncmp\" prefix which only edits\nthe core files to fix the typos.\n\nThanks.\n\nHardik\n"}]}