{"thread":{"id":"66236","subject":"[PATCH] doc: remote-helpers: option pushcert if-asked","startedAt":"2026-08-29T18:37:08Z","lastAt":"2026-11-02T09:01:17Z","messageCount":2,"participants":["Lorenz Leutgeb","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"551469","messageId":"20260829183659.29947-1-lorenz.leutgeb@posteo.eu","threadId":"66236","inReplyTo":null,"subject":"[PATCH] doc: remote-helpers: option pushcert if-asked","fromName":"Lorenz Leutgeb","fromEmail":"lorenz.leutgeb@posteo.eu","sentAt":"2026-08-29T18:37:04Z","receivedAt":"2026-08-29T18:37:08Z","isPatch":true,"sender":{"key":"lorenz.leutgeb@posteo.eu","avatar":"https://gravatar.com/avatar/27187b6fdcf910e66ebc91e827a98237a83c007288d3eb471ca294d8bb8b9645?d=mp&s=160"},"body":"The documentation mentions that the value for the option \"pushcert\" is\n\"true\" or \"false\". This is incomplete, as can be seen by analyzing\ntransport-helper.c:1009-1018 (added in commit 30261094b1f7fdcba3b7a1)\nwhich also implements setting the option to the value \"if-asked\".\n\nAdd the third value to the documentation (added in commit b9299a2bb1).\n\nSigned-off-by: Lorenz Leutgeb <lorenz.leutgeb@posteo.eu>\n---\n Documentation/gitremote-helpers.adoc | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitremote-helpers.adoc b/Documentation/gitremote-helpers.adoc\nindex 39cdece16e..10921e91b9 100644\n--- a/Documentation/gitremote-helpers.adoc\n+++ b/Documentation/gitremote-helpers.adoc\n@@ -523,7 +523,7 @@ set by Git if the remote helper has the 'option' capability.\n 'option update-shallow' {'true'|'false'}::\n \tAllow to extend .git/shallow if the new refs require it.\n \n-'option pushcert' {'true'|'false'}::\n+'option pushcert' {'true'|'false'|'if-asked'}::\n \tGPG sign pushes.\n \n 'option push-option' <string>::\n-- \n2.55.0\n\n"},{"id":"557126","messageId":"xmqqfqxjmwte.fsf@gitster.g","threadId":"66236","inReplyTo":"20260829183659.29947-1-lorenz.leutgeb@posteo.eu","subject":"Re: [PATCH] doc: remote-helpers: option pushcert if-asked","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-11-02T09:01:17Z","receivedAt":"2026-11-02T09:01:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lorenz Leutgeb <lorenz.leutgeb@posteo.eu> writes:\n\n> The documentation mentions that the value for the option \"pushcert\" is\n> \"true\" or \"false\". This is incomplete, as can be seen by analyzing\n> transport-helper.c:1009-1018 (added in commit 30261094b1f7fdcba3b7a1)\n> which also implements setting the option to the value \"if-asked\".\n>\n> Add the third value to the documentation (added in commit b9299a2bb1).\n\nExcept for these commit references not using the --pretty=reference\nformat, I think the above is good enough, and the patch contents is\ntrue enough.\n\nThat's not much of a review, but that needs to suffice for now.\n\nWill mark the topic ready for 'next'.\n\n> Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@posteo.eu>\n> ---\n>  Documentation/gitremote-helpers.adoc | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/gitremote-helpers.adoc b/Documentation/gitremote-helpers.adoc\n> index 39cdece16e..10921e91b9 100644\n> --- a/Documentation/gitremote-helpers.adoc\n> +++ b/Documentation/gitremote-helpers.adoc\n> @@ -523,7 +523,7 @@ set by Git if the remote helper has the 'option' capability.\n>  'option update-shallow' {'true'|'false'}::\n>  \tAllow to extend .git/shallow if the new refs require it.\n>  \n> -'option pushcert' {'true'|'false'}::\n> +'option pushcert' {'true'|'false'|'if-asked'}::\n>  \tGPG sign pushes.\n>  \n>  'option push-option' <string>::\n\n"}]}