# [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh 3 messages from 2026-08-28 to 2026-08-31. Participants: Hardik Kumar, Patrick Steinhardt, Tuomas Ahola. Thread: https://gitlist.dev/t/66232 ## Hardik Kumar, 2026-08-28 09:08 Subject: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Message-ID: <20260828-typo-fix-v1-1-24e80a87ed53@gmail.com> ``` The patch fixes two typos in two places. versoncmp.c: "fractionnal" -> "fractional" t/t0022-crlf-rename.sh: "similiarity" -> "similarity" NFC only updating a comment and a test_description Signed-off-by: Hardik Kumar --- t/t0022-crlf-rename.sh | 2 +- versioncmp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh index 9bd863a970..328c6e5903 100755 --- a/t/t0022-crlf-rename.sh +++ b/t/t0022-crlf-rename.sh @@ -1,6 +1,6 @@ #!/bin/sh -test_description='ignore CR in CRLF sequence while computing similiarity' +test_description='ignore CR in CRLF sequence while computing similarity' . ./test-lib.sh diff --git a/versioncmp.c b/versioncmp.c index 3a81b17bc1..f1e451755a 100644 --- a/versioncmp.c +++ b/versioncmp.c @@ -15,7 +15,7 @@ /* * states: S_N: normal, S_I: comparing integral part, S_F: comparing - * fractionnal parts, S_Z: idem but with leading Zeroes only + * fractional parts, S_Z: idem but with leading Zeroes only */ #define S_N 0x0 #define S_I 0x3 --- base-commit: f78ce2f7b6df702f93d40b85d6bda92a3f65da79 change-id: 20260828-typo-fix-721b77177721 ``` ## Patrick Steinhardt, 2026-08-31 06:59 Subject: Re: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Message-ID: In-Reply-To: <20260828-typo-fix-v1-1-24e80a87ed53@gmail.com> ``` On Fri, Aug 28, 2026 at 02:38:01PM +0530, Hardik Kumar wrote: > The patch fixes two typos in two places. > versoncmp.c: "fractionnal" -> "fractional" s/versoncmp/versioncmp/ > t/t0022-crlf-rename.sh: "similiarity" -> "similarity" The patch subject only mentions "versioncmp", so it's quite surprising to see a change to t0022, as well. Maybe you should just split it up into two patches, even though that feels somewhat heavyweight. > NFC only updating a comment and a test_description I have no idea what this means. > diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh > index 9bd863a970..328c6e5903 100755 > --- a/t/t0022-crlf-rename.sh > +++ b/t/t0022-crlf-rename.sh > @@ -1,6 +1,6 @@ > #!/bin/sh > > -test_description='ignore CR in CRLF sequence while computing similiarity' > +test_description='ignore CR in CRLF sequence while computing similarity' > > . ./test-lib.sh > > diff --git a/versioncmp.c b/versioncmp.c > index 3a81b17bc1..f1e451755a 100644 > --- a/versioncmp.c > +++ b/versioncmp.c > @@ -15,7 +15,7 @@ > > /* > * states: S_N: normal, S_I: comparing integral part, S_F: comparing > - * fractionnal parts, S_Z: idem but with leading Zeroes only > + * fractional parts, S_Z: idem but with leading Zeroes only > */ > #define S_N 0x0 > #define S_I 0x3 The typo-fixes look obviously good. Thanks! Patrick ``` ## Tuomas Ahola, 2026-08-31 18:20 Subject: Re: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh Message-ID: <20260831182052.ppylY%taahol@utu.fi> In-Reply-To: ``` Patrick Steinhardt wrote: > On Fri, Aug 28, 2026 at 02:38:01PM +0530, Hardik Kumar wrote: > > > NFC only updating a comment and a test_description > > I have no idea what this means. > "No functional changes", I guess. But spelling it out in the commit log message would of course be preferable. ```