{"thread":{"id":"66232","subject":"[PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh","startedAt":"2026-08-28T09:08:08Z","lastAt":"2026-08-31T18:21:07Z","messageCount":3,"participants":["Hardik Kumar","Patrick Steinhardt","Tuomas Ahola"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"551412","messageId":"20260828-typo-fix-v1-1-24e80a87ed53@gmail.com","threadId":"66232","inReplyTo":null,"subject":"[PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh","fromName":"Hardik Kumar","fromEmail":"hardikxk@gmail.com","sentAt":"2026-08-28T09:08:01Z","receivedAt":"2026-08-28T09:08:08Z","isPatch":true,"body":"The patch fixes two typos in two places.\nversoncmp.c:            \"fractionnal\" -> \"fractional\"\nt/t0022-crlf-rename.sh: \"similiarity\" -> \"similarity\"\n\nNFC only updating a comment and a test_description\n\nSigned-off-by: Hardik Kumar <hardikxk@gmail.com>\n---\n t/t0022-crlf-rename.sh | 2 +-\n versioncmp.c           | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh\nindex 9bd863a970..328c6e5903 100755\n--- a/t/t0022-crlf-rename.sh\n+++ b/t/t0022-crlf-rename.sh\n@@ -1,6 +1,6 @@\n #!/bin/sh\n \n-test_description='ignore CR in CRLF sequence while computing similiarity'\n+test_description='ignore CR in CRLF sequence while computing similarity'\n \n . ./test-lib.sh\n \ndiff --git a/versioncmp.c b/versioncmp.c\nindex 3a81b17bc1..f1e451755a 100644\n--- a/versioncmp.c\n+++ b/versioncmp.c\n@@ -15,7 +15,7 @@\n \n /*\n  * states: S_N: normal, S_I: comparing integral part, S_F: comparing\n- * fractionnal parts, S_Z: idem but with leading Zeroes only\n+ * fractional parts, S_Z: idem but with leading Zeroes only\n  */\n #define  S_N    0x0\n #define  S_I    0x3\n\n---\nbase-commit: f78ce2f7b6df702f93d40b85d6bda92a3f65da79\nchange-id: 20260828-typo-fix-721b77177721\n\n"},{"id":"551516","messageId":"apUmRknf8gnd-Izp@pks.im","threadId":"66232","inReplyTo":"20260828-typo-fix-v1-1-24e80a87ed53@gmail.com","subject":"Re: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-08-31T06:59:18Z","receivedAt":"2026-08-31T06:59:27Z","isPatch":true,"body":"On Fri, Aug 28, 2026 at 02:38:01PM +0530, Hardik Kumar wrote:\n> The patch fixes two typos in two places.\n> versoncmp.c:            \"fractionnal\" -> \"fractional\"\n\ns/versoncmp/versioncmp/\n\n> t/t0022-crlf-rename.sh: \"similiarity\" -> \"similarity\"\n\nThe patch subject only mentions \"versioncmp\", so it's quite surprising\nto see a change to t0022, as well. Maybe you should just split it up\ninto two patches, even though that feels somewhat heavyweight.\n\n> NFC only updating a comment and a test_description\n\nI have no idea what this means.\n\n> diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh\n> index 9bd863a970..328c6e5903 100755\n> --- a/t/t0022-crlf-rename.sh\n> +++ b/t/t0022-crlf-rename.sh\n> @@ -1,6 +1,6 @@\n>  #!/bin/sh\n>  \n> -test_description='ignore CR in CRLF sequence while computing similiarity'\n> +test_description='ignore CR in CRLF sequence while computing similarity'\n>  \n>  . ./test-lib.sh\n>  \n> diff --git a/versioncmp.c b/versioncmp.c\n> index 3a81b17bc1..f1e451755a 100644\n> --- a/versioncmp.c\n> +++ b/versioncmp.c\n> @@ -15,7 +15,7 @@\n>  \n>  /*\n>   * states: S_N: normal, S_I: comparing integral part, S_F: comparing\n> - * fractionnal parts, S_Z: idem but with leading Zeroes only\n> + * fractional parts, S_Z: idem but with leading Zeroes only\n>   */\n>  #define  S_N    0x0\n>  #define  S_I    0x3\n\nThe typo-fixes look obviously good.\n\nThanks!\n\nPatrick\n"},{"id":"551588","messageId":"20260831182052.ppylY%taahol@utu.fi","threadId":"66232","inReplyTo":"apUmRknf8gnd-Izp@pks.im","subject":"Re: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh","fromName":"Tuomas Ahola","fromEmail":"taahol@utu.fi","sentAt":"2026-08-31T18:20:52Z","receivedAt":"2026-08-31T18:21:07Z","isPatch":true,"body":"Patrick Steinhardt <ps@pks.im> wrote:\n\n> On Fri, Aug 28, 2026 at 02:38:01PM +0530, Hardik Kumar wrote:\n> \n> > NFC only updating a comment and a test_description\n> \n> I have no idea what this means.\n> \n\n\"No functional changes\", I guess.  But spelling it out in the commit log\nmessage would of course be preferable.\n"}]}