{"thread":{"id":"6614","subject":"[PATCH] git-svn: do not let Git.pm warn if we prematurely close pipes","startedAt":"2007-02-01T21:12:26Z","lastAt":"2007-02-01T21:12:26Z","messageCount":1,"participants":["Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"33286","messageId":"11703643463997-git-send-email-normalperson@yhbt.net","threadId":"6614","inReplyTo":null,"subject":"[PATCH] git-svn: do not let Git.pm warn if we prematurely close pipes","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-02-01T21:12:26Z","receivedAt":"2007-02-01T21:12:26Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"This mainly quiets down warnings when running git svn log.\n\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n\n This is backported from my development branch and should\n be trivial enough for 1.5.0.\n\n git-svn.perl |   10 +++++-----\n 1 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 68156fc..8ebaae9 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -681,7 +681,7 @@ sub show_log {\n \t\tprocess_commit($_, $r_min, $r_max) foreach reverse @k;\n \t}\n out:\n-\teval { command_close_pipe($log) };\n+\tclose $log;\n \tprint '-' x72,\"\\n\" unless $_incremental || $_oneline;\n }\n \n@@ -1475,7 +1475,7 @@ sub map_tree_joins {\n \t\t\t\t$seen{$commit} = 1;\n \t\t\t}\n \t\t}\n-\t\teval { command_close_pipe($pipe) };\n+\t\tclose $pipe;\n \t}\n }\n \n@@ -1669,7 +1669,7 @@ sub write_grafts {\n \t\t\t\tlast unless /^\\S/;\n \t\t\t}\n \t\t}\n-\t\teval { command_close_pipe($ch) }; # breaking the pipe\n+\t\tclose $ch; # breaking the pipe\n \n \t\t# if real parents are the only ones in the grafts, drop it\n \t\tnext if join(' ',sort keys %$p) eq join(' ',sort keys %x);\n@@ -1766,7 +1766,7 @@ sub get_commit_time {\n \t\t} elsif ($tz =~ s/^\\-//) {\n \t\t\t$s -= tz_to_s_offset($tz);\n \t\t}\n-\t\teval { command_close_pipe($fh) };\n+\t\tclose $fh;\n \t\treturn $s;\n \t}\n \tdie \"Can't get commit time for commit: $cmt\\n\";\n@@ -2846,7 +2846,7 @@ sub rmdirs {\n \t\t\tdelete $rm->{join '/', @dn};\n \t\t}\n \t\tunless (%$rm) {\n-\t\t\teval { command_close_pipe($fh) };\n+\t\t\tclose $fh;\n \t\t\treturn;\n \t\t}\n \t}\n-- \n1.5.0.rc2.133.gca07-dirty\n"}]}