{"thread":{"id":"65985","subject":"[PATCH] fast-export: standardize usage string and SYNOPSIS","startedAt":"2026-07-13T12:42:15Z","lastAt":"2026-07-14T08:54:23Z","messageCount":3,"participants":["Christian Couder","Junio C Hamano","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"547976","messageId":"20260713124153.245268-1-christian.couder@gmail.com","threadId":"65985","inReplyTo":null,"subject":"[PATCH] fast-export: standardize usage string and SYNOPSIS","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2026-07-13T12:41:53Z","receivedAt":"2026-07-13T12:42:15Z","isPatch":true,"body":"The output of `git fast-export -h` currently starts with:\n\n usage: git fast-export []\n\nwhile the SYNOPSIS section in this command's documentation shows:\n\n 'git fast-export' [] | 'git fast-import'\n\nLet's make both of these consistent with each other and with other Git\ncommands by describing the arguments with:\n\n [] [] [[--] ...]\n\nThis takes into account the following:\n\n - `git fast-export` accepts both rev-list arguments and a number of\n genuine options of its own (--[no-]progress, --[no-]signed-tags,\n --[no-]signed-commits, etc).\n\n - `git fast-export` was the only command using `[]`\n while many other commands describe their revision arguments as\n `[] [[--] ...]`.\n\n - In the DESCRIPTION section of the documentation, it's already\n mentioned several times that the output should eventually be fed to\n `git fast-import`.\n\nThis also enables us to remove fast-export from\n\"t/t0450/adoc-help-mismatches\".\n\nSigned-off-by: Christian Couder \n---\n\nCI tests passed:\n\nhttps://github.com/chriscool/git/actions/runs/29245342050\n\n Documentation/git-fast-export.adoc | 2 +-\n builtin/fast-export.c | 2 +-\n t/t0450/adoc-help-mismatches | 1 -\n 3 files changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc\nindex 297b57bb2e..719aeca244 100644\n--- a/Documentation/git-fast-export.adoc\n+++ b/Documentation/git-fast-export.adoc\n@@ -9,7 +9,7 @@ git-fast-export - Git data exporter\n SYNOPSIS\n --------\n [verse]\n-'git fast-export' [] | 'git fast-import'\n+'git fast-export' [] [] [[--] ...]\n \n DESCRIPTION\n -----------\ndiff --git a/builtin/fast-export.c b/builtin/fast-export.c\nindex 0be43104dc..629d7c591a 100644\n--- a/builtin/fast-export.c\n+++ b/builtin/fast-export.c\n@@ -33,7 +33,7 @@\n #include \"gpg-interface.h\"\n \n static const char *const fast_export_usage[] = {\n-\tN_(\"git fast-export []\"),\n+\tN_(\"git fast-export [] [] [[--] ...]\"),\n \tNULL\n };\n \ndiff --git a/t/t0450/adoc-help-mismatches b/t/t0450/adoc-help-mismatches\nindex e8d6c13ccd..c4a55ff4e3 100644\n--- a/t/t0450/adoc-help-mismatches\n+++ b/t/t0450/adoc-help-mismatches\n@@ -12,7 +12,6 @@ column\n credential\n credential-cache\n credential-store\n-fast-export\n fast-import\n fetch-pack\n fmt-merge-msg\n-- \n2.55.0.124.gac3b7a3d2d\n\n"},{"id":"548014","messageId":"xmqq4ii228dd.fsf@gitster.g","threadId":"65985","inReplyTo":"20260713124153.245268-1-christian.couder@gmail.com","subject":"Re: [PATCH] fast-export: standardize usage string and SYNOPSIS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-07-13T15:54:06Z","receivedAt":"2026-07-13T15:54:09Z","isPatch":true,"body":"Christian Couder writes:\n\n> The output of `git fast-export -h` currently starts with:\n> ...\n> This also enables us to remove fast-export from\n> \"t/t0450/adoc-help-mismatches\".\n\nImproving consistency and eliminating special cases are both\npositive steps forward. Nice work.\n\n> diff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc\n> index 297b57bb2e..719aeca244 100644\n> --- a/Documentation/git-fast-export.adoc\n> +++ b/Documentation/git-fast-export.adoc\n> @@ -9,7 +9,7 @@ git-fast-export - Git data exporter\n> SYNOPSIS\n> --------\n> [verse]\n> -'git fast-export' [] | 'git fast-import'\n\nWhile this was well-intentioned (demonstrating a typical usage\npattern to show readers that the command's output is meant to be\nconsumed by 'fast-import'), it is highly unusual for a synopsis.\nExamples of this nature are better suited for the body of the manual\npages.\n\n> +'git fast-export' [] [] [[--] ...]\n\nThis updated version is much more consistent with other manual\npages.\n\nNice. Will queue. Thanks.\n"},{"id":"548094","messageId":"alX5Nl8uX4ctVqo3@pks.im","threadId":"65985","inReplyTo":"20260713124153.245268-1-christian.couder@gmail.com","subject":"Re: [PATCH] fast-export: standardize usage string and SYNOPSIS","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-07-14T08:54:14Z","receivedAt":"2026-07-14T08:54:23Z","isPatch":true,"body":"On Mon, Jul 13, 2026 at 02:41:53PM +0200, Christian Couder wrote:\n> diff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc\n> index 297b57bb2e..719aeca244 100644\n> --- a/Documentation/git-fast-export.adoc\n> +++ b/Documentation/git-fast-export.adoc\n> @@ -9,7 +9,7 @@ git-fast-export - Git data exporter\n> SYNOPSIS\n> --------\n> [verse]\n> -'git fast-export' [] | 'git fast-import'\n> +'git fast-export' [] [] [[--] ...]\n> \n> DESCRIPTION\n> -----------\n\nMakes sense, as it is more consistent with all the other commands that\nwe have. I don't recall any other commands that use \"|\".\n\n> diff --git a/builtin/fast-export.c b/builtin/fast-export.c\n> index 0be43104dc..629d7c591a 100644\n> --- a/builtin/fast-export.c\n> +++ b/builtin/fast-export.c\n> @@ -33,7 +33,7 @@\n> #include \"gpg-interface.h\"\n> \n> static const char *const fast_export_usage[] = {\n> -\tN_(\"git fast-export []\"),\n> +\tN_(\"git fast-export [] [] [[--] ...]\"),\n> \tNULL\n> };\n> \n\nThis is being adapted to match.\n\n> diff --git a/t/t0450/adoc-help-mismatches b/t/t0450/adoc-help-mismatches\n> index e8d6c13ccd..c4a55ff4e3 100644\n> --- a/t/t0450/adoc-help-mismatches\n> +++ b/t/t0450/adoc-help-mismatches\n> @@ -12,7 +12,6 @@ column\n> credential\n> credential-cache\n> credential-store\n> -fast-export\n> fast-import\n> fetch-pack\n> fmt-merge-msg\n\nAnd as both match now we can also update t0450. Nice!\n\nPatrick\n"}]}