# [PATCH v2] setup.c: use die_errno() when chdir() system call fails 2 messages from 2026-07-06 to 2026-07-06. Participants: Gatla Vishweshwar Reddy, Junio C Hamano. Thread: https://gitlist.dev/t/65936 ## Gatla Vishweshwar Reddy, 2026-07-06 19:14 Subject: [PATCH v2] setup.c: use die_errno() when chdir() system call fails Message-ID: <20260706191421.94453-1-gatlavishweshwarreddy26@gmail.com> ``` When chdir() fails, the errno value contains the reason for the failure. Using die() instead of die_errno() loses this information, making it harder to diagnose failures. Switch to die_errno() to include the system error message in the output. Signed-off-by: Gatla Vishweshwar Reddy --- setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.c b/setup.c index b4652651df..e2e98d1126 100644 --- a/setup.c +++ b/setup.c @@ -1954,13 +1954,13 @@ const char *setup_git_directory_gently(struct repository *repo, int *nongit_ok) break; case GIT_DIR_DISCOVERED: if (dir.len < cwd.len && chdir(dir.buf)) - die(_("cannot change to '%s'"), dir.buf); + die_errno(_("cannot change to '%s'"), dir.buf); prefix = setup_discovered_git_dir(repo, gitdir.buf, &cwd, dir.len, &repo_fmt, nongit_ok); break; case GIT_DIR_BARE: if (dir.len < cwd.len && chdir(dir.buf)) - die(_("cannot change to '%s'"), dir.buf); + die_errno(_("cannot change to '%s'"), dir.buf); prefix = setup_bare_git_dir(repo, &cwd, dir.len, &repo_fmt, nongit_ok); break; case GIT_DIR_HIT_CEILING: -- 2.54.0 ``` ## Junio C Hamano, 2026-07-06 19:37 Subject: Re: [PATCH v2] setup.c: use die_errno() when chdir() system call fails Message-ID: In-Reply-To: <20260706191421.94453-1-gatlavishweshwarreddy26@gmail.com> ``` Gatla Vishweshwar Reddy writes: Make sure that v(N+1) patch is sent as a reply to vN patch, so that people who look at vN immediately notice there is a newer iteration and they should spend their time on it rather than the stale one. > When chdir() fails, the errno value contains the reason for the > failure. Using die() instead of die_errno() loses this information, > making it harder to diagnose failures. Switch to die_errno() to > include the system error message in the output. > > Signed-off-by: Gatla Vishweshwar Reddy Perfect. > --- > setup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/setup.c b/setup.c > index b4652651df..e2e98d1126 100644 > --- a/setup.c > +++ b/setup.c > @@ -1954,13 +1954,13 @@ const char *setup_git_directory_gently(struct repository *repo, int *nongit_ok) > break; > case GIT_DIR_DISCOVERED: > if (dir.len < cwd.len && chdir(dir.buf)) > - die(_("cannot change to '%s'"), dir.buf); > + die_errno(_("cannot change to '%s'"), dir.buf); > prefix = setup_discovered_git_dir(repo, gitdir.buf, &cwd, dir.len, > &repo_fmt, nongit_ok); > break; > case GIT_DIR_BARE: > if (dir.len < cwd.len && chdir(dir.buf)) > - die(_("cannot change to '%s'"), dir.buf); > + die_errno(_("cannot change to '%s'"), dir.buf); > prefix = setup_bare_git_dir(repo, &cwd, dir.len, &repo_fmt, nongit_ok); > break; > case GIT_DIR_HIT_CEILING: Will queue. Thanks. ```