# Re: [PATCH v3] SubmittingPatches: address design critiques

2 messages from 2026-06-19 to 2026-06-20. Participants: Michael Montalbo, Junio C Hamano.
Thread: https://gitlist.dev/t/65844

## Michael Montalbo, 2026-06-19 22:40

Subject: Re: [PATCH v3] SubmittingPatches: address design critiques
Message-ID: <CAC2Qwm+WcGkd9pAV5=JL1hfCDRisGQRFmdfOsMTrMWyx7aa65A@mail.gmail.com>

```
Junio C Hamano <gitster@pobox.com> writes:
> +Be particularly mindful of critiques regarding the high-level design
> +or viability of your proposal (e.g., questioning if the feature is
> +worth implementing, or if the chosen approach is appropriate).  Defend
> +your design decisions on the list first, work with reviewers and other
> +members to improve the design before revising the implementation, to
> +avoid wasting effort on an implementation before its design is solid.

Slight reflow suggestions:

  Defend your design decisions on the list first; work with reviewers and
  other members to improve the design before revising the implementation.
  This will avoid wasting effort on an implementation before its design is
  solid.

The rest looks good to me!

```

## Junio C Hamano, 2026-06-20 14:09

Subject: Re: [PATCH v3] SubmittingPatches: address design critiques
Message-ID: <xmqqqzm1gv76.fsf@gitster.g>
In-Reply-To: <CAC2Qwm+WcGkd9pAV5=JL1hfCDRisGQRFmdfOsMTrMWyx7aa65A@mail.gmail.com>

```
Michael Montalbo <mmontalbo@gmail.com> writes:

> Slight reflow suggestions:
>
>   Defend your design decisions on the list first; work with reviewers and
>   other members to improve the design before revising the implementation.
>   This will avoid wasting effort on an implementation before its design is
>   solid.

Yeah, making the last part a separate sentence does make it much
easier to follow.  Will use.

Thanks.

```
