{"thread":{"id":"6584","subject":"t9200-git-cvsexportcommit #8 failure on OS X","startedAt":"2007-01-30T16:32:19Z","lastAt":"2007-01-31T22:36:37Z","messageCount":9,"participants":["Brian Gernhardt","Robin Rosenberg","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"33048","messageId":"20070130163219.GA14431@164.242.249.10.in-addr.arpa","threadId":"6584","inReplyTo":null,"subject":"t9200-git-cvsexportcommit #8 failure on OS X","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-01-30T16:32:19Z","receivedAt":"2007-01-30T16:32:19Z","isPatch":false,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"* expecting success: mkdir -p ?/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/?/?/? &&\n      echo Foo >?/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/?/?/?/g?rdets?g?rdet.txt &&\n      git add ?/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/?/?/?/g?rdets?g?rdet.txt &&\n      cp ../test9200a.png ?/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/?/?/?/g?rdets?g?rdet.png &&\n      git add ?/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/?/?/?/g?rdets?g?rdet.png &&\n      git commit -a -m \"G?r det s? g?r det\" && \\\n      id=$(git rev-list --max-count=1 HEAD) &&\n      (cd \"$CVSWORK\" &&\n      git-cvsexportcommit -v -c $id &&\n      test \"$(echo $(sort ?/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/?/?/?/CVS/Entries|cut -d/ -f2,3,5))\" = \"g?rdets?g?rdet.png/1.1/-kb g?rdets?g?rdet.txt/1.1/\"\n      )\nmkdir: ?: Invalid argument\n\nIt looks like one of the odd characters that git's using for the test is\nan invalid character for HFS+, so the entire test fails.  Perhaps this\nshould be made a \"soft\" failure like all of the SVN tests passing\ndespite me not having SVN installed, or should a different character be\nused somewhere?  Git can't possibly be expected to work in a situation\nwhere the FS fails.\n\n~~ Brian\n"},{"id":"33090","messageId":"200701302320.02187.robin.rosenberg.lists@dewire.com","threadId":"6584","inReplyTo":"20070130163219.GA14431@164.242.249.10.in-addr.arpa","subject":"Re: t9200-git-cvsexportcommit #8 failure on OS X","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-01-30T22:20:00Z","receivedAt":"2007-01-30T22:20:00Z","isPatch":false,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"tisdag 30 januari 2007 17:32 skrev Brian Gernhardt:\n[...]\n> mkdir: ?: Invalid argument\n>\n> It looks like one of the odd characters that git's using for the test is\n> an invalid character for HFS+, so the entire test fails.  Perhaps this\n> should be made a \"soft\" failure like all of the SVN tests passing\n> despite me not having SVN installed, or should a different character be\n> used somewhere?  Git can't possibly be expected to work in a situation\n> where the FS fails.\n\nMy fault. The problem is that the data is ISO-8859-1, which is invalid\nwhen interpreted as UTF-8.  Another user reported the same problem in cygwin \non a Korean Windows. The byte sequences are illegal there too.\n\nA number of solution could be concieved, like converting to the local encoding \nfirst, but that cannot be done beacuase I couldn't find any non-ascii \ncharacters that would be convertible into any (major) locale. \n\nAnother is to ignore the test if these files cannot be created.\n\n-- robin\n"},{"id":"33093","messageId":"20070130224446.28311.31828.stgit@lathund.dewire.com","threadId":"6584","inReplyTo":"20070130163219.GA14431@164.242.249.10.in-addr.arpa","subject":"[PATCH] Fail softly if file system does not like test data.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2007-01-30T22:49:08Z","receivedAt":"2007-01-30T22:49:08Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"Most unix file system allow almost any byte sequence, but other may reject\nsequences that are not valid according to the locale. This change makes\nfailure somewhat less likely by using UTF-8-encoded characters (which\nhappen to be valid interpreted as ISO-8859-1 and skips the test if the \nlocal file system does not support the test data.\n\nSigned-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n\nPlease try this on cygwin (western iso-8859-X, korean on FAT & NTFS) and \nMacOSX (HFS) where we know there was a problem. The non-ascii filename\ntest should be skipped, with a notice) in most asian locales on Windows\nand MacOSX.\n\n t/t9200-git-cvsexportcommit.sh |   35 +++++++++++++++++++++--------------\n 1 files changed, 21 insertions(+), 14 deletions(-)\n\ndiff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\nindex fd0a554..fdf7b3f 100755\n--- a/t/t9200-git-cvsexportcommit.sh\n+++ b/t/t9200-git-cvsexportcommit.sh\n@@ -169,20 +169,27 @@ test_expect_success \\\n       test \"$(echo $(sort \"G g/CVS/Entries\"|cut -d/ -f2,3,5))\" = \"with spaces.png/1.2/-kb with spaces.txt/1.2/\"\n       )'\n \n-# This test contains ISO-8859-1 characters\n-test_expect_success \\\n-     'File with non-ascii file name' \\\n-     'mkdir -p �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/� &&\n-      echo Foo >�/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&\n-      git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&\n-      cp ../test9200a.png �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&\n-      git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&\n-      git commit -a -m \"G�r det s� g�r det\" && \\\n-      id=$(git rev-list --max-count=1 HEAD) &&\n-      (cd \"$CVSWORK\" &&\n-      git-cvsexportcommit -v -c $id &&\n-      test \"$(echo $(sort �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/CVS/Entries|cut -d/ -f2,3,5))\" = \"g�rdets�g�rdet.png/1.1/-kb g�rdets�g�rdet.txt/1.1/\"\n-      )'\n+# This test contains UTF-8 characters and may fail on some filesystems\n+mkdir -p \"/å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö\" >/dev/null 2>&1\n+if test $? -ne 0\n+then\n+    test_expect_success 'File with non-ascii file name skipped, file system is incompatible with test data' :\n+else\n+    test_expect_success \\\n+\t'File with non-ascii file name' \\\n+\t'(mkdir -p \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö\" ||\n+         echo \"Local filesystem does not permit this test\" ) &&\n+         echo Foo >\"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n+         git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n+         cp ../test9200a.png \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n+         git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n+         git commit -a -m \"Går det så går det\" && \\\n+         id=$(git rev-list --max-count=1 HEAD) &&\n+         (cd \"$CVSWORK\" &&\n+         git-cvsexportcommit -v -c $id &&\n+         test \"$(echo $(sort \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/CVS/Entries\"|cut -d/ -f2,3,5))\" = \"gårdetsågårdet.png/1.1/-kb gårdetsågårdet.txt/1.1/\"\n+         )'\n+fi\n \n test_expect_success \\\n      'Mismatching patch should fail' \\\n"},{"id":"33095","messageId":"64949F2D-6A6D-4373-8B7F-C8F75529CD2E@silverinsanity.com","threadId":"6584","inReplyTo":"20070130224446.28311.31828.stgit@lathund.dewire.com","subject":"Re: [PATCH] Fail softly if file system does not like test data.","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-01-30T23:28:34Z","receivedAt":"2007-01-30T23:28:34Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Jan 30, 2007, at 5:49 PM, Robin Rosenberg wrote:\n\n> Most unix file system allow almost any byte sequence, but other may  \n> reject\n> sequences that are not valid according to the locale. This change  \n> makes\n> failure somewhat less likely by using UTF-8-encoded characters (which\n> happen to be valid interpreted as ISO-8859-1 and skips the test if the\n> local file system does not support the test data.\n>\n> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n> ---\n>\n> Please try this on cygwin (western iso-8859-X, korean on FAT &  \n> NTFS) and\n> MacOSX (HFS) where we know there was a problem. The non-ascii filename\n> test should be skipped, with a notice) in most asian locales on  \n> Windows\n> and MacOSX.\n\nDoesn't work, but it's closer.  I can't see where a .gitignore is  \ngetting set, though.\n\n* expecting success: (mkdir -p \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ \nq/r/s/t/u/v/w/x/y/z/å/ä/ö\" ||\n          echo \"Local filesystem does not permit this test\" ) &&\n          echo Foo >\"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/ \nv/w/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n          git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/ \nw/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n          cp ../test9200a.png \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ \nq/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n          git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/ \nw/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n          git commit -a -m \"Går det så går det\" && \\\n          id=$(git rev-list --max-count=1 HEAD) &&\n          (cd \"$CVSWORK\" &&\n          git-cvsexportcommit -v -c $id &&\n          test \"$(echo $(sort \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ \nq/r/s/t/u/v/w/x/y/z/å/ä/ö/CVS/Entries\"|cut -d/ -f2,3,5))\" =  \n\"gårdetsågårdet.png/1.1/-kb gårdetsågårdet.txt/1.1/\"\n          )\nThe following paths are ignored by one of your .gitignore files:\nå/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/ \ngårdetsågårdet.txt\nUse -f if you really want to add them.\n* FAIL 8: File with non-ascii file name\n"},{"id":"33096","messageId":"200701310110.04429.robin.rosenberg.lists@dewire.com","threadId":"6584","inReplyTo":"20070130224446.28311.31828.stgit@lathund.dewire.com","subject":"Re: [PATCH] Fail softly if file system does not like test data.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-01-31T00:10:03Z","receivedAt":"2007-01-31T00:10:03Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"    Most unix file system allow almost any byte sequence, but other may reject\n    sequences that are not valid according to the locale. This change makes\n    failure somewhat less likely by using UTF-8-encoded characters and skips\n    the test if the local file system does not support the test data.\n    \n    Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>\n---\n\nThe first version of the patch had two errors. First it had a slash too much, then\nit did not clean up after test for applicability and then it was sent UTF-8 encoded\nwhich is wrong for non-utf8 systems. The patch is ment to actually have the\nUTF-8 byte sequences and not be translated (it should work regardless on most\nsystems).\n\n t/t9200-git-cvsexportcommit.sh |   37 +++++++++++++++++++++++--------------\n 1 files changed, 23 insertions(+), 14 deletions(-)\n\ndiff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\nindex fd0a554..d0d5365 100755\n--- a/t/t9200-git-cvsexportcommit.sh\n+++ b/t/t9200-git-cvsexportcommit.sh\n@@ -169,20 +169,29 @@ test_expect_success \\\n       test \"$(echo $(sort \"G g/CVS/Entries\"|cut -d/ -f2,3,5))\" = \"with spaces.png/1.2/-kb with spaces.txt/1.2/\"\n       )'\n \n-# This test contains ISO-8859-1 characters\n-test_expect_success \\\n-     'File with non-ascii file name' \\\n-     'mkdir -p �goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/���&&\n-      echo Foo >�goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/���g�dets��det.txt &&\n-      git add �goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/���g�dets��det.txt &&\n-      cp ../test9200a.png �goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/���g�dets��det.png &&\n-      git add �goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/���g�dets��det.png &&\n-      git commit -a -m \"G� det s�g� det\" && \\\n-      id=$(git rev-list --max-count=1 HEAD) &&\n-      (cd \"$CVSWORK\" &&\n-      git-cvsexportcommit -v -c $id &&\n-      test \"$(echo $(sort �goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/���CVS/Entries|cut -d/ -f2,3,5))\" = \"g�dets��det.png/1.1/-kb g�dets��det.txt/1.1/\"\n-      )'\n+# This test contains UTF-8 characters and may fail on some filesystems\n+mkdir -p \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö\" >/dev/null 2>&1\n+if test $? -ne 0\n+then\n+    test_expect_success 'File with non-ascii file name skipped, file system is incompatible with test data' :\n+    rm -rf \"å\"\n+else\n+    rm -rf \"å\"\n+    test_expect_success \\\n+\t'File with non-ascii file name' \\\n+\t'(mkdir -p \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö\" ||\n+         echo \"Local filesystem does not permit this test\" ) &&\n+         echo Foo >\"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n+         git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n+         cp ../test9200a.png \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n+         git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n+         git commit -a -m \"Går det så går det\" && \\\n+         id=$(git rev-list --max-count=1 HEAD) &&\n+         (cd \"$CVSWORK\" &&\n+         git-cvsexportcommit -v -c $id &&\n+         test \"$(echo $(sort \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/CVS/Entries\"|cut -d/ -f2,3,5))\" = \"gårdetsågårdet.png/1.1/-kb gårdetsågårdet.txt/1.1/\"\n+         )'\n+fi\n \n test_expect_success \\\n      'Mismatching patch should fail' \\\n"},{"id":"33098","messageId":"200701310114.38258.robin.rosenberg@dewire.com","threadId":"6584","inReplyTo":"64949F2D-6A6D-4373-8B7F-C8F75529CD2E@silverinsanity.com","subject":"Re: [PATCH] Fail softly if file system does not like test data.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2007-01-31T00:14:37Z","receivedAt":"2007-01-31T00:14:37Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"onsdag 31 januari 2007 00:28 skrev Brian Gernhardt:\n> Doesn't work, but it's closer.  I can't see where a .gitignore is\n> getting set, though.\n\nI did not create any .gitignore files, so I have no explanation at this time.\n\n-- robin\n"},{"id":"33111","messageId":"873A97D5-C343-435F-B51B-55F599AC46D0@silverinsanity.com","threadId":"6584","inReplyTo":"200701310114.38258.robin.rosenberg@dewire.com","subject":"Re: [PATCH] Fail softly if file system does not like test data.","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2007-01-31T05:39:36Z","receivedAt":"2007-01-31T05:39:36Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Jan 30, 2007, at 7:14 PM, Robin Rosenberg wrote:\n\n> onsdag 31 januari 2007 00:28 skrev Brian Gernhardt:\n>> Doesn't work, but it's closer.  I can't see where a .gitignore is\n>> getting set, though.\n>\n> I did not create any .gitignore files, so I have no explanation at  \n> this time.\n\nFirst off, I couldn't get your patch to apply (atop master and next)  \nand I don't know why.  I did the change manually though, and still  \ngot the same error.  I'm not seeing a .gitignore either, so I have no  \nidea why the error is showing up.  Anyone else have a guess?\n\n* expecting success: (mkdir -p \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ \nq/r/s/t/u/v/w/x/y/z/å/ä/ö\" ||\n          echo \"Local filesystem does not permit this test\" ) &&\n          echo Foo >\"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/ \nv/w/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n          git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/ \nw/x/y/z/å/ä/ö/gårdetsågårdet.txt\" &&\n          cp ../test9200a.png \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ \nq/r/s/t/u/v/w/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n          git add \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/ \nw/x/y/z/å/ä/ö/gårdetsågårdet.png\" &&\n          git commit -a -m \"Går det så går det\" && \\\n          id=$(git rev-list --max-count=1 HEAD) &&\n          (cd \"$CVSWORK\" &&\n          git-cvsexportcommit -v -c $id &&\n          test \"$(echo $(sort \"å/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/ \nq/r/s/t/u/v/w/x/y/z/å/ä/ö/CVS/Entries\"|cut -d/ -f2,3,5))\" =  \n\"gårdetsågårdet.png/1.1/-kb gårdetsågårdet.txt/1.1/\"\n          )\nThe following paths are ignored by one of your .gitignore files:\nå/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/å/ä/ö/ \ngårdetsågårdet.txt\nUse -f if you really want to add them.\n\n~~ Brian\n"},{"id":"33179","messageId":"7viremu9gw.fsf@assigned-by-dhcp.cox.net","threadId":"6584","inReplyTo":"200701310110.04429.robin.rosenberg.lists@dewire.com","subject":"Re: [PATCH] Fail softly if file system does not like test data.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-31T22:17:51Z","receivedAt":"2007-01-31T22:17:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Your patch does not seem to apply.  I wonder if the test path\nneeds to be that looooooooooooong to begin with.\n\nOne thing I noticed on Cygwin is that from inside Cygwin\nenvironment t/trash directory becomes unremovable after the\noriginal test fails.\n\nI am wondering what use it would be to have ISO-8859-1 pathnames\nin our test.  As far as the test is concerned I think the point\nis to try non-ASCII paths, so I suspect this patch might be less\nof an impact.\n\nSorry for sending an attachement but in this case the patch text\nis _not_ in any particular encoding (the preimage is ISO-8859-1\nbut the postimage is in UTF-8) and transferring it as a textual\npatch over e-mail is not possible without a way to annotate each\nline which encoding it is in.\n\n\n\ndiff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh\nindex fd0a554..cc0a254 100755\n--- a/t/t9200-git-cvsexportcommit.sh\n+++ b/t/t9200-git-cvsexportcommit.sh\n@@ -169,19 +169,19 @@ test_expect_success \\\n       test \"$(echo $(sort \"G g/CVS/Entries\"|cut -d/ -f2,3,5))\" = \"with spaces.png/1.2/-kb with spaces.txt/1.2/\"\n       )'\n \n-# This test contains ISO-8859-1 characters\n+# This test contains UTF-8 characters\n test_expect_success \\\n      'File with non-ascii file name' \\\n-     'mkdir -p �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/� &&\n-      echo Foo >�/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&\n-      git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&\n-      cp ../test9200a.png �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&\n-      git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&\n-      git commit -a -m \"G�r det s� g�r det\" && \\\n+     'mkdir -p ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/�� &&\n+      echo Foo >��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.txt &&\n+      git add ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.txt &&\n+      cp ../test9200a.png ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.png &&\n+      git add ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.png &&\n+      git commit -a -m \"G��r det s�� g��r det\" && \\\n       id=$(git rev-list --max-count=1 HEAD) &&\n       (cd \"$CVSWORK\" &&\n       git-cvsexportcommit -v -c $id &&\n-      test \"$(echo $(sort �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/CVS/Entries|cut -d/ -f2,3,5))\" = \"g�rdets�g�rdet.png/1.1/-kb g�rdets�g�rdet.txt/1.1/\"\n+      test \"$(echo $(sort ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/CVS/Entries|cut -d/ -f2,3,5))\" = \"g��rdets��g��rdet.png/1.1/-kb g��rdets��g��rdet.txt/1.1/\"\n       )'\n \n test_expect_success \\\n"},{"id":"33180","messageId":"200701312336.37923.robin.rosenberg.lists@dewire.com","threadId":"6584","inReplyTo":"7viremu9gw.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fail softly if file system does not like test data.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-01-31T22:36:37Z","receivedAt":"2007-01-31T22:36:37Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"onsdag 31 januari 2007 23:17 skrev Junio C Hamano:\n> Your patch does not seem to apply.  I wonder if the test path\n> needs to be that looooooooooooong to begin with.\nNot really. I had some thought when I did it, but can't recall what it was. \nPerhaps I wanted to verify that the data I was reading from git-diff wasn't \ntruncated. I've pruned that part of memory.\n\n> One thing I noticed on Cygwin is that from inside Cygwin\n> environment t/trash directory becomes unremovable after the\n> original test fails.\n\none more interesting thing..\n\n> I am wondering what use it would be to have ISO-8859-1 pathnames\n> in our test.  As far as the test is concerned I think the point\n> is to try non-ASCII paths, so I suspect this patch might be less\n> of an impact.\nYes. Anything non-ascii will do.\n\n> Sorry for sending an attachement but in this case the patch text\n> is _not_ in any particular encoding (the preimage is ISO-8859-1\n> but the postimage is in UTF-8) and transferring it as a textual\n> patch over e-mail is not possible without a way to annotate each\n> line which encoding it is in.\n\nThat patch didn't apply here, not even  Lets try the old uuencode format. \n(this is my patch once again wrapped by uuencode).\n\n-- robin\n\n\n\nbegin 644 patch.uu\nM8V]M;6ET(#AE-V(W,38P-#@S.3`U,F9F-6-F-S1E-SAD,C=F865B,60Q930W\nM.3(*075T:&]R.B!2;V)I;B!2;W-E;F)E<F<@/')O8FEN+G)O<V5N8F5R9T!D\nM97=I<F4N8V]M/@I$871E.B`@(%=E9\"!*86X@,S$@,C(Z,#,Z,#(@,C`P-R`K\nM,#$P,`H*(\"`@($9A:6P@<V]F=&QY(&EF(&9I;&4@<WES=&5M(&1O97,@;F]T\nM(&QI:V4@=&5S=\"!D871A+@H@(\"`@\"B`@(\"!-;W-T('5N:7@@9FEL92!S>7-T\nM96T@86QL;W<@86QM;W-T(&%N>2!B>71E('-E<75E;F-E+\"!B=70@;W1H97(@\nM;6%Y(')E:F5C=`H@(\"`@<V5Q=65N8V5S('1H870@87)E(&YO=\"!V86QI9\"!A\nM8V-O<F1I;F<@=&\\@=&AE(&QO8V%L92X@5&AI<R!C:&%N9V4@;6%K97,*(\"`@\nM(&9A:6QU<F4@<V]M97=H870@;&5S<R!L:6ME;'D@8GD@=7-I;F<@551&+3@M\nM96YC;V1E9\"!C:&%R86-T97)S(&%N9\"!S:VEP<PH@(\"`@=&AE('1E<W0@:68@\nM=&AE(&QO8V%L(&9I;&4@<WES=&5M(&1O97,@;F]T('-U<'!O<G0@=&AE('1E\nM<W0@9&%T82X*(\"`@(`H@(\"`@4VEG;F5D+6]F9BUB>3H@4F]B:6X@4F]S96YB\nM97)G(#QR;V)I;BYR;W-E;F)E<F=`9&5W:7)E+F-O;3X*+2TM\"B!T+W0Y,C`P\nM+6=I=\"UC=G-E>'!O<G1C;VUM:70N<V@@?\"`@(#,W(\"LK*RLK*RLK*RLK*RLK\nM*RLK*RLK*RLK+2TM+2TM+2TM+2TM+2T*(#$@9FEL97,@8VAA;F=E9\"P@,C,@\nM:6YS97)T:6]N<R@K*2P@,30@9&5L971I;VYS*\"TI\"@ID:69F(\"TM9VET(&$O\nM=\"]T.3(P,\"UG:70M8W9S97AP;W)T8V]M;6ET+G-H(&(O=\"]T.3(P,\"UG:70M\nM8W9S97AP;W)T8V]M;6ET+G-H\"FEN9&5X(&9D,&$U-30N+F0P9#4S-C4@,3`P\nM-S4U\"BTM+2!A+W0O=#DR,#`M9VET+6-V<V5X<&]R=&-O;6UI=\"YS:`HK*RL@\nM8B]T+W0Y,C`P+6=I=\"UC=G-E>'!O<G1C;VUM:70N<V@*0$`@+3$V.2PR,\"`K\nM,38Y+#(Y($!`('1E<W1?97AP96-T7W-U8V-E<W,@7`H@(\"`@(\"`@=&5S=\"`B\nM)\"AE8VAO(\"0H<V]R=\"`B1R!G+T-64R]%;G1R:65S(GQC=70@+60O(\"UF,BPS\nM+#4I*2(@/2`B=VET:\"!S<&%C97,N<&YG+S$N,B\\M:V(@=VET:\"!S<&%C97,N\nM='AT+S$N,B\\B\"B`@(\"`@(\"`I)PH@\"BTC(%1H:7,@=&5S=\"!C;VYT86EN<R!)\nM4T\\M.#@U.2TQ(&-H87)A8W1E<G,*+71E<W1?97AP96-T7W-U8V-E<W,@7`HM\nM(\"`@(\"`G1FEL92!W:71H(&YO;BUA<V-I:2!F:6QE(&YA;64G(%P*+2`@(\"`@\nM)VUK9&ER(\"UP(,4O9V]O+V$O8B]C+V0O92]F+V<O:\"]I+VHO:R]L+VTO;B]O\nM+W`O<2]R+W,O=\"]U+W8O=R]X+WDO>B_E+^0O]B`F)@HM(\"`@(\"`@96-H;R!&\nM;V\\@/L4O9V]O+V$O8B]C+V0O92]F+V<O:\"]I+VHO:R]L+VTO;B]O+W`O<2]R\nM+W,O=\"]U+W8O=R]X+WDO>B_E+^0O]B]GY7)D971SY6?E<F1E=\"YT>'0@)B8*\nM+2`@(\"`@(&=I=\"!A9&0@Q2]G;V\\O82]B+V,O9\"]E+V8O9R]H+VDO:B]K+VPO\nM;2]N+V\\O<\"]Q+W(O<R]T+W4O=B]W+W@O>2]Z+^4OY\"_V+V?E<F1E='/E9^5R\nM9&5T+G1X=\"`F)@HM(\"`@(\"`@8W`@+BXO=&5S=#DR,#!A+G!N9R#%+V=O;R]A\nM+V(O8R]D+V4O9B]G+V@O:2]J+VLO;\"]M+VXO;R]P+W$O<B]S+W0O=2]V+W<O\nM>\"]Y+WHOY2_D+_8O9^5R9&5T<^5GY7)D970N<&YG(\"8F\"BT@(\"`@(\"!G:70@\nM861D(,4O9V]O+V$O8B]C+V0O92]F+V<O:\"]I+VHO:R]L+VTO;B]O+W`O<2]R\nM+W,O=\"]U+W8O=R]X+WDO>B_E+^0O]B]GY7)D971SY6?E<F1E=\"YP;F<@)B8*\nM+2`@(\"`@(&=I=\"!C;VUM:70@+6$@+6T@(D?E<B!D970@<^4@9^5R(&1E=\"(@\nM)B8@7`HM(\"`@(\"`@:60])\"AG:70@<F5V+6QI<W0@+2UM87@M8V]U;G0],2!(\nM14%$*2`F)@HM(\"`@(\"`@*&-D(\"(D0U935T]22R(@)B8*+2`@(\"`@(&=I=\"UC\nM=G-E>'!O<G1C;VUM:70@+78@+6,@)&ED(\"8F\"BT@(\"`@(\"!T97-T(\"(D*&5C\nM:&\\@)\"AS;W)T(,4O9V]O+V$O8B]C+V0O92]F+V<O:\"]I+VHO:R]L+VTO;B]O\nM+W`O<2]R+W,O=\"]U+W8O=R]X+WDO>B_E+^0O]B]#5E,O16YT<FEE<WQC=70@\nM+60O(\"UF,BPS+#4I*2(@/2`B9^5R9&5T<^5GY7)D970N<&YG+S$N,2\\M:V(@\nM9^5R9&5T<^5GY7)D970N='AT+S$N,2\\B\"BT@(\"`@(\"`I)PHK(R!4:&ES('1E\nM<W0@8V]N=&%I;G,@551&+3@@8VAA<F%C=&5R<R!A;F0@;6%Y(&9A:6P@;VX@\nM<V]M92!F:6QE<WES=&5M<PHK;6MD:7(@+7`@(L.E+V=O;R]A+V(O8R]D+V4O\nM9B]G+V@O:2]J+VLO;\"]M+VXO;R]P+W$O<B]S+W0O=2]V+W<O>\"]Y+WHOPZ4O\nMPZ0OP[8B(#XO9&5V+VYU;&P@,CXF,0HK:68@=&5S=\"`D/R`M;F4@,`HK=&AE\nM;@HK(\"`@('1E<W1?97AP96-T7W-U8V-E<W,@)T9I;&4@=VET:\"!N;VXM87-C\nM:6D@9FEL92!N86UE('-K:7!P960L(&9I;&4@<WES=&5M(&ES(&EN8V]M<&%T\nM:6)L92!W:71H('1E<W0@9&%T82<@.@HK(\"`@(')M(\"UR9B`BPZ4B\"BME;'-E\nM\"BL@(\"`@<FT@+7)F(\"+#I2(**R`@(\"!T97-T7V5X<&5C=%]S=6-C97-S(%P*\nM*PDG1FEL92!W:71H(&YO;BUA<V-I:2!F:6QE(&YA;64G(%P**PDG*&UK9&ER\nM(\"UP(\"+#I2]G;V\\O82]B+V,O9\"]E+V8O9R]H+VDO:B]K+VPO;2]N+V\\O<\"]Q\nM+W(O<R]T+W4O=B]W+W@O>2]Z+\\.E+\\.D+\\.V(B!\\?`HK(\"`@(\"`@(\"`@96-H\nM;R`B3&]C86P@9FEL97-Y<W1E;2!D;V5S(&YO=\"!P97)M:70@=&AI<R!T97-T\nM(B`I(\"8F\"BL@(\"`@(\"`@(\"!E8VAO($9O;R`^(L.E+V=O;R]A+V(O8R]D+V4O\nM9B]G+V@O:2]J+VLO;\"]M+VXO;R]P+W$O<B]S+W0O=2]V+W<O>\"]Y+WHOPZ4O\nMPZ0OP[8O9\\.E<F1E='/#I6?#I7)D970N='AT(B`F)@HK(\"`@(\"`@(\"`@9VET\nM(&%D9\"`BPZ4O9V]O+V$O8B]C+V0O92]F+V<O:\"]I+VHO:R]L+VTO;B]O+W`O\nM<2]R+W,O=\"]U+W8O=R]X+WDO>B_#I2_#I\"_#MB]GPZ5R9&5T<\\.E9\\.E<F1E\nM=\"YT>'0B(\"8F\"BL@(\"`@(\"`@(\"!C<\"`N+B]T97-T.3(P,&$N<&YG(\"+#I2]G\nM;V\\O82]B+V,O9\"]E+V8O9R]H+VDO:B]K+VPO;2]N+V\\O<\"]Q+W(O<R]T+W4O\nM=B]W+W@O>2]Z+\\.E+\\.D+\\.V+V?#I7)D971SPZ5GPZ5R9&5T+G!N9R(@)B8*\nM*R`@(\"`@(\"`@(&=I=\"!A9&0@(L.E+V=O;R]A+V(O8R]D+V4O9B]G+V@O:2]J\nM+VLO;\"]M+VXO;R]P+W$O<B]S+W0O=2]V+W<O>\"]Y+WHOPZ4OPZ0OP[8O9\\.E\nM<F1E='/#I6?#I7)D970N<&YG(B`F)@HK(\"`@(\"`@(\"`@9VET(&-O;6UI=\"`M\nM82`M;2`B1\\.E<B!D970@<\\.E(&?#I7(@9&5T(B`F)B!<\"BL@(\"`@(\"`@(\"!I\nM9#TD*&=I=\"!R978M;&ES=\"`M+6UA>\"UC;W5N=#TQ($A%040I(\"8F\"BL@(\"`@\nM(\"`@(\"`H8V0@(B1#5E-73U)+(B`F)@HK(\"`@(\"`@(\"`@9VET+6-V<V5X<&]R\nM=&-O;6UI=\"`M=B`M8R`D:60@)B8**R`@(\"`@(\"`@('1E<W0@(B0H96-H;R`D\nM*'-O<G0@(L.E+V=O;R]A+V(O8R]D+V4O9B]G+V@O:2]J+VLO;\"]M+VXO;R]P\nM+W$O<B]S+W0O=2]V+W<O>\"]Y+WHOPZ4OPZ0OP[8O0U93+T5N=')I97,B?&-U\nM=\"`M9\"\\@+68R+#,L-2DI(B`](\")GPZ5R9&5T<\\.E9\\.E<F1E=\"YP;F<O,2XQ\nM+RUK8B!GPZ5R9&5T<\\.E9\\.E<F1E=\"YT>'0O,2XQ+R(**R`@(\"`@(\"`@(\"DG\nM\"BMF:0H@\"B!T97-T7V5X<&5C=%]S=6-C97-S(%P*(\"`@(\"`@)TUI<VUA=&-H\n9:6YG('!A=&-H('-H;W5L9\"!F86EL)R!<\"@``\n`\nend\n"}]}