# Re: [PATCH] SubmittingPatches: address design critiques 1 messages from 2026-06-18 to 2026-06-18. Participants: Michael Montalbo. Thread: https://gitlist.dev/t/65834 ## Michael Montalbo, 2026-06-18 15:17 Subject: Re: [PATCH] SubmittingPatches: address design critiques Message-ID: ``` On Wed, Jun 17, 2026 at 8:53 PM Michael Montalbo wrote: > > Junio C Hamano wrote: > > +You would want to be particularly mindful of critiques regarding the > > +high-level design or viability of your proposal (e.g., questioning > > +whether the feature is worth implementing, or if the chosen approach > > +is appropriate). You want to defend your design decisions on the list > > +first, because you do not want to spend too much effort in the > > +implementation if the design is not yet solid. > > Two small suggestions: open with a direct imperative and replace > "effort in the implementation" with "effort on the implementation". > > [B]e particularly mindful of... > ... too much effort [on] the implementation... (resending to fix threading) Maybe we can even more directly say: Do not spend too much effort on the implementation if the design is not yet solid. Be able to defend your design decisions on the list first. ```