{"thread":{"id":"65813","subject":"[PATCH] gitattributes: fix eol attribute for Perl scripts","startedAt":"2026-06-15T04:25:28Z","lastAt":"2026-06-15T15:25:38Z","messageCount":5,"participants":["Koutian Wu via GitGitGadget","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"545510","messageId":"pull.2151.git.1781497525828.gitgitgadget@gmail.com","threadId":"65813","inReplyTo":null,"subject":"[PATCH] gitattributes: fix eol attribute for Perl scripts","fromName":"Koutian Wu via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-06-15T04:25:25Z","receivedAt":"2026-06-15T04:25:28Z","isPatch":true,"body":"From: ktwu01 <ktwu01@gmail.com>\n\nThe *.pl pattern currently sets eof=lf, which is not a built-in\nattribute used for line-ending normalization.\n\nUse eol=lf instead, matching the neighboring *.perl and *.pm rules, so\nPerl scripts are checked out with LF line endings.\n\nSigned-off-by: ktwu01 <ktwu01@gmail.com>\n---\n    gitattributes: fix eol attribute for Perl scripts\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2151%2Fktwu01%2Fkw%2Ffix-pl-eol-attribute-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2151/ktwu01/kw/fix-pl-eol-attribute-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/2151\n\n .gitattributes | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.gitattributes b/.gitattributes\nindex 556322be01..26490ad60a 100644\n--- a/.gitattributes\n+++ b/.gitattributes\n@@ -2,7 +2,7 @@\n *.[ch] whitespace=indent,trail,space,incomplete diff=cpp\n *.sh whitespace=indent,trail,space,incomplete text eol=lf\n *.perl text eol=lf diff=perl\n-*.pl text eof=lf diff=perl\n+*.pl text eol=lf diff=perl\n *.pm text eol=lf diff=perl\n *.py text eol=lf diff=python\n *.bat text eol=crlf\n\nbase-commit: ea97ad8d017de0c9037451a78008a0fd60abea0c\n-- \ngitgitgadget\n"},{"id":"545517","messageId":"ai-oHtHFsyhnLDWA@pks.im","threadId":"65813","inReplyTo":"pull.2151.git.1781497525828.gitgitgadget@gmail.com","subject":"Re: [PATCH] gitattributes: fix eol attribute for Perl scripts","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-06-15T07:22:06Z","receivedAt":"2026-06-15T07:22:13Z","isPatch":true,"body":"On Mon, Jun 15, 2026 at 04:25:25AM +0000, Koutian Wu via GitGitGadget wrote:\n> From: ktwu01 <ktwu01@gmail.com>\n> \n> The *.pl pattern currently sets eof=lf, which is not a built-in\n> attribute used for line-ending normalization.\n> \n> Use eol=lf instead, matching the neighboring *.perl and *.pm rules, so\n> Perl scripts are checked out with LF line endings.\n> \n> Signed-off-by: ktwu01 <ktwu01@gmail.com>\n\nThe Signed-off-by and commit author should use your real name, if\npossible. See [1].\n\n> diff --git a/.gitattributes b/.gitattributes\n> index 556322be01..26490ad60a 100644\n> --- a/.gitattributes\n> +++ b/.gitattributes\n> @@ -2,7 +2,7 @@\n>  *.[ch] whitespace=indent,trail,space,incomplete diff=cpp\n>  *.sh whitespace=indent,trail,space,incomplete text eol=lf\n>  *.perl text eol=lf diff=perl\n> -*.pl text eof=lf diff=perl\n> +*.pl text eol=lf diff=perl\n>  *.pm text eol=lf diff=perl\n>  *.py text eol=lf diff=python\n>  *.bat text eol=crlf\n\nYeah, this looks obviously correct to me. Thanks for the fix!\n\nPatrick\n\n[1]: https://git-scm.com/docs/SubmittingPatches#real-name\n"},{"id":"545519","messageId":"pull.2151.v2.git.1781510039164.gitgitgadget@gmail.com","threadId":"65813","inReplyTo":"pull.2151.git.1781497525828.gitgitgadget@gmail.com","subject":"[PATCH v2] gitattributes: fix eol attribute for Perl scripts","fromName":"Koutian Wu via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2026-06-15T07:53:58Z","receivedAt":"2026-06-15T07:54:01Z","isPatch":true,"body":"From: Koutian Wu <ktwu01@gmail.com>\n\nThe *.pl pattern currently sets eof=lf, which is not a built-in\nattribute used for line-ending normalization.\n\nUse eol=lf instead, matching the neighboring *.perl and *.pm rules, so\nPerl scripts are checked out with LF line endings.\n\nSigned-off-by: Koutian Wu <ktwu01@gmail.com>\n---\n    gitattributes: fix eol attribute for Perl scripts\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-2151%2Fktwu01%2Fkw%2Ffix-pl-eol-attribute-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2151/ktwu01/kw/fix-pl-eol-attribute-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/2151\n\nRange-diff vs v1:\n\n 1:  92ba4d499d ! 1:  f4b4ca30c7 gitattributes: fix eol attribute for Perl scripts\n     @@\n       ## Metadata ##\n     -Author: ktwu01 <ktwu01@gmail.com>\n     +Author: Koutian Wu <ktwu01@gmail.com>\n      \n       ## Commit message ##\n          gitattributes: fix eol attribute for Perl scripts\n     @@ Commit message\n          Use eol=lf instead, matching the neighboring *.perl and *.pm rules, so\n          Perl scripts are checked out with LF line endings.\n      \n     -    Signed-off-by: ktwu01 <ktwu01@gmail.com>\n     +    Signed-off-by: Koutian Wu <ktwu01@gmail.com>\n      \n       ## .gitattributes ##\n      @@\n\n\n .gitattributes | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.gitattributes b/.gitattributes\nindex 556322be01..26490ad60a 100644\n--- a/.gitattributes\n+++ b/.gitattributes\n@@ -2,7 +2,7 @@\n *.[ch] whitespace=indent,trail,space,incomplete diff=cpp\n *.sh whitespace=indent,trail,space,incomplete text eol=lf\n *.perl text eol=lf diff=perl\n-*.pl text eof=lf diff=perl\n+*.pl text eol=lf diff=perl\n *.pm text eol=lf diff=perl\n *.py text eol=lf diff=python\n *.bat text eol=crlf\n\nbase-commit: ea97ad8d017de0c9037451a78008a0fd60abea0c\n-- \ngitgitgadget\n"},{"id":"545529","messageId":"ai-5vfY8D84UhsB4@pks.im","threadId":"65813","inReplyTo":"pull.2151.v2.git.1781510039164.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] gitattributes: fix eol attribute for Perl scripts","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2026-06-15T08:37:17Z","receivedAt":"2026-06-15T08:37:22Z","isPatch":true,"body":"On Mon, Jun 15, 2026 at 07:53:58AM +0000, Koutian Wu via GitGitGadget wrote:\n> Range-diff vs v1:\n> \n>  1:  92ba4d499d ! 1:  f4b4ca30c7 gitattributes: fix eol attribute for Perl scripts\n>      @@\n>        ## Metadata ##\n>      -Author: ktwu01 <ktwu01@gmail.com>\n>      +Author: Koutian Wu <ktwu01@gmail.com>\n>       \n>        ## Commit message ##\n>           gitattributes: fix eol attribute for Perl scripts\n>      @@ Commit message\n>           Use eol=lf instead, matching the neighboring *.perl and *.pm rules, so\n>           Perl scripts are checked out with LF line endings.\n>       \n>      -    Signed-off-by: ktwu01 <ktwu01@gmail.com>\n>      +    Signed-off-by: Koutian Wu <ktwu01@gmail.com>\n>       \n>        ## .gitattributes ##\n>       @@\n\nThanks, this version looks good to me!\n\nPatrick\n"},{"id":"545588","messageId":"xmqqa4svddvz.fsf@gitster.g","threadId":"65813","inReplyTo":"pull.2151.git.1781497525828.gitgitgadget@gmail.com","subject":"Re: [PATCH] gitattributes: fix eol attribute for Perl scripts","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-06-15T15:25:36Z","receivedAt":"2026-06-15T15:25:38Z","isPatch":true,"body":"\"Koutian Wu via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: ktwu01 <ktwu01@gmail.com>\n> ...\n> Signed-off-by: ktwu01 <ktwu01@gmail.com>\n> ---\n\nThanks.\n\nThis typo come from 1f34e0cd (.gitattributes: include `text`\nattribute for eol attributes, 2023-02-03), that added \"text\" to\nthose entries with eol=lf, which inherited from 20460635\n(.gitattributes: use the \"perl\" differ for Perl, 2018-04-26), which\ninherited it while it was adding diff=perl from 00acdbc6\n(.gitattributes: add *.pl extension for Perl, 2018-04-26) that added\nthe .pl pattern.  It is interesting that nobody seems to have\nnoticed the typo during the reviews of these three patches that\ntouched these lines ;-).\n\nBy the way, we'd prefer to interact with humans with real sounding\nnames rather than handles, especially when it is not particularly\nsecret.  Your authorship and sign-off information will blend better\nin the community if you used \"Koutian Wu\".\n\n\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2151%2Fktwu01%2Fkw%2Ffix-pl-eol-attribute-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2151/ktwu01/kw/fix-pl-eol-attribute-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/2151\n>\n>  .gitattributes | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/.gitattributes b/.gitattributes\n> index 556322be01..26490ad60a 100644\n> --- a/.gitattributes\n> +++ b/.gitattributes\n> @@ -2,7 +2,7 @@\n>  *.[ch] whitespace=indent,trail,space,incomplete diff=cpp\n>  *.sh whitespace=indent,trail,space,incomplete text eol=lf\n>  *.perl text eol=lf diff=perl\n> -*.pl text eof=lf diff=perl\n> +*.pl text eol=lf diff=perl\n>  *.pm text eol=lf diff=perl\n>  *.py text eol=lf diff=python\n>  *.bat text eol=crlf\n>\n> base-commit: ea97ad8d017de0c9037451a78008a0fd60abea0c\n"}]}