{"thread":{"id":"6580","subject":"[PATCH] blameview: Use git-cat-file to read the file content.","startedAt":"2007-01-30T07:56:49Z","lastAt":"2007-01-30T10:33:56Z","messageCount":4,"participants":["Aneesh Kumar K.V","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"33011","messageId":"45befa5a.3eba48a4.1e16.ffffabd9@mx.google.com","threadId":"6580","inReplyTo":"11701438112263-git-send-email-","subject":"[PATCH] blameview: Use git-cat-file to read the file content.","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2007-01-30T07:56:49Z","receivedAt":"2007-01-30T07:56:49Z","isPatch":true,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"From: Aneesh Kumar K.V <aneesh.kumar@gmail.com> - unquoted\n\nFix blameview to use git-cat-file to read the file content.\nThis make sure we show the right content when we have modified\nfile in the working directory which is not committed.\n\nSigned-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n---\n contrib/blameview/blameview.perl |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/blameview/blameview.perl b/contrib/blameview/blameview.perl\nindex e8bcb1b..8261e47 100755\n--- a/contrib/blameview/blameview.perl\n+++ b/contrib/blameview/blameview.perl\n@@ -28,7 +28,8 @@ $fileview->get_column(0)->set_spacing(0);\n $fileview->set_size_request(1024, 768);\n $fileview->set_rules_hint(1);\n \n-open(my $fh, '<', $fn)\n+my $fh;\n+open($fh, '-|', \"git cat-file blob HEAD:$fn\")\n   or die \"unable to open $fn: $!\";\n while(<$fh>) {\n   chomp;\n-- \n1.5.0.rc2.75.gdbaa0-dirty\n"},{"id":"33012","messageId":"45befa66.29cc817d.6c37.ffffa9bc@mx.google.com","threadId":"6580","inReplyTo":"11701438241247-git-send-email-","subject":"[PATCH] blameview: Support browsable functionality to blameview.","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2007-01-30T07:56:50Z","receivedAt":"2007-01-30T07:56:50Z","isPatch":true,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"From: Aneesh Kumar K.V <aneesh.kumar@gmail.com> - unquoted\n\nDouble clicking on the row  exec a new blameview with commit hash\nas argument.\n\nSigned-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n---\n contrib/blameview/blameview.perl |   23 ++++++++++++++++++++---\n 1 files changed, 20 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/blameview/blameview.perl b/contrib/blameview/blameview.perl\nindex 8261e47..8ad9bcf 100755\n--- a/contrib/blameview/blameview.perl\n+++ b/contrib/blameview/blameview.perl\n@@ -3,7 +3,17 @@\n use Gtk2 -init;\n use Gtk2::SimpleList;\n \n-my $fn = shift or die \"require filename to blame\";\n+my $hash;\n+my $fn;\n+if ( @ARGV == 1 ) {\n+\t$hash = \"HEAD\";\n+\t$fn = shift;\n+} elsif ( @ARGV == 2 ) {\n+\t$hash = shift;\n+\t$fn = shift;\n+} else {\n+\tdie \"Usage blameview [<rev>] <filename>\";\n+}\n \n Gtk2::Rc->parse_string(<<'EOS');\n style \"treeview_style\"\n@@ -27,17 +37,24 @@ $scrolled_window->add($fileview);\n $fileview->get_column(0)->set_spacing(0);\n $fileview->set_size_request(1024, 768);\n $fileview->set_rules_hint(1);\n+$fileview->signal_connect (row_activated => sub {\n+\t\tmy ($sl, $path, $column) = @_;\n+\t\tmy $row_ref = $sl->get_row_data_from_path ($path);\n+\t\tsystem(\"blameview @$row_ref[0] $fn\");\n+\t\t# $row_ref is now an array ref to the double-clicked row's data.\n+\t\t});\n \n my $fh;\n-open($fh, '-|', \"git cat-file blob HEAD:$fn\")\n+open($fh, '-|', \"git cat-file blob $hash:$fn\")\n   or die \"unable to open $fn: $!\";\n+\n while(<$fh>) {\n   chomp;\n   $fileview->{data}->[$.] = ['HEAD', '?', \"$fn:$.\", $_];\n }\n \n my $blame;\n-open($blame, '-|', qw(git blame --incremental --), $fn)\n+open($blame, '-|', qw(git blame --incremental --), $fn, $hash)\n     or die \"cannot start git-blame $fn\";\n \n Glib::IO->add_watch(fileno($blame), 'in', \\&read_blame_line);\n-- \n1.5.0.rc2.75.gdbaa0-dirty\n"},{"id":"33013","messageId":"45befa72.48e904b7.4b64.ffffd83b@mx.google.com","threadId":"6580","inReplyTo":"11701438362085-git-send-email-","subject":"[PATCH] Update git-cat-file documentation","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2007-01-30T07:56:51Z","receivedAt":"2007-01-30T07:56:51Z","isPatch":true,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"From: Aneesh Kumar K.V <aneesh.kumar@gmail.com> - unquoted\n\nUpdate git-cat-file documentation with references for different\nways of specifying <objects>\n\nSigned-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n---\n Documentation/git-cat-file.txt |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt\nindex 7e90ce9..075c0d0 100644\n--- a/Documentation/git-cat-file.txt\n+++ b/Documentation/git-cat-file.txt\n@@ -19,7 +19,9 @@ or '-s' is used to find the object size.\n OPTIONS\n -------\n <object>::\n-\tThe sha1 identifier of the object.\n+\tThe name of the object to show.\n+\tFor a more complete list of ways to spell object names, see\n+\t\"SPECIFYING REVISIONS\" section in gitlink:git-rev-parse[1].\n \n -t::\n \tInstead of the content, show the object type identified by\n-- \n1.5.0.rc2.75.gdbaa0-dirty\n"},{"id":"33031","messageId":"7vfy9s248b.fsf@assigned-by-dhcp.cox.net","threadId":"6580","inReplyTo":"45befa66.29cc817d.6c37.ffffa9bc@mx.google.com","subject":"Re: [PATCH] blameview: Support browsable functionality to blameview.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2007-01-30T10:33:56Z","receivedAt":"2007-01-30T10:33:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Aneesh Kumar K.V\" <aneesh.kumar@gmail.com> writes:\n\n> From: Aneesh Kumar K.V <aneesh.kumar@gmail.com> - unquoted\n\nSorry, my fault.\n\n-- >8 --\n[PATCH] git-send-email: remove debugging output.\n\nrfc2047 unquoter spitted out an annoying \"- unquoted\" which was\nadded during debugging but I forgot to remove.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n git-send-email.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 8dc2ee0..6a285bf 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -408,7 +408,7 @@ sub unquote_rfc2047 {\n \t\ts/_/ /g;\n \t\ts/=([0-9A-F]{2})/chr(hex($1))/eg;\n \t}\n-\treturn \"$_ - unquoted\";\n+\treturn \"$_\";\n }\n \n sub send_message\n-- \n1.5.0.rc2.77.g1732a\n"}]}