# [PATCH] bash-completions: add --max-count-oldest

2 messages from 2026-06-10 to 2026-06-10. Participants: Mirko Faina, Junio C Hamano.
Thread: https://gitlist.dev/t/65785

## Mirko Faina, 2026-06-10 14:38

Subject: [PATCH] bash-completions: add --max-count-oldest
Message-ID: <a804828a046d8f12ef0d03eaf014807b079bb707.1781102091.git.mroik@delayed.space>

```
Add missing completion for log --max-count-oldest

Signed-off-by: Mirko Faina <mroik@delayed.space>
---
 Unfortunately I forgot to add bash completions.

 This is built upon 1ff279f340 (The 13th batch, 2026-06-09) with
 jch/mf/revision-max-count-oldest bb4ce23284 (revision.c: implement
 --max-count-oldest, 2026-05-19) merged into it.

 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index a8e7c6ddbf..e875787710 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2195,7 +2195,7 @@ __git_log_common_options="
 	--not --all
 	--branches --tags --remotes
 	--first-parent --merges --no-merges
-	--max-count=
+	--max-count= --max-count-oldest=
 	--max-age= --since= --after=
 	--min-age= --until= --before=
 	--min-parents= --max-parents=
-- 
2.54.0.505.ga804828a04


```

## Junio C Hamano, 2026-06-10 17:08

Subject: Re: [PATCH] bash-completions: add --max-count-oldest
Message-ID: <xmqqfr2uwcg8.fsf@gitster.g>
In-Reply-To: <a804828a046d8f12ef0d03eaf014807b079bb707.1781102091.git.mroik@delayed.space>

```
Mirko Faina <mroik@delayed.space> writes:

> Add missing completion for log --max-count-oldest
>
> Signed-off-by: Mirko Faina <mroik@delayed.space>
> ---
>  Unfortunately I forgot to add bash completions.

That's fine.  I think it is OK to add a new patch on top of that
series.

```
