{"thread":{"id":"65785","subject":"[PATCH] bash-completions: add --max-count-oldest","startedAt":"2026-06-10T14:46:42Z","lastAt":"2026-06-10T17:08:10Z","messageCount":2,"participants":["Mirko Faina","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"545147","messageId":"a804828a046d8f12ef0d03eaf014807b079bb707.1781102091.git.mroik@delayed.space","threadId":"65785","inReplyTo":null,"subject":"[PATCH] bash-completions: add --max-count-oldest","fromName":"Mirko Faina","fromEmail":"mroik@delayed.space","sentAt":"2026-06-10T14:38:17Z","receivedAt":"2026-06-10T14:46:42Z","isPatch":true,"body":"Add missing completion for log --max-count-oldest\n\nSigned-off-by: Mirko Faina <mroik@delayed.space>\n---\n Unfortunately I forgot to add bash completions.\n\n This is built upon 1ff279f340 (The 13th batch, 2026-06-09) with\n jch/mf/revision-max-count-oldest bb4ce23284 (revision.c: implement\n --max-count-oldest, 2026-05-19) merged into it.\n\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex a8e7c6ddbf..e875787710 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2195,7 +2195,7 @@ __git_log_common_options=\"\n \t--not --all\n \t--branches --tags --remotes\n \t--first-parent --merges --no-merges\n-\t--max-count=\n+\t--max-count= --max-count-oldest=\n \t--max-age= --since= --after=\n \t--min-age= --until= --before=\n \t--min-parents= --max-parents=\n-- \n2.54.0.505.ga804828a04\n\n"},{"id":"545173","messageId":"xmqqfr2uwcg8.fsf@gitster.g","threadId":"65785","inReplyTo":"a804828a046d8f12ef0d03eaf014807b079bb707.1781102091.git.mroik@delayed.space","subject":"Re: [PATCH] bash-completions: add --max-count-oldest","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-06-10T17:08:07Z","receivedAt":"2026-06-10T17:08:10Z","isPatch":true,"body":"Mirko Faina <mroik@delayed.space> writes:\n\n> Add missing completion for log --max-count-oldest\n>\n> Signed-off-by: Mirko Faina <mroik@delayed.space>\n> ---\n>  Unfortunately I forgot to add bash completions.\n\nThat's fine.  I think it is OK to add a new patch on top of that\nseries.\n"}]}