{"thread":{"id":"657","subject":"[PATCH] A test case addition for strbuf regression","startedAt":"2005-05-19T06:55:07Z","lastAt":"2005-05-19T06:55:07Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"3535","messageId":"7vekc3n1ro.fsf@assigned-by-dhcp.cox.net","threadId":"657","inReplyTo":null,"subject":"[PATCH] A test case addition for strbuf regression","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-19T06:55:07Z","receivedAt":"2005-05-19T06:55:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This test would have caught the strbuf eof condition gotcha,\nhopefully fixed with my previous patch.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n# - HEAD: fix strbuf take #2\n# + (working tree)\ndiff --git a/strbuf.c b/strbuf.c\ndiff --git a/t/t4000-diff-format.sh b/t/t4000-diff-format.sh\n--- a/t/t4000-diff-format.sh\n+++ b/t/t4000-diff-format.sh\n@@ -50,4 +50,13 @@ test_expect_success \\\n     'validate git-diff-files -p output.' \\\n     'cmp -s current expected'\n \n+test_expect_success \\\n+    'build same diff using git-diff-helper.' \\\n+    'git-diff-files -z | git-diff-helper -z >current'\n+\n+\n+test_expect_success \\\n+    'validate git-diff-helper output.' \\\n+    'cmp -s current expected'\n+\n test_done\n\n"}]}