# Why do we need to wait 1s between a git add and commit 3 messages from 2026-05-22 to 2026-05-22. Participants: Fabrice SALVAIRE, Kristoffer Haugsbakk. Thread: https://gitlist.dev/t/65675 ## Fabrice SALVAIRE, 2026-05-22 12:28 Subject: Why do we need to wait 1s between a git add and commit Message-ID: <36eec9c1-1d2b-4cd1-a64c-a02936d8a2ae@orange.fr> ``` Dear all, I wrote a Python tool to dump a wiki to a git repository, that does basically a succession of subprocess calls to git add and commit. Recently, I discovered this tool doesn't work any longer and that git commit (2.54 on Fedora 42 / 43) crashes randomly. I cannot explain this behavior since my code is trivial. I had the intuition to add a sleep time of 1s just after a git call, and it solves the issue. I noticed for some cases that another call to git commit were successful. For most cases, git fsck and gitk report issues. It looks like the state of the git repository was not yet completed before the end of the git subprocess. Cheers, ``` ## Kristoffer Haugsbakk, 2026-05-22 15:12 Subject: Re: Why do we need to wait 1s between a git add and commit Message-ID: In-Reply-To: <36eec9c1-1d2b-4cd1-a64c-a02936d8a2ae@orange.fr> ``` Hi On Fri, May 22, 2026, at 14:28, Fabrice SALVAIRE wrote: > I wrote a Python tool to dump a wiki to a git repository, that does > basically a succession of subprocess calls to git add and commit. > > Recently, I discovered this tool doesn't work any longer and that git > commit (2.54 on Fedora 42 / 43) crashes randomly. > > I cannot explain this behavior since my code is trivial. > > I had the intuition to add a sleep time of 1s just after a git call, and > it solves the issue. > > I noticed for some cases that another call to git commit were > successful. For most cases, git fsck and gitk report issues. > > It looks like the state of the git repository was not yet completed > before the end of the git subprocess. This might be caused by git-maintenance(1) being run in the background without locking? That’s a new issue in Git 2.54.0. See: https://lore.kernel.org/git/20260509175249.GA2336928@coredump.intra.peff.net/ The following script reproduces the issue on Git 2.53.0. I am guessing that your script does something similar? It depends on how many commits it creates in a short timeframe. https://lore.kernel.org/git/20260508180341.GB737125@coredump.intra.peff.net/ ``` ## Fabrice SALVAIRE, 2026-05-22 17:13 Subject: Re: Why do we need to wait 1s between a git add and commit Message-ID: <9767f411-ce33-43a1-aafc-5ec4f7c04593@orange.fr> In-Reply-To: ``` Hi, Yes it throws 3000+ sequential subprocess calls at the speed of Python... And the sleep time seems to be critical, 1s is ok but 100ms is not so ok. I also have the feeling this is due to a git upgrade. But I didn't test to downgrade. That is a major issue if we have to be slow while using Git... It is not unusual to write a shell script with a sequence of add/commit. Le 22/05/2026 à 17:12, Kristoffer Haugsbakk a écrit : > Hi > > On Fri, May 22, 2026, at 14:28, Fabrice SALVAIRE wrote: >> I wrote a Python tool to dump a wiki to a git repository, that does >> basically a succession of subprocess calls to git add and commit. >> >> Recently, I discovered this tool doesn't work any longer and that git >> commit (2.54 on Fedora 42 / 43) crashes randomly. >> >> I cannot explain this behavior since my code is trivial. >> >> I had the intuition to add a sleep time of 1s just after a git call, and >> it solves the issue. >> >> I noticed for some cases that another call to git commit were >> successful. For most cases, git fsck and gitk report issues. >> >> It looks like the state of the git repository was not yet completed >> before the end of the git subprocess. > This might be caused by git-maintenance(1) being run in the background > without locking? That’s a new issue in Git 2.54.0. See: > > https://lore.kernel.org/git/20260509175249.GA2336928@coredump.intra.peff.net/ > > The following script reproduces the issue on Git 2.53.0. I am guessing > that your script does something similar? It depends on how many commits > it creates in a short timeframe. > > https://lore.kernel.org/git/20260508180341.GB737125@coredump.intra.peff.net/ ```