{"thread":{"id":"65506","subject":"[PATCH tig] Fix compiler warning with latest gcc","startedAt":"2026-04-17T16:13:49Z","lastAt":"2026-04-17T19:10:18Z","messageCount":3,"participants":["Marcel Holtmann","Collin Funk"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"541826","messageId":"20260417161228.1578-1-marcel@holtmann.org","threadId":"65506","inReplyTo":null,"subject":"[PATCH tig] Fix compiler warning with latest gcc","fromName":"Marcel Holtmann","fromEmail":"marcel@holtmann.org","sentAt":"2026-04-17T16:12:28Z","receivedAt":"2026-04-17T16:13:49Z","isPatch":true,"body":"        CC  src/diff.o\nsrc/diff.c: In function ‘diff_common_add_diff_stat’:\nsrc/diff.c:191:22: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]\n  191 |         char *pipe = strchr(data, '|');\n      |                      ^~~~~~\n---\n src/diff.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/src/diff.c b/src/diff.c\nindex 6c670e4b4fb4..182ea349eb9c 100644\n--- a/src/diff.c\n+++ b/src/diff.c\n@@ -188,7 +188,7 @@ diff_common_add_diff_stat(struct view *view, const char *text, size_t offset)\n \tconst char *start = text + offset;\n \tconst char *data = start + strspn(start, \" \");\n \tsize_t len = strlen(data);\n-\tchar *pipe = strchr(data, '|');\n+\tconst char *pipe = strchr(data, '|');\n \n \t/* Ensure that '|' is present and the file name part contains\n \t * non-space characters. */\n-- \n2.53.0\n\n"},{"id":"541828","messageId":"87pl3xsfrw.fsf@gmail.com","threadId":"65506","inReplyTo":"20260417161228.1578-1-marcel@holtmann.org","subject":"Re: [PATCH tig] Fix compiler warning with latest gcc","fromName":"Collin Funk","fromEmail":"collin.funk1@gmail.com","sentAt":"2026-04-17T16:38:59Z","receivedAt":"2026-04-17T16:39:02Z","isPatch":true,"body":"Marcel Holtmann <marcel@holtmann.org> writes:\n\n>         CC  src/diff.o\n> src/diff.c: In function ‘diff_common_add_diff_stat’:\n> src/diff.c:191:22: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]\n>   191 |         char *pipe = strchr(data, '|');\n>       |                      ^~~~~~\n> ---\n>  src/diff.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/diff.c b/src/diff.c\n> index 6c670e4b4fb4..182ea349eb9c 100644\n> --- a/src/diff.c\n> +++ b/src/diff.c\n> @@ -188,7 +188,7 @@ diff_common_add_diff_stat(struct view *view, const char *text, size_t offset)\n>  \tconst char *start = text + offset;\n>  \tconst char *data = start + strspn(start, \" \");\n>  \tsize_t len = strlen(data);\n> -\tchar *pipe = strchr(data, '|');\n> +\tconst char *pipe = strchr(data, '|');\n>  \n>  \t/* Ensure that '|' is present and the file name part contains\n>  \t * non-space characters. */\n\nMinor nit about the commit message, but this is due to a glibc-2.43\nchange. It isn't related to GCC versions.\n\nCollin\n"},{"id":"541834","messageId":"DD3BAB82-DEED-486A-8A17-1B556D993588@holtmann.org","threadId":"65506","inReplyTo":"87pl3xsfrw.fsf@gmail.com","subject":"Re: [PATCH tig] Fix compiler warning with latest gcc","fromName":"Marcel Holtmann","fromEmail":"marcel@holtmann.org","sentAt":"2026-04-17T19:10:07Z","receivedAt":"2026-04-17T19:10:18Z","isPatch":true,"body":"Hi Collin,\n\n>>        CC  src/diff.o\n>> src/diff.c: In function ‘diff_common_add_diff_stat’:\n>> src/diff.c:191:22: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]\n>>  191 |         char *pipe = strchr(data, '|');\n>>      |                      ^~~~~~\n>> ---\n>> src/diff.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/src/diff.c b/src/diff.c\n>> index 6c670e4b4fb4..182ea349eb9c 100644\n>> --- a/src/diff.c\n>> +++ b/src/diff.c\n>> @@ -188,7 +188,7 @@ diff_common_add_diff_stat(struct view *view, const char *text, size_t offset)\n>> const char *start = text + offset;\n>> const char *data = start + strspn(start, \" \");\n>> size_t len = strlen(data);\n>> - char *pipe = strchr(data, '|');\n>> + const char *pipe = strchr(data, '|');\n>> \n>> /* Ensure that '|' is present and the file name part contains\n>>  * non-space characters. */\n> \n> Minor nit about the commit message, but this is due to a glibc-2.43\n> change. It isn't related to GCC versions.\n\ndo you want me to fix it and send a v2 or do you just amend it after applying the patch?\n\nRegards\n\nMarcel\n\n"}]}