{"thread":{"id":"65446","subject":"[GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","startedAt":"2026-04-06T18:30:47Z","lastAt":"2026-04-15T18:03:08Z","messageCount":8,"participants":["Trieu Huynh","Tian Yuchen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"541009","messageId":"20260406183041.783800-1-vikingtc4@gmail.com","threadId":"65446","inReplyTo":null,"subject":"[GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Trieu Huynh","fromEmail":"vikingtc4@gmail.com","sentAt":"2026-04-06T18:30:41Z","receivedAt":"2026-04-06T18:30:47Z","isPatch":true,"body":"fetch_objects() reads the promisor.quiet configuration from\nthe_repository instead of the repo parameter it receives.\n\nThis means that when git lazy-fetches objects for a non-main\nrepository, eg. a submodule that is itself a partial clone opened\nvia repo_submodule_init(). The submodule's own promisor.quiet\nsetting is ignored and the superproject's setting is used instead.\n\nFix by replacing the_repository with repo in the repo_config_get_bool()\ncall. The practical trigger is git grep --recurse-submodules on a\nsuperproject where the submodule is a partial clone.\n\nAdd a test where promisor.quiet is set only in a partial-clone\nsubmodule; a lazy fetch triggered by \"git grep --recurse-submodules\"\nmust honor that setting.\n\nSigned-off-by: Trieu Huynh <vikingtc4@gmail.com>\n---\nnit: This cleanup was explicitly noted as needed in 5d215a7b3e\n(\"promisor-remote: make promisor_remote_reinit() not depend on\nthe_repository\", 2024-10-17), where Patrick Steinhardt wrote:\n\"Those sites should eventually be cleaned up in a later patch series.\"\n\n promisor-remote.c        |  2 +-\n t/t0410-partial-clone.sh | 45 +++++++++++++++++++++++++++++++++++++++-\n 2 files changed, 45 insertions(+), 2 deletions(-)\n\ndiff --git a/promisor-remote.c b/promisor-remote.c\nindex 96fa215b06..225260b05f 100644\n--- a/promisor-remote.c\n+++ b/promisor-remote.c\n@@ -46,7 +46,7 @@ static int fetch_objects(struct repository *repo,\n \t\t     \"fetch\", remote_name, \"--no-tags\",\n \t\t     \"--no-write-fetch-head\", \"--recurse-submodules=no\",\n \t\t     \"--filter=blob:none\", \"--stdin\", NULL);\n-\tif (!repo_config_get_bool(the_repository, \"promisor.quiet\", &quiet) && quiet)\n+\tif (!repo_config_get_bool(repo, \"promisor.quiet\", &quiet) && quiet)\n \t\tstrvec_push(&child.args, \"--quiet\");\n \tif (start_command(&child))\n \t\tdie(_(\"promisor-remote: unable to fork off fetch subprocess\"));\ndiff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh\nindex 52e19728a3..dff442da20 100755\n--- a/t/t0410-partial-clone.sh\n+++ b/t/t0410-partial-clone.sh\n@@ -717,7 +717,29 @@ test_expect_success 'setup for promisor.quiet tests' '\n \tgit -C server rm foo.t &&\n \tgit -C server commit -m remove &&\n \tgit -C server config uploadpack.allowanysha1inwant 1 &&\n-\tgit -C server config uploadpack.allowfilter 1\n+\tgit -C server config uploadpack.allowfilter 1 &&\n+\n+\t# Setup for submodule repo test: superproject whose submodule is a\n+\t# partial clone, so that promisor.quiet is read via a non-main repo.\n+\trm -rf sub-pc-src sub-pc-srv.bare super-src super-work &&\n+\tgit init sub-pc-src &&\n+\ttest_commit -C sub-pc-src initial file.txt \"hello\" &&\n+\n+\tgit clone --bare sub-pc-src sub-pc-srv.bare &&\n+\tgit -C sub-pc-srv.bare config uploadpack.allowfilter 1 &&\n+\tgit -C sub-pc-srv.bare config uploadpack.allowanysha1inwant 1 &&\n+\n+\tgit init super-src &&\n+\tgit -C super-src -c protocol.file.allow=always \\\n+\t\tsubmodule add \"file://$(pwd)/sub-pc-srv.bare\" sub &&\n+\tgit -C super-src commit -m \"add submodule\" &&\n+\n+\tgit -c protocol.file.allow=always clone super-src super-work &&\n+\tgit -C super-work -c protocol.file.allow=always \\\n+\t\tsubmodule update --init --filter=blob:none sub &&\n+\n+\t# Allow file:// in the submodule so that lazy-fetch subprocesses work.\n+\tgit -C super-work/sub config protocol.file.allow always\n '\n \n test_expect_success TTY 'promisor.quiet=false shows progress messages' '\n@@ -752,6 +774,27 @@ test_expect_success TTY 'promisor.quiet=unconfigured shows progress messages' '\n \tgrep \"Receiving objects\" err\n '\n \n+test_expect_success 'promisor.quiet from submodule repo is honored' '\n+\trm -f pc-quiet-trace &&\n+\n+\t# Set promisor.quiet only in the submodule, not the superproject.\n+\tgit -C super-work/sub config promisor.quiet true &&\n+\n+\t# Push a new commit+blob to the server; the blob stays missing in the\n+\t# partial-clone submodule until a lazy fetch is triggered.\n+\ttest_commit -C sub-pc-src updated new-file.txt \"world\" &&\n+\tgit -C sub-pc-src push \"$(pwd)/sub-pc-srv.bare\" HEAD:master &&\n+\tgit -C super-work/sub -c protocol.file.allow=always fetch origin &&\n+\tgit -C super-work/sub reset --mixed origin/master &&\n+\n+\t# grep descends into the submodule and triggers a lazy fetch for the\n+\t# missing blob; verify the fetch subprocess carries --quiet.\n+\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n+\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n+\t\t2>/dev/null &&\n+\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n+'\n+\n . \"$TEST_DIRECTORY\"/lib-httpd.sh\n start_httpd\n \n-- \n2.43.0\n\n"},{"id":"541161","messageId":"fbe81fee-ef1a-499e-bf53-d6f1761bb30e@malon.dev","threadId":"65446","inReplyTo":"20260406183041.783800-1-vikingtc4@gmail.com","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Tian Yuchen","fromEmail":"cat@malon.dev","sentAt":"2026-04-08T17:48:59Z","receivedAt":"2026-04-08T17:49:09Z","isPatch":true,"body":"On 4/7/26 02:30, Trieu Huynh wrote:\n\nI strongly recommend you to run a patch locally before sending it.\n\n\tnot ok 38 - promisor.quiet from submodule repo is honored\n\n> +test_expect_success 'promisor.quiet from submodule repo is honored' '\n> +\trm -f pc-quiet-trace &&\n> +\n> +\t# Set promisor.quiet only in the submodule, not the superproject.\n> +\tgit -C super-work/sub config promisor.quiet true &&\n> +\n> +\t# Push a new commit+blob to the server; the blob stays missing in the\n> +\t# partial-clone submodule until a lazy fetch is triggered.\n> +\ttest_commit -C sub-pc-src updated new-file.txt \"world\" &&\n> +\tgit -C sub-pc-src push \"$(pwd)/sub-pc-srv.bare\" HEAD:master &&\n> +\tgit -C super-work/sub -c protocol.file.allow=always fetch origin &&\n> +\tgit -C super-work/sub reset --mixed origin/master &&\n> +\n> +\t# grep descends into the submodule and triggers a lazy fetch for the\n> +\t# missing blob; verify the fetch subprocess carries --quiet.\n> +\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n> +\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n> +\t\t2>/dev/null &&\n> +\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n> +'\n> +\n>   . \"$TEST_DIRECTORY\"/lib-httpd.sh\n>   start_httpd\n>   \n\nRegards, Yuchen\n\n"},{"id":"541163","messageId":"84ca1cfa-a8b8-4426-b610-c9bc24843c25@gmail.com","threadId":"65446","inReplyTo":"20260406183041.783800-1-vikingtc4@gmail.com","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Tian Yuchen","fromEmail":"a3205153416@gmail.com","sentAt":"2026-04-08T17:53:29Z","receivedAt":"2026-04-08T17:53:33Z","isPatch":true,"body":"On 4/7/26 02:30, Trieu Huynh wrote:\n\nI strongly recommend you to run a patch locally before sending it.\n\n\t not ok 38 - promisor.quiet from submodule repo is honored\n\n> +test_expect_success 'promisor.quiet from submodule repo is honored' '\n> +\trm -f pc-quiet-trace &&\n> +\n> +\t# Set promisor.quiet only in the submodule, not the superproject.\n> +\tgit -C super-work/sub config promisor.quiet true &&\n> +\n> +\t# Push a new commit+blob to the server; the blob stays missing in the\n> +\t# partial-clone submodule until a lazy fetch is triggered.\n> +\ttest_commit -C sub-pc-src updated new-file.txt \"world\" &&\n> +\tgit -C sub-pc-src push \"$(pwd)/sub-pc-srv.bare\" HEAD:master &&\n> +\tgit -C super-work/sub -c protocol.file.allow=always fetch origin &&\n> +\tgit -C super-work/sub reset --mixed origin/master &&\n> +\n> +\t# grep descends into the submodule and triggers a lazy fetch for the\n> +\t# missing blob; verify the fetch subprocess carries --quiet.\n> +\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n> +\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n> +\t\t2>/dev/null &&\n> +\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n> +'\n> +\n>   . \"$TEST_DIRECTORY\"/lib-httpd.sh\n>   start_httpd\n>   \n\nRegards, Yuchen\n"},{"id":"541167","messageId":"xmqqzf3dxqdy.fsf@gitster.g","threadId":"65446","inReplyTo":"fbe81fee-ef1a-499e-bf53-d6f1761bb30e@malon.dev","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-04-08T18:23:37Z","receivedAt":"2026-04-08T18:23:39Z","isPatch":true,"body":"Tian Yuchen <cat@malon.dev> writes:\n\n> On 4/7/26 02:30, Trieu Huynh wrote:\n>\n> I strongly recommend you to run a patch locally before sending it.\n>\n> \tnot ok 38 - promisor.quiet from submodule repo is honored\n\nFWIW, I didn't see it fail in my local environment (both in 'seen'\nand also standalone) or at GitHub CI (in 'seen'), so it is a bit\nhasty to conclude that the patch was sent without proper testing.\n\nI wonder what is different in _your_ environment (note, I am not\nsaying your environment is _wrong_.  It is just different, perhaps\nthe compiler I use and your build environment may align things\ndifferently, or perhaps on-stack \"uninitialied\" pieces of memory\nhappen to have different values that the code is reading that causes\ndifferent behaviours---in which case it is the code that is wrong.\nAsking for environment differences is the first step to figure out\nwhat incorrect environment dependencies the code has).\n\n>> +test_expect_success 'promisor.quiet from submodule repo is honored' '\n>> +\trm -f pc-quiet-trace &&\n>> +\n>> +\t# Set promisor.quiet only in the submodule, not the superproject.\n>> +\tgit -C super-work/sub config promisor.quiet true &&\n>> +\n>> +\t# Push a new commit+blob to the server; the blob stays missing in the\n>> +\t# partial-clone submodule until a lazy fetch is triggered.\n>> +\ttest_commit -C sub-pc-src updated new-file.txt \"world\" &&\n>> +\tgit -C sub-pc-src push \"$(pwd)/sub-pc-srv.bare\" HEAD:master &&\n>> +\tgit -C super-work/sub -c protocol.file.allow=always fetch origin &&\n>> +\tgit -C super-work/sub reset --mixed origin/master &&\n>> +\n>> +\t# grep descends into the submodule and triggers a lazy fetch for the\n>> +\t# missing blob; verify the fetch subprocess carries --quiet.\n>> +\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n>> +\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n>> +\t\t2>/dev/null &&\n>> +\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n>> +'\n>> +\n>>   . \"$TEST_DIRECTORY\"/lib-httpd.sh\n>>   start_httpd\n>>   \n>\n> Regards, Yuchen\n\n\n"},{"id":"541196","messageId":"a6382ad3-6ce4-4e85-bdff-8e90068f25dd@malon.dev","threadId":"65446","inReplyTo":"xmqqzf3dxqdy.fsf@gitster.g","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Tian Yuchen","fromEmail":"cat@malon.dev","sentAt":"2026-04-09T04:34:47Z","receivedAt":"2026-04-09T04:34:53Z","isPatch":true,"body":"On 4/9/26 02:23, Junio C Hamano wrote:\n\n> FWIW, I didn't see it fail in my local environment (both in 'seen'\n> and also standalone) or at GitHub CI (in 'seen'), so it is a bit\n> hasty to conclude that the patch was sent without proper testing.\n\nYou’re right, I was a bit hasty.\n\n> I wonder what is different in _your_ environment (note, I am not\n> saying your environment is _wrong_.  It is just different, perhaps\n> the compiler I use and your build environment may align things\n> differently, or perhaps on-stack \"uninitialied\" pieces of memory\n> happen to have different values that the code is reading that causes\n> different behaviours---in which case it is the code that is wrong.\n> Asking for environment differences is the first step to figure out\n> what incorrect environment dependencies the code has).   \n>\n\n---\n\ngit version 2.43.0\ncpu: x86_64\nno commit associated with this build\nsizeof-long: 8\nsizeof-size_t: 8\n\nUsing built-in specs.\nCOLLECT_GCC=gcc\nCOLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper\nOFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa\nOFFLOAD_TARGET_DEFAULT=1\nTarget: x86_64-linux-gnu\nConfigured with: ../src/configure -v --with-pkgversion='Ubuntu \n13.3.0-6ubuntu2~24.04.1' \n--with-bugurl=file:///usr/share/doc/gcc-13/README.Bugs \n--enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr \n--with-gcc-major-version-only --program-suffix=-13 \n--program-prefix=x86_64-linux-gnu- --enable-shared \n--enable-linker-build-id --libexecdir=/usr/libexec \n--without-included-gettext --enable-threads=posix --libdir=/usr/lib \n--enable-nls --enable-bootstrap --enable-clocale=gnu \n--enable-libstdcxx-debug --enable-libstdcxx-time=yes \n--with-default-libstdcxx-abi=new --enable-libstdcxx-backtrace \n--enable-gnu-unique-object --disable-vtable-verify --enable-plugin \n--enable-default-pie --with-system-zlib \n--enable-libphobos-checking=release --with-target-system-zlib=auto \n--enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet \n--with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 \n--enable-multilib --with-tune=generic \n--enable-offload-targets=nvptx-none=/build/gcc-13-EldibY/gcc-13-13.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-13-EldibY/gcc-13-13.3.0/debian/tmp-gcn/usr \n--enable-offload-defaulted --without-cuda-driver \n--enable-checking=release --build=x86_64-linux-gnu \n--host=x86_64-linux-gnu --target=x86_64-linux-gnu \n--with-build-config=bootstrap-lto-lean --enable-link-serialization=2\nThread model: posix\nSupported LTO compression algorithms: zlib zstd\ngcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04.1)\n\nLinux malon-Yoga-14sARE-2020 6.14.0-37-generic #37~24.04.1-Ubuntu SMP \nPREEMPT_DYNAMIC Thu Nov 20 10:25:38 UTC 2 x86_64 x86_64 x86_64 GNU/Linux\n\n---\n\nBy the way, I find this bit of code rather confusing to me:\n\n> +\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n> +\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n> +\t\t2>/dev/null &&\n> +\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n\nIs this grep pattern correct?\n\nThanks, Yuchen\n"},{"id":"541496","messageId":"fcnv7hv53khhctafvzqn6dygbyq2tkyy4i2gawcbahdnevg2hw@7h6bvxlub7ib","threadId":"65446","inReplyTo":"a6382ad3-6ce4-4e85-bdff-8e90068f25dd@malon.dev","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Trieu Huynh","fromEmail":"vikingtc4@gmail.com","sentAt":"2026-04-13T18:22:00Z","receivedAt":"2026-04-13T18:22:07Z","isPatch":true,"body":"On Thu, Apr 09, 2026 at 12:34:47PM +0800, Tian Yuchen wrote:\n> On 4/9/26 02:23, Junio C Hamano wrote:\n> \n> > FWIW, I didn't see it fail in my local environment (both in 'seen'\n> > and also standalone) or at GitHub CI (in 'seen'), so it is a bit\n> > hasty to conclude that the patch was sent without proper testing.\n> \n> You’re right, I was a bit hasty.\n> \n> > I wonder what is different in _your_ environment (note, I am not\n> > saying your environment is _wrong_.  It is just different, perhaps\n> > the compiler I use and your build environment may align things\n> > differently, or perhaps on-stack \"uninitialied\" pieces of memory\n> > happen to have different values that the code is reading that causes\n> > different behaviours---in which case it is the code that is wrong.\n> > Asking for environment differences is the first step to figure out\n> > what incorrect environment dependencies the code has).\n> > \n> \n> ---\n> \n> git version 2.43.0\n> cpu: x86_64\n> no commit associated with this build\n> sizeof-long: 8\n> sizeof-size_t: 8\n> \n> Using built-in specs.\n> COLLECT_GCC=gcc\n> COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper\n> OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa\n> OFFLOAD_TARGET_DEFAULT=1\n> Target: x86_64-linux-gnu\n> Configured with: ../src/configure -v --with-pkgversion='Ubuntu\n> 13.3.0-6ubuntu2~24.04.1'\n> --with-bugurl=file:///usr/share/doc/gcc-13/README.Bugs\n> --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr\n> --with-gcc-major-version-only --program-suffix=-13\n> --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id\n> --libexecdir=/usr/libexec --without-included-gettext --enable-threads=posix\n> --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu\n> --enable-libstdcxx-debug --enable-libstdcxx-time=yes\n> --with-default-libstdcxx-abi=new --enable-libstdcxx-backtrace\n> --enable-gnu-unique-object --disable-vtable-verify --enable-plugin\n> --enable-default-pie --with-system-zlib --enable-libphobos-checking=release\n> --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch\n> --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64\n> --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-13-EldibY/gcc-13-13.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-13-EldibY/gcc-13-13.3.0/debian/tmp-gcn/usr\n> --enable-offload-defaulted --without-cuda-driver --enable-checking=release\n> --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu\n> --with-build-config=bootstrap-lto-lean --enable-link-serialization=2\n> Thread model: posix\n> Supported LTO compression algorithms: zlib zstd\n> gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04.1)\n> \n> Linux malon-Yoga-14sARE-2020 6.14.0-37-generic #37~24.04.1-Ubuntu SMP\n> PREEMPT_DYNAMIC Thu Nov 20 10:25:38 UTC 2 x86_64 x86_64 x86_64 GNU/Linux\n> \n> ---\n> \n> By the way, I find this bit of code rather confusing to me:\n> \n> > +\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n> > +\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n> > +\t\t2>/dev/null &&\n> > +\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n> \n> Is this grep pattern correct?\n> \nAFAICT, this intent is to check that \"--quiet\" appears as an argument\nin the trace2 event that contains \"negotiationAlgorithm\". That said,\nthe \"-e\" flag tells grep to treat the next argument as the search\npattern, so \"grep -e --quiet\" searches for the literal string \"--quiet\"\nrather than grep misinterpreting as one of its own options.\n\nBRs,\nTrieu Huynh\n> Thanks, Yuchen\n"},{"id":"541681","messageId":"xmqqwly86s3a.fsf@gitster.g","threadId":"65446","inReplyTo":"fcnv7hv53khhctafvzqn6dygbyq2tkyy4i2gawcbahdnevg2hw@7h6bvxlub7ib","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-04-15T17:39:21Z","receivedAt":"2026-04-15T17:39:24Z","isPatch":true,"body":"Trieu Huynh <vikingtc4@gmail.com> writes:\n\n> On Thu, Apr 09, 2026 at 12:34:47PM +0800, Tian Yuchen wrote:\n>> On 4/9/26 02:23, Junio C Hamano wrote:\n>> \n>> > FWIW, I didn't see it fail in my local environment (both in 'seen'\n>> > and also standalone) or at GitHub CI (in 'seen'), so it is a bit\n>> > hasty to conclude that the patch was sent without proper testing.\n>> \n>> You’re right, I was a bit hasty.\n>> \n>> > I wonder what is different in _your_ environment (note, I am not\n>> > saying your environment is _wrong_.  It is just different, perhaps\n>> > the compiler I use and your build environment may align things\n>> > differently, or perhaps on-stack \"uninitialied\" pieces of memory\n>> > happen to have different values that the code is reading that causes\n>> > different behaviours---in which case it is the code that is wrong.\n>> > Asking for environment differences is the first step to figure out\n>> > what incorrect environment dependencies the code has).\n>> > \n>> \n>> ---\n>> \n>> git version 2.43.0\n>> cpu: x86_64\n>> no commit associated with this build\n>> sizeof-long: 8\n>> sizeof-size_t: 8\n>> \n>> Using built-in specs.\n>> COLLECT_GCC=gcc\n>> COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper\n>> OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa\n>> OFFLOAD_TARGET_DEFAULT=1\n>> Target: x86_64-linux-gnu\n>> Configured with: ../src/configure -v --with-pkgversion='Ubuntu\n>> 13.3.0-6ubuntu2~24.04.1'\n>> --with-bugurl=file:///usr/share/doc/gcc-13/README.Bugs\n>> --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr\n>> --with-gcc-major-version-only --program-suffix=-13\n>> --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id\n>> --libexecdir=/usr/libexec --without-included-gettext --enable-threads=posix\n>> --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu\n>> --enable-libstdcxx-debug --enable-libstdcxx-time=yes\n>> --with-default-libstdcxx-abi=new --enable-libstdcxx-backtrace\n>> --enable-gnu-unique-object --disable-vtable-verify --enable-plugin\n>> --enable-default-pie --with-system-zlib --enable-libphobos-checking=release\n>> --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch\n>> --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64\n>> --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-13-EldibY/gcc-13-13.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-13-EldibY/gcc-13-13.3.0/debian/tmp-gcn/usr\n>> --enable-offload-defaulted --without-cuda-driver --enable-checking=release\n>> --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu\n>> --with-build-config=bootstrap-lto-lean --enable-link-serialization=2\n>> Thread model: posix\n>> Supported LTO compression algorithms: zlib zstd\n>> gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04.1)\n>> \n>> Linux malon-Yoga-14sARE-2020 6.14.0-37-generic #37~24.04.1-Ubuntu SMP\n>> PREEMPT_DYNAMIC Thu Nov 20 10:25:38 UTC 2 x86_64 x86_64 x86_64 GNU/Linux\n>> \n>> ---\n>> \n>> By the way, I find this bit of code rather confusing to me:\n>> \n>> > +\tGIT_TRACE2_EVENT=\"$(pwd)/pc-quiet-trace\" \\\n>> > +\t\tgit -C super-work grep --cached --recurse-submodules \"world\" \\\n>> > +\t\t2>/dev/null &&\n>> > +\tgrep negotiationAlgorithm pc-quiet-trace | grep -e --quiet\n>> \n>> Is this grep pattern correct?\n>> \n> AFAICT, this intent is to check that \"--quiet\" appears as an argument\n> in the trace2 event that contains \"negotiationAlgorithm\". That said,\n> the \"-e\" flag tells grep to treat the next argument as the search\n> pattern, so \"grep -e --quiet\" searches for the literal string \"--quiet\"\n> rather than grep misinterpreting as one of its own options.\n>\n> BRs,\n> Trieu Huynh\n>> Thanks, Yuchen\n\nThe discussion thread stalled at this point.  Are we happy with the\nproposed changes?\n\nThanks.\n"},{"id":"541685","messageId":"c87f1f12-d0cc-4150-8f43-4dc9cc1fe24f@malon.dev","threadId":"65446","inReplyTo":"xmqqwly86s3a.fsf@gitster.g","subject":"Re: [GSoC PATCH] promisor-remote: fix promisor.quiet to use the correct repository","fromName":"Tian Yuchen","fromEmail":"cat@malon.dev","sentAt":"2026-04-15T18:03:00Z","receivedAt":"2026-04-15T18:03:08Z","isPatch":true,"body":"On 4/16/26 01:39, Junio C Hamano wrote:\n> \n> The discussion thread stalled at this point.  Are we happy with the\n> proposed changes?\n> \n> Thanks.\n\nAfter running it a week later, the error had (surprisingly) disappeared, \nand I couldn’t reproduce it no matter what I tried.\n\nSince the code works well on everyone’s computer and on the CI tests, I \nsuppose I must have got it wrong earlier.\n\nThanks, Yuchen\n"}]}