{"thread":{"id":"65371","subject":"[GSoC][PATCH] doc: fix doubled words in gitdiffcore documentation","startedAt":"2026-03-28T05:41:40Z","lastAt":"2026-03-28T17:29:44Z","messageCount":2,"participants":["Noman","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"540261","messageId":"CA+TqWtWiYR+aEsQPOsOwOonc2hinjfXW0oy5mLuDOPx4Xu9mwA@mail.gmail.com","threadId":"65371","inReplyTo":null,"subject":"[GSoC][PATCH] doc: fix doubled words in gitdiffcore documentation","fromName":"Noman","fromEmail":"necrospre@gmail.com","sentAt":"2026-03-28T05:41:29Z","receivedAt":"2026-03-28T05:41:40Z","isPatch":true,"sender":{"key":"necrospre@gmail.com","avatar":null},"body":"Hello Git community,\nI am Naorem Ngathoiba Singh, a GSoC 2026 applicant interested in the\n'Improve the new git repo command' project. As my microproject, I have\nidentified and fixed some doubled words in the documentation. Below is\nmy patch.\n\nFrom 3d7b15e3bb99878a7121d8372c6298b9be930346 Mon Sep 17 00:00:00 2001\nFrom: Naorem Singh <necrospre@gmail.com>\nDate: Sat, 28 Mar 2026 10:53:36 +0530\nSubject: [PATCH] doc: fix doubled words in gitdiffcore documentation\n\nSigned-off-by: Naorem Singh <necrospre@gmail.com>\n---\n Documentation/gitdiffcore.adoc | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitdiffcore.adoc b/Documentation/gitdiffcore.adoc\nindex 642c51227b..2b3fd5a259 100644\n--- a/Documentation/gitdiffcore.adoc\n+++ b/Documentation/gitdiffcore.adoc\n@@ -133,7 +133,7 @@ input contained these filepairs:\n :000000 100644 0000000... 0123456... A file0\n ------------------------------------------------\n\n-and the contents of the deleted file fileX is similar enough to\n+and the contents of the deleted file X is similar enough to\n the contents of the created file file0, then rename detection\n merges these filepairs and creates:\n\n@@ -145,7 +145,7 @@ When the \"-C\" option is used, the original\ncontents of modified files,\n and deleted files (and also unmodified files, if the\n \"--find-copies-harder\" option is used) are considered as candidates\n of the source files in rename/copy operation.  If the input were like\n-these filepairs, that talk about a modified file fileY and a newly\n+these filepairs, that talk about a modified file Y and a newly\n created file file0:\n\n ------------------------------------------------\n--\n2.45.1.windows.1\n"},{"id":"540282","messageId":"87bjg7g8vw.fsf@gitster.g","threadId":"65371","inReplyTo":"CA+TqWtWiYR+aEsQPOsOwOonc2hinjfXW0oy5mLuDOPx4Xu9mwA@mail.gmail.com","subject":"Re: [GSoC][PATCH] doc: fix doubled words in gitdiffcore documentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2026-03-28T17:29:39Z","receivedAt":"2026-03-28T17:29:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":null},"body":"Noman <necrospre@gmail.com> writes:\n\n> diff --git a/Documentation/gitdiffcore.adoc b/Documentation/gitdiffcore.adoc\n> index 642c51227b..2b3fd5a259 100644\n> --- a/Documentation/gitdiffcore.adoc\n> +++ b/Documentation/gitdiffcore.adoc\n> @@ -133,7 +133,7 @@ input contained these filepairs:\n>  :000000 100644 0000000... 0123456... A file0\n>  ------------------------------------------------\n>\n> -and the contents of the deleted file fileX is similar enough to\n> +and the contents of the deleted file X is similar enough to\n>  the contents of the created file file0, then rename detection\n>  merges these filepairs and creates:\n\nPlease pay attention to the line just before the pre-context of the\nabove hunk, which says\n\n    :100644 000000 0123456... 0000000... D fileX\n\nand \"the deleted file fileX\" is a reference to it.\n\nIt indeed results in an awkward-sounding sentence, and I agree that\nit would have been better if we used sample filenames that sounded\ndistinctly different from \"file\" 20 years ago when we wrote the\nfirst edition of this document, but that water under the bridge has\npoured out to the ocean long ago ;-)\n\nIn principle, I would not mind an update that consistently moves us\naway from file0, file1, ... to something else both in examples and\nexplanations, but the cost of doing such a change and the cost of\nreviewing such a change to make sure no unintended mistakes sneak\nin, feels rather high, relative to the benefit.  So, I dunno.\n\n> @@ -145,7 +145,7 @@ When the \"-C\" option is used, the original\n> contents of modified files,\n>  and deleted files (and also unmodified files, if the\n>  \"--find-copies-harder\" option is used) are considered as candidates\n>  of the source files in rename/copy operation.  If the input were like\n> -these filepairs, that talk about a modified file fileY and a newly\n> +these filepairs, that talk about a modified file Y and a newly\n>  created file file0:\n>\n>  ------------------------------------------------\n> --\n> 2.45.1.windows.1\n"}]}