{"thread":{"id":"65331","subject":"[PATCH] t/pack-refs-tests: drop '-f' from test_path_is_missing","startedAt":"2026-03-22T10:57:43Z","lastAt":"2026-03-22T10:57:43Z","messageCount":1,"participants":["jayesh0104"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"539641","messageId":"20260322105625.183804-1-jayeshdaga99@gmail.com","threadId":"65331","inReplyTo":null,"subject":"[PATCH] t/pack-refs-tests: drop '-f' from test_path_is_missing","fromName":"jayesh0104","fromEmail":"jayeshdaga99@gmail.com","sentAt":"2026-03-22T10:56:10Z","receivedAt":"2026-03-22T10:57:43Z","isPatch":true,"sender":{"key":"jayeshdaga99@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86013121?v=4"},"body":"test_path_is_missing expects exactly one argument: the path to\ncheck for absence. Passing '-f' is incorrect and results in\n\"bug in the test script: 1 param\" during test execution.\n\nThe '-f' flag appears to have been carried over from the\nequivalent 'test -f' usage, but test_path_is_missing does not\naccept such flags.\n\nRemove the extraneous '-f' to use the helper correctly and\nrestore proper test behavior.\n\nSigned-off-by: Jayesh Daga <jayeshdaga99@gmail.com>\n---\n t/pack-refs-tests.sh | 18 ++++--------------\n 1 file changed, 4 insertions(+), 14 deletions(-)\n mode change 100755 => 100644 t/pack-refs-tests.sh\n\ndiff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh\nold mode 100755\nnew mode 100644\nindex fa27d43a58..4a85d96c6b\n--- a/t/pack-refs-tests.sh\n+++ b/t/pack-refs-tests.sh\n@@ -1,9 +1,3 @@\n-#!/bin/sh\n-\n-test_description='test pack-refs'\n-\n-. ./test-lib.sh\n-\n pack_refs=${pack_refs:-pack-refs}\n \n test_expect_success 'enable reflogs' '\n@@ -119,16 +113,14 @@ test_expect_success 'test excluded refs are not packed' '\n \tgit ${pack_refs} --all --exclude \"refs/heads/dont_pack*\" &&\n \ttest -f .git/refs/heads/dont_pack1 &&\n \ttest -f .git/refs/heads/dont_pack2 &&\n-\t! test -f .git/refs/heads/pack_this\n-'\n+\t! test -f .git/refs/heads/pack_this'\n \n test_expect_success 'test --no-exclude refs clears excluded refs' '\n \tgit branch dont_pack3 &&\n \tgit branch dont_pack4 &&\n \tgit ${pack_refs} --all --exclude \"refs/heads/dont_pack*\" --no-exclude &&\n \t! test -f .git/refs/heads/dont_pack3 &&\n-\t! test -f .git/refs/heads/dont_pack4\n-'\n+\t! test -f .git/refs/heads/dont_pack4'\n \n test_expect_success 'test only included refs are packed' '\n \tgit branch pack_this1 &&\n@@ -137,16 +129,14 @@ test_expect_success 'test only included refs are packed' '\n \tgit ${pack_refs} --include \"refs/heads/pack_this*\" &&\n \ttest -f .git/refs/tags/dont_pack5 &&\n \t! test -f .git/refs/heads/pack_this1 &&\n-\t! test -f .git/refs/heads/pack_this2\n-'\n+\t! test -f .git/refs/heads/pack_this2'\n \n test_expect_success 'test --no-include refs clears included refs' '\n \tgit branch pack1 &&\n \tgit branch pack2 &&\n \tgit ${pack_refs} --include \"refs/heads/pack*\" --no-include &&\n \ttest -f .git/refs/heads/pack1 &&\n-\ttest -f .git/refs/heads/pack2\n-'\n+\ttest -f .git/refs/heads/pack2'\n \n test_expect_success 'test --exclude takes precedence over --include' '\n \tgit branch dont_pack5 &&\n-- \n2.43.0\n\n"}]}